Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 397789 - media-video/mplayer-1.0_rc4_p20120105 make hangs (loops forever)
Summary: media-video/mplayer-1.0_rc4_p20120105 make hangs (loops forever)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2012-01-05 18:09 UTC by octoploid
Modified: 2012-01-09 14:52 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description octoploid 2012-01-05 18:09:12 UTC
emerging media-video/mplayer-1.0_rc4_p20120105 fails because
"make" is apparently caught in an eternal loop.
...
>>> Source configured.
>>> Compiling source in /var/tmp/portage/media-video/mplayer-1.0_rc4_p20120105/work/mplayer-1.0_rc4_p20120105 ...
make -j4 
(hang)

"perf top" shows: 
 37.66%  gmake                       [.] next_token
 37.06%  gmake                       [.] parse_file_seq
 16.32%  libc-2.15.so                [.] __ctype_b_loc
  5.31%  gmake                       [.] __ctype_b_loc@plt

(gdb) bt
#0  0x00000000004155d3 in parse_file_seq ()
#1  0x0000000000416b16 in eval ()
#2  0x00000000004171da in eval_makefile ()
#3  0x000000000041757c in read_all_makefiles ()
#4  0x0000000000411608 in main ()

mplayer-1.0_rc4_p20111215 is fine



Reproducible: Always
Comment 1 Alexis Ballier gentoo-dev 2012-01-05 19:16:10 UTC
hmm, does -9999 exhibit the problem ?

could you please attach an output of 'make -d' ?
Comment 2 octoploid 2012-01-05 19:51:55 UTC
(In reply to comment #1)
> hmm, does -9999 exhibit the problem ?

Yes.
 
> could you please attach an output of 'make -d' ?


GNU Make 3.82
Built for x86_64-pc-linux-gnu
Copyright (C) 2010  Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.
Reading makefiles...
Reading makefile `Makefile'...
Reading makefile `config.mak' (search path) (no ~ expansion)...
(hang)
Comment 3 Alexis Ballier gentoo-dev 2012-01-05 20:23:17 UTC
(In reply to comment #2)
> (In reply to comment #1)
> > hmm, does -9999 exhibit the problem ?
> 
> Yes.
> 
> > could you please attach an output of 'make -d' ?
> 
> 
> GNU Make 3.82
> Built for x86_64-pc-linux-gnu
> Copyright (C) 2010  Free Software Foundation, Inc.
> License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
> This is free software: you are free to change and redistribute it.
> There is NO WARRANTY, to the extent permitted by law.
> Reading makefiles...
> Reading makefile `Makefile'...
> Reading makefile `config.mak' (search path) (no ~ expansion)...
> (hang)

then please attach your config.mak (configure output maybe useful too)
Comment 4 Alexis Ballier gentoo-dev 2012-01-05 20:25:43 UTC
(In reply to comment #3)

> then please attach your config.mak (configure output maybe useful too)

and the ones from mplayer-1.0_rc4_p20111215 to compare
Comment 5 octoploid 2012-01-05 20:39:04 UTC
The following lines in the Makefile cause the problem:

###### regression tests #######

BROKEN_SAMPLES =                         \
    h264-conformance/CABA3_TOSHIBA_E.264 \
    h264-conformance/CAPA1_TOSHIBA_B.264 \
    h264-conformance/CI1_FT_B.264        \
    h264-conformance/FM1_FT_E.264        \
    pva/PVA_test-partial.pva             \

AUDIO_ONLY_SAMPLES =                                               \
    aac/% ac3/% amrnb/% amrwb/% atrac1/% atrac3/% bink/binkaudio%  \
    creative/% dts/% duck/%-audio-only.avi eac3/% gsm/% imc/%      \
    lossless-audio/% mp3-conformance/% musepack/% nellymoser/%     \
    qt-surge-suite/% real/ra% sipr/% truespeech/% vorbis/%         \
    vqf/% w64/% wmapro/% wmavoice/%                                \

ALLSAMPLES_FULLPATH = $(wildcard $(FATE_SAMPLES)/*/*.*)
ALLSAMPLES          = $(patsubst $(FATE_SAMPLES)/%,%,$(ALLSAMPLES_FULLPATH))
SAMPLES := $(filter-out $(BROKEN_SAMPLES),$(ALLSAMPLES))
SAMPLES := $(filter-out $(AUDIO_ONLY_SAMPLES),$(SAMPLES))
RESULTS  = $(patsubst %,tests/res/%.md5,$(SAMPLES))

fatetest: $(RESULTS)

tests/res/%.md5: mplayer$(EXESUF) $(FATE_SAMPLES)/%
        @tests/faterun.sh $*

When I delete them the problem is gone.
Comment 6 Alexis Ballier gentoo-dev 2012-01-05 20:43:39 UTC
(In reply to comment #5)
> The following lines in the Makefile cause the problem:
> 
> ###### regression tests #######
> 
> BROKEN_SAMPLES =                         \
>     h264-conformance/CABA3_TOSHIBA_E.264 \
>     h264-conformance/CAPA1_TOSHIBA_B.264 \
>     h264-conformance/CI1_FT_B.264        \
>     h264-conformance/FM1_FT_E.264        \
>     pva/PVA_test-partial.pva             \
> 
> AUDIO_ONLY_SAMPLES =                                               \
>     aac/% ac3/% amrnb/% amrwb/% atrac1/% atrac3/% bink/binkaudio%  \
>     creative/% dts/% duck/%-audio-only.avi eac3/% gsm/% imc/%      \
>     lossless-audio/% mp3-conformance/% musepack/% nellymoser/%     \
>     qt-surge-suite/% real/ra% sipr/% truespeech/% vorbis/%         \
>     vqf/% w64/% wmapro/% wmavoice/%                                \
> 
> ALLSAMPLES_FULLPATH = $(wildcard $(FATE_SAMPLES)/*/*.*)
> ALLSAMPLES          = $(patsubst $(FATE_SAMPLES)/%,%,$(ALLSAMPLES_FULLPATH))
> SAMPLES := $(filter-out $(BROKEN_SAMPLES),$(ALLSAMPLES))
> SAMPLES := $(filter-out $(AUDIO_ONLY_SAMPLES),$(SAMPLES))
> RESULTS  = $(patsubst %,tests/res/%.md5,$(SAMPLES))
> 
> fatetest: $(RESULTS)
> 
> tests/res/%.md5: mplayer$(EXESUF) $(FATE_SAMPLES)/%
>         @tests/faterun.sh $*
> 
> When I delete them the problem is gone.

nice, could you please try to isolate the problem a bit further by trying to remove only some of these lines to eventually get a clue of what is the offending one ?
Comment 7 Alexis Ballier gentoo-dev 2012-01-05 20:58:02 UTC
oh, and since my build was fine, could you try to 'emerge -1 sys-devel/make' to see if that resolves the problem.
Comment 8 octoploid 2012-01-05 20:59:41 UTC
(In reply to comment #6)
> (In reply to comment #5)
> > The following lines in the Makefile cause the problem:
> > 
> > ###### regression tests #######
> > 
> > BROKEN_SAMPLES =                         \
> >     h264-conformance/CABA3_TOSHIBA_E.264 \
> >     h264-conformance/CAPA1_TOSHIBA_B.264 \
> >     h264-conformance/CI1_FT_B.264        \
> >     h264-conformance/FM1_FT_E.264        \
> >     pva/PVA_test-partial.pva             \
> > 
> > AUDIO_ONLY_SAMPLES =                                               \
> >     aac/% ac3/% amrnb/% amrwb/% atrac1/% atrac3/% bink/binkaudio%  \
> >     creative/% dts/% duck/%-audio-only.avi eac3/% gsm/% imc/%      \
> >     lossless-audio/% mp3-conformance/% musepack/% nellymoser/%     \
> >     qt-surge-suite/% real/ra% sipr/% truespeech/% vorbis/%         \
> >     vqf/% w64/% wmapro/% wmavoice/%                                \
> > 
> > ALLSAMPLES_FULLPATH = $(wildcard $(FATE_SAMPLES)/*/*.*)
> > ALLSAMPLES          = $(patsubst $(FATE_SAMPLES)/%,%,$(ALLSAMPLES_FULLPATH))
> > SAMPLES := $(filter-out $(BROKEN_SAMPLES),$(ALLSAMPLES))
> > SAMPLES := $(filter-out $(AUDIO_ONLY_SAMPLES),$(SAMPLES))
> > RESULTS  = $(patsubst %,tests/res/%.md5,$(SAMPLES))
> > 
> > fatetest: $(RESULTS)
> > 
> > tests/res/%.md5: mplayer$(EXESUF) $(FATE_SAMPLES)/%
> >         @tests/faterun.sh $*
> > 
> > When I delete them the problem is gone.
> 
> nice, could you please try to isolate the problem a bit further by trying to
> remove only some of these lines to eventually get a clue of what is the
> offending one ?

It looks like $(FATE_SAMPLES) is undefined. 
Adding e.g. "FATE_SAMPLES=foo" to the Makefile is enough to solve the issue.
Comment 9 octoploid 2012-01-05 21:01:26 UTC
(In reply to comment #7)
> oh, and since my build was fine, could you try to 'emerge -1 sys-devel/make' to
> see if that resolves the problem.

I've already tried this and it didn't help.
(with make-3.82-r4 it also hangs)
Comment 10 Alexis Ballier gentoo-dev 2012-01-05 21:12:42 UTC
okey,

reimar, i've seen you posted a patch to mplayer-dev-eng about that kind of issues, is it what you call 'fatetest behaves badly if FATE_SAMPLES is not set.' in your mail ? cause here i cannot reproduce the problem but it seems a true one :)
Comment 11 Alexis Ballier gentoo-dev 2012-01-09 14:52:16 UTC
(In reply to comment #10)
> okey,
> 
> reimar, i've seen you posted a patch to mplayer-dev-eng about that kind of
> issues, is it what you call 'fatetest behaves badly if FATE_SAMPLES is not
> set.' in your mail ? cause here i cannot reproduce the problem but it seems a
> true one :)

1.0_rc4_p20120109 should fix this