Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 397575 - media-libs/faac-1.28-r1 with media-libs/libmp4v2-1.9.1_p479 - main.c:876:9: error: too few arguments to function 'MP4Close'
Summary: media-libs/faac-1.28-r1 with media-libs/libmp4v2-1.9.1_p479 - main.c:876:9: e...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Sound Team
URL: https://sourceforge.net/tracker/?func...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2012-01-04 00:49 UTC by Jaakko Perttilä
Modified: 2012-02-23 13:42 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
faac-1.28-libmp4v2_r479.patch (faac-1.28-libmp4v2_r479.patch,1.76 KB, patch)
2012-01-04 00:55 UTC, Jaakko Perttilä
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jaakko Perttilä 2012-01-04 00:49:50 UTC
libmp4v2 r453 and r479 change some of the code in include/mp4v2/file.h, so faac-1.28/frontend/main.c fails to build.

Reproducible: Always

Steps to Reproduce:
1. emerge media-libs/libmp4v2-1.9.1_p479
2. emerge media-libs/faac-1.28-r1
3.
Actual Results:  
make[2]: Entering directory `/var/tmp/paludis/media-libs-faac-1.28-r1/work/faac-1.28/frontend'                                                                                                       
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I.. -I../include -I../common/mp4v2    -O2 -march=core2 -msse4.1 -c main.c                                                                               
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I.. -I../include -I../common/mp4v2    -O2 -march=core2 -msse4.1 -c input.c                                                                              
main.c: In function 'main':                                                                                                                                                                          
main.c:721:9: warning: format not a string literal and no format arguments                                                                                                                           
main.c:876:9: error: too few arguments to function 'MP4Close'                                                                                                                                        
/usr/include/mp4v2/file.h:56:6: note: declared here                                                                                                                                                  
main.c:893:39: error: 'MP4_DETAILS_ERROR' undeclared (first use in this function)                                                                                                                    
main.c:893:39: note: each undeclared identifier is reported only once for each function it appears in                                                                                                
main.c:893:5: error: too many arguments to function 'MP4Create'                                                                                                                                      
/usr/include/mp4v2/file.h:83:15: note: declared here                                                                                                                                                 
main.c:1144:13: error: too few arguments to function 'MP4Close'                                                                                                                                      
/usr/include/mp4v2/file.h:56:6: note: declared here                                                                                                                                                  
main.c:1148:17: error: too many arguments to function 'MP4Optimize'                                                                                                                                  
/usr/include/mp4v2/file.h:307:6: note: declared here                                                                                                                                                 
main.c:1131:27: warning: ignoring return value of 'fwrite', declared with attribute warn_unused_result                                                                                               
make[2]: *** [main.o] Error 1                                                                                                                                                                        
make[2]: *** Waiting for unfinished jobs....                                                                                                                                                         
make[2]: Leaving directory `/var/tmp/paludis/media-libs-faac-1.28-r1/work/faac-1.28/frontend'                                                                                                        
make[1]: Leaving directory `/var/tmp/paludis/media-libs-faac-1.28-r1/work/faac-1.28'                                                                                                                 
make[1]: *** [all-recursive] Error 1                                                                                                                                                                 
make: *** [all] Error 2
Comment 1 Jaakko Perttilä 2012-01-04 00:55:52 UTC
Created attachment 297863 [details, diff]
faac-1.28-libmp4v2_r479.patch

Just wrote this and it builds here with this patch.
I haven't tried the patch with stable libmp4v2-1.9.1
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2012-01-20 18:49:51 UTC
(I don't know if this link works since I'm logged in to the sf.net bugtracking system)

https://sourceforge.net/tracker/?func=detail&aid=3476707&group_id=704&atid=100704

But it's an artifact called:

"3476707", "No support for libmp4v2 r479 (latest upstream release)"
Comment 3 Samuli Suominen (RETIRED) gentoo-dev 2012-01-20 18:59:29 UTC
+*faac-1.28-r2 (20 Jan 2012)
+
+  20 Jan 2012; Samuli Suominen <ssuominen@gentoo.org> +faac-1.28-r2.ebuild,
+  +files/faac-1.28-libmp4v2_r479_compat.patch:
+  Initial attempt at supporting libmp4v2 revision r479 wrt #397575 by Jaakko
+  Perttilä
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2012-02-06 15:51:10 UTC
reopening as the attached patch is incomplete, as noted in the upstream bug (see URL field of this bug)
Comment 5 Samuli Suominen (RETIRED) gentoo-dev 2012-02-23 13:42:42 UTC
Adjusted patch was committed to upstream CVS repository and I've pushed it as -r3 in tree, closing again.