Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 396637 - dev-util/devhelp-3.2.0: devhelp shouldn't depend on libgnome just for 2 font keys
Summary: dev-util/devhelp-3.2.0: devhelp shouldn't depend on libgnome just for 2 font ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL: https://bugzilla.gnome.org/show_bug.c...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-31 21:36 UTC by Rafał Mużyło
Modified: 2012-05-03 05:08 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patch for gsettings global interface schema use (devhelp-3.2.0-fix-system-font.patch,3.16 KB, patch)
2011-12-31 21:36 UTC, Rafał Mużyło
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Rafał Mużyło 2011-12-31 21:36:31 UTC
Created attachment 297487 [details, diff]
patch for gsettings global interface schema use

It seems my report on irc got the exact opposite result of the intended one.

AFAICT, devhelp 3.2.0 uses only 2 keys provided by desktop_gnome_interface.schemas - /desktop/gnome/interface/font_name and /desktop/gnome/interface/monospace_font_name.

Based on the patch from https://bugzilla.gnome.org/show_bug.cgi?id=646402, I've wrote a minimal that uses org.gnome.desktop.interface gsettings schema, as the rest of Gnome 3. The only "added" dep in such case would be gnome-base/gsettings-desktop-schemas, but already (almost) whole Gnome 3 depends on it in one way or the other.

The patch seems to work correctly, that is if devhelp is forced to re-read the key, font gets changed.
Comment 1 Rafał Mużyło 2012-05-02 17:58:06 UTC
A little note in regard of 3.4.0: the patch is still correct, though epatch fails, cause the offsets are off by too much.
Comment 2 Alexandre Rostovtsev (RETIRED) gentoo-dev 2012-05-03 05:08:09 UTC
Patch appears safe and reasonable. Normally, I would prefer waiting for upstream to comment, but devhelp's upstream seems to be unresponsive. Applied in 3.4.1 with some cosmetic modifications.

>*devhelp-3.4.1 (03 May 2012)
>
>  03 May 2012; Alexandre Rostovtsev <tetromino@gentoo.org>
>  +devhelp-3.4.1.ebuild, +files/devhelp-3.4.1-gsettings-fonts.patch:
>  Version bump, now supports globs in search tab. Add patch to use gsettings
>  instead of libgnome's gconf keys for default fonts (bug #396637, thanks to
>  Rafał Mużyło).