Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 396317 - gnome-base/gdm: please improve systemd service file
Summary: gnome-base/gdm: please improve systemd service file
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords: Inclusion
Depends on:
Blocks:
 
Reported: 2011-12-28 15:11 UTC by Michał Górny
Modified: 2013-07-27 11:51 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Improved gdm.service (gdm.service,174 bytes, text/plain)
2011-12-28 15:28 UTC, Michał Górny
Details
Service file for gdm3 (gdm.service,202 bytes, text/plain)
2011-12-29 14:32 UTC, Michał Górny
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2011-12-28 15:11:29 UTC
As explained in bug #373003. Will attach a patch in a while.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2011-12-28 15:28:35 UTC
Created attachment 297211 [details]
Improved gdm.service

Or -- wget-friendly version: https://raw.github.com/mgorny/gentoo-systemd-units/master/gnome-base:gdm/gdm.service

The service is as simple as it should be. You may also want to copy pkg_postinst() from x11-apps/xdm to support automatically updating enabled services.
Comment 2 Pacho Ramos gentoo-dev 2011-12-28 16:21:24 UTC
From my point of view, feel free to commit a new gdm-2.20 revision with systemd support as you can test it much better than me (I don't use systemd at all)
Comment 3 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2011-12-28 17:05:21 UTC
(In reply to comment #2)
> From my point of view, feel free to commit a new gdm-2.20 revision with systemd
> support as you can test it much better than me (I don't use systemd at all)

And I don't use gdm at all :D. I'll find some user to test it.
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2011-12-28 17:56:28 UTC
Ehm, right now the unit in gdm-3 is added via gdm-*-gentoo-files. How we're supposed to handle that? Bumping it or adding fixed file in files/?
Comment 5 Alexandre Rostovtsev (RETIRED) gentoo-dev 2011-12-29 02:57:37 UTC
(In reply to comment #1)
> Created attachment 297211 [details]
> Improved gdm.service

gdm-3.x has a dbus interface. Shouldn't there be a "BusName=org.gnome.DisplayManager" line? Will systemd automatically detect the dbus dependency (without which gdm fails to start, see bug #390609), or should it be added explicitly?

(In reply to comment #4)
> Ehm, right now the unit in gdm-3 is added via gdm-*-gentoo-files. How we're
> supposed to handle that? Bumping it or adding fixed file in files/?

After the new .service file has been tested, I will revbump the gdm-*-gentoo-files archive and the ebuild :)
Comment 6 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2011-12-29 13:46:39 UTC
(In reply to comment #5)
> (In reply to comment #1)
> > Created attachment 297211 [details]
> > Improved gdm.service
> 
> gdm-3.x has a dbus interface. Shouldn't there be a
> "BusName=org.gnome.DisplayManager" line? Will systemd automatically detect the
> dbus dependency (without which gdm fails to start, see bug #390609), or should
> it be added explicitly?

Ah, is that interface started unconditionally? Is it enabled at the very beginning? If yes, I'd switch to Type=dbus for it.
Comment 7 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2011-12-29 14:32:46 UTC
Created attachment 297305 [details]
Service file for gdm3

And here's file supposedly for gdm3. We can sed -e '/[Bb]us/d' it for gdm2.
Comment 8 Gilles Dartiguelongue (RETIRED) gentoo-dev 2011-12-30 12:15:01 UTC
The gentoo-files tarball is a relic from times when we lots of files to keep updated with each gdm bumps. This time is most likely over, so feel free to add your file to FILESDIR directly, provided you have a version number in its filename so it can be updated without changing content of installed files in older ebuilds when we have to change it.
Comment 9 Alexandre Rostovtsev (RETIRED) gentoo-dev 2011-12-31 08:39:39 UTC
Fixed in 3.2.1.1-r2. I do not use gdm-2, so would prefer if someone who at least has it installed makes the commit for it :)
Comment 10 Luis Medinas 2012-01-30 15:15:40 UTC
I think it could be also interesting to add and explicitly stop plymouth after calling gdm. See the fedora service http://cgit.freedesktop.org/systemd/systemd/tree/units/fedora/prefdm.service
Comment 11 Luis Medinas 2012-05-18 15:48:41 UTC
I think there's some problems with the current service because with plymouth and gdm[plymouth] i don't get a smooth transition, i guess that's because gdm is starting too late with systemd. Any hints here ?
Comment 12 Alexandre Rostovtsev (RETIRED) gentoo-dev 2012-05-18 23:39:51 UTC
(In reply to comment #11)
Unfortunately, I can't help you with that: I don't use systemd, and I cannot use plymouth on my gnome-3.4 machine due to nvidia-drivers.
Comment 13 Luis Medinas 2012-05-24 09:02:46 UTC
(In reply to comment #12)
> Unfortunately, I can't help you with that: I don't use systemd, and I cannot
> use plymouth on my gnome-3.4 machine due to nvidia-drivers.

You can use plymouth with nvidia but you have to use plymouth w/text instead... you'll get something similar what you see with ubuntu and fedora livecds.
Comment 14 Pacho Ramos gentoo-dev 2013-07-27 11:51:21 UTC
we are using upstream files in 3.8.3.1