Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 395747 - media-radio/fldigi removal request (missing fltk-1.3 support)
Summary: media-radio/fldigi removal request (missing fltk-1.3 support)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Keywording and Stabilization (show other bugs)
Hardware: All Linux
: Normal normal with 1 vote (vote)
Assignee: Thomas Beierlein
URL:
Whiteboard:
Keywords: PMASKED
Depends on:
Blocks: 359629 394859 395739
  Show dependency tree
 
Reported: 2011-12-22 23:55 UTC by Samuli Suominen (RETIRED)
Modified: 2012-01-12 16:25 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Update fldigi 3.21.33 to fltk 1.3 compile (fldigi-fltk-1.3-compile.patch,9.89 KB, patch)
2011-12-27 06:11 UTC, Krellan
Details | Diff
fldigi-3.21.34.ebuild (fldigi-3.21.34.ebuild,1.42 KB, patch)
2012-01-03 17:02 UTC, Samuli Suominen (RETIRED)
Details | Diff
fldigi-3.21.34-int.patch (fldigi-3.21.34-int.patch,1.44 KB, patch)
2012-01-03 17:03 UTC, Samuli Suominen (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Samuli Suominen (RETIRED) gentoo-dev 2011-12-22 23:55:22 UTC
fltk-1.1 is about to be removed from tree in favour of fltk-1.3 from bug 395739. long overdue.
Comment 1 Krellan 2011-12-26 20:15:41 UTC
A shame to remove this package, but if the maintainer won't keep up with library upgrades, what can we do?  It's the alternative of holding back the library to support this one program, or allowing the library upgrade to proceed, breaking this program.  A shame Gentoo can't use two different slots for the library, or something like that, so they can coexist.
Comment 2 Thomas Beierlein gentoo-dev 2011-12-26 21:20:11 UTC
(In reply to comment #1)
> A shame to remove this package, but if the maintainer won't keep up with
> library upgrades, what can we do?  It's the alternative of holding back the
> library to support this one program, or allowing the library upgrade to
> proceed, breaking this program.  A shame Gentoo can't use two different slots
> for the library, or something like that, so they can coexist.

I talked to upstream to clarify the situation. He had a co-worker which was responsible for the migration, but Dave lost contact to that person and could not get any response for the last month. 

I am sure we will have a solution before dropping fldigi from tree.
Comment 3 Krellan 2011-12-27 00:01:18 UTC
Nice!!  Thank you for following up on this.
Comment 4 Krellan 2011-12-27 06:11:14 UTC
Created attachment 297057 [details, diff]
Update fldigi 3.21.33 to fltk 1.3 compile

This patch updates fldigi 3.21.33 so that it will compile successfully with fltk 1.3 library version.

I briefly tested it against DOA, the program seemed to come up and run OK, but was not extensively tested.

Will use other comment to explain what's in here.
Comment 5 Krellan 2011-12-27 06:22:17 UTC
What's in the patch:

1) Contents of other patch from here:

http://www.mail-archive.com/gentoo-dev@lists.gentoo.org/msg47084.html

2) Change of API from position() to scroll_to() in Fl_Scroll class, as recommended here:

http://www.fltk.org/doc-1.3/migration_1_3.html

This was in the "wefax" module.  I couldn't find any other usage of Fl_Scroll in the program.

3) Removed rectangular text selection support from Fl_Text_Buffer_mod class, as it's no longer in the API for fltk 1.3, which caused compilation to break.

I just disabled it entirely, and in the few places where the code attempts to decide whether a selection is rectangular or normal, I just bluntly force it to be treated as normal now.  Perhaps not the best solution, but I didn't understand the code well enough to rewrite it, and it doesn't seem to use rectangular text selection for anything.

4) Removed "includes" functionality from Fl_Text_Display_mod class, for the same reason.

This seemed to just be used for a style mask setting.  Hopefully it was just cosmetic.

So, hopefully this patch is useful.  Even if it's not a 100% clean solution (we'd need upstream support for that), it would be better than removing the program from Gentoo entirely.
Comment 6 Thomas Beierlein gentoo-dev 2011-12-29 16:33:35 UTC
In meantime upstream is in final tests for the next version with fltk-1.3 support. Should be in tree in next few days.
Comment 7 Samuli Suominen (RETIRED) gentoo-dev 2012-01-03 17:01:34 UTC
(In reply to comment #6)
> In meantime upstream is in final tests for the next version with fltk-1.3
> support. Should be in tree in next few days.

I don't know about that, 3.21.34 was released without working support for fltk-1.3 :-(
Comment 8 Samuli Suominen (RETIRED) gentoo-dev 2012-01-03 17:02:08 UTC
Created attachment 297811 [details, diff]
fldigi-3.21.34.ebuild
Comment 9 Samuli Suominen (RETIRED) gentoo-dev 2012-01-03 17:03:29 UTC
Created attachment 297813 [details, diff]
fldigi-3.21.34-int.patch

patch for prev. ebuild but it still fails to link here...
Comment 10 Krellan 2012-01-04 05:32:06 UTC
Interesting.  As of this writing, the official download page only goes up to 3.21.33.

http://www.w1hkj.com/download.html

Where is version 3.21.34 at?
Comment 11 Thomas Beierlein gentoo-dev 2012-01-04 06:24:20 UTC
(In reply to comment #7)
> (In reply to comment #6)
> > In meantime upstream is in final tests for the next version with fltk-1.3
> > support. Should be in tree in next few days.
> 
> I don't know about that, 3.21.34 was released without working support for
> fltk-1.3 :-(

Where does this come from? Official release is still 3.21.33.

Dave (upstream) was very busy the last days to port the whole flxxx program suite to fltk-1.3. There is a team of arch testers around which do the test for different linux, windows and mac os versions.

We are testing atm fldigi 3.21.35 internally. It contains full patches for fltk-1.3.0 as well as 1.1.10. Before the final release there are still some minor problems to fix for the mac os port.
Comment 12 Thomas Beierlein gentoo-dev 2012-01-04 06:28:23 UTC
(In reply to comment #11)
> 
> Where does this come from? Official release is still 3.21.33.
> 
To answer myself. Dave seems to have prepared a version in the download area which is not officially announced.
Comment 13 Krellan 2012-01-04 07:57:50 UTC
Cool, good to know upstream's working on it, guess I'll just be patient and wait for the release.

In the meantime, I tried my patch on the git tree (from the berlios fldigi site), and it also compiled cleanly there, and gave me a working fldigi running on fltk 1.3.
Comment 14 Thomas Beierlein gentoo-dev 2012-01-05 16:14:56 UTC
Upstream has a version supporting ftlk-1.3 nearly ready. As the only problems are for Mac OS they gave an 'ok' for a linux pre release. Will be replaced by the final one as soon as available.

+*fldigi-3.21.35_pre1 (05 Jan 2012)
+
+  05 Jan 2012; Thomas Beierlein <tomjbe@gentoo.org>
+  +fldigi-3.21.35_pre1.ebuild:
+  Prerelease version working with fltk-1.3.0 as well as fltk-1.1.10. See bug
+  #395747
+

Dropped mask as fltk-1.3 is supported now..

+  05 Jan 2012; Thomas Beierlein <tomjbe@gentoo.org> package.mask:
+  Drop mask for media-radio/fldigi as a version supporting fltk-1.3 is in the
+  tree
+
Comment 15 John Sennesael 2012-01-12 16:25:04 UTC
Eek! I nearly got a heart-attack when I read the removal notice in portage for fldigi.
Glad to see that we'll get a brand new version soon. Whew. 
Thanks guys! 

( I'd be more than willing to provide additional help maintaining this package if ever needed. Just drop me a mail should the need arise.  )