Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 395241 - FEATURES=installsources installing sources to incorrect path
Summary: FEATURES=installsources installing sources to incorrect path
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-19 05:58 UTC by Chetan Reddy
Modified: 2011-12-20 00:12 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
change prepstrip_sources_dir to not include EPREFIX (prepstrip.diff,228 bytes, patch)
2011-12-19 06:13 UTC, Chetan Reddy
Details | Diff
disable setting of ${ED} to incorrect value (prepall.diff,91 bytes, patch)
2011-12-19 17:33 UTC, Chetan Reddy
Details | Diff
emerge info (emerge.info,3.81 KB, text/plain)
2011-12-19 18:05 UTC, Chetan Reddy
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Chetan Reddy 2011-12-19 05:58:23 UTC
After ecopying and installing dev-util/debugedit, FEATURES=installsources doesn't quite work because the prepstrip script has this:

rsync -tL0 --files-from=- "${WORKDIR}/" "${ED}${prepstrip_sources_dir}/"

where prepstrip_sources_dir is defined as:
prepstrip_sources_dir="${EPREFIX}"/usr/src/debug/${CATEGORY}/${PF}

${ED} is defined as ${D}/${EPREFIX}, so ${EPREFIX} appears twice in the rsync dest dir, which causes QA failures with "double prefix files installed."


Reproducible: Always

Steps to Reproduce:
1. ecopy dev-util/debugedit and install it
2. FEATURES=installsources emerge htop
3. you'll see emerge fail and spit out "Aborting due to QA concerns: double prefix files installed"
Comment 1 Chetan Reddy 2011-12-19 06:13:28 UTC
Created attachment 296345 [details, diff]
change prepstrip_sources_dir to not include EPREFIX

This patch to ebuild-helpers/prepstrip fixes the issue for me.
Comment 2 Chetan Reddy 2011-12-19 17:09:33 UTC
So, emerging htop works with the patch, but now rpm2targz fails with QA concerns. The problem seems to be that ${ED} is expanding to ${D} and not ${D}/${EPREFIX} in the prepstrip script when emerging rpm2targz. Whereas it expands correctly to ${D}/${EPREFIX} when emerging htop.

Any ideas as to why this may be happening?
Comment 3 Chetan Reddy 2011-12-19 17:33:39 UTC
Created attachment 296373 [details, diff]
disable setting of ${ED} to incorrect value

This additional patch fixes the problem for me.
Comment 4 Fabian Groffen gentoo-dev 2011-12-19 17:56:10 UTC
can you please post your emerge --info?
Comment 5 Chetan Reddy 2011-12-19 18:05:40 UTC
Created attachment 296375 [details]
emerge info

Attached. Also, my patch in comment #3 is for ebuild-helpers/prepall
Comment 6 Fabian Groffen gentoo-dev 2011-12-19 18:10:35 UTC
Yes, thanks, but without file and context, that patch is really close to unusable.  Please use diff -u for patches.

First you can update your portage to 2.2.01.19941, that already fixes the case with ED thing.  Next I just committed a patch that does a similar thing to what you did in comment #1.
Comment 7 Chetan Reddy 2011-12-19 18:17:02 UTC
Cool. Thank you. Can you also add dev-util/debugedit to the prefix tree to make installsources work without having to ecopy the script? If it needs a new ticket, i can do that.
Comment 8 Fabian Groffen gentoo-dev 2011-12-19 18:20:15 UTC
If it needs more than a straight import, then you'll have to file a new bug for that, please.
Comment 9 Chetan Reddy 2011-12-19 18:23:19 UTC
Just doing an ecopy worked, without making any more modifications at all. If that doesn't count as a straight-forwad import, please close this ticket and i'll create a new one.
Comment 10 Fabian Groffen gentoo-dev 2011-12-19 18:24:42 UTC
can only close this one once I release a portage with a fix for this one ;)
Comment 11 Fabian Groffen gentoo-dev 2011-12-19 18:55:18 UTC
ok, fix released in 2.2.01.19981, thanks
Comment 12 Zac Medico gentoo-dev 2011-12-20 00:12:12 UTC
This commit makes the master branch compatible with prefix:

http://git.overlays.gentoo.org/gitweb/?p=proj/portage.git;a=commit;h=b135c01eff4ea89d16ae711271cc215388d08d17