Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 394785 - dev-ruby/facter-1.6.4 rekeywording request
Summary: dev-ruby/facter-1.6.4 rekeywording request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Keywording and Stabilization (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Ruby Team
URL:
Whiteboard:
Keywords: KEYWORDREQ, PATCH
Depends on:
Blocks: 446954
  Show dependency tree
 
Reported: 2011-12-15 07:35 UTC by Hans de Graaff
Modified: 2014-04-25 13:00 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Hans de Graaff gentoo-dev Security 2011-12-15 07:35:04 UTC
I have just dropped your keywords on dev-ruby/facter (a puppet dependency) due to a new dependency on sys-apps/dmidecode.

Please test and keyword:

=sys-apps/dmidecode-2.11
=dev-ruby/facter-1.6.4

I don't know if dmidecode will even work on your arches (I guess that depends a lot on the hardware specifics). I've added this dependency to follow upstream's intentions as expressed in the Changelog and the redhat.spec file they maintain. If it turns out that dmidecode won't work at all then we need to figure out another approach here.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2011-12-15 19:11:34 UTC
sys-apps/dmidecode compiles and runs fine on HPPA. However, facter does not actually require it to run properly, and the output is exactly the same, so the dependency is doubtful - I hesitate to pull in another package that has absolutely no benefit, so a use.mask would be nice.
Comment 2 Jeroen Roovers (RETIRED) gentoo-dev 2011-12-29 17:12:41 UTC
I failed to note that while dmidecode builds and runs fine, the platform has no support for DMI, and dmidecode fails gracefully while facter nicely falls back to other methods, so there should be no reason to keyword it for HPPA.
Comment 3 Brent Baude (RETIRED) gentoo-dev 2012-03-11 13:47:47 UTC
~ppc64 done
Comment 4 Jeroen Roovers (RETIRED) gentoo-dev 2013-02-08 14:20:40 UTC
Index: facter-1.6.16.ebuild
===================================================================
RCS file: /var/cvsroot/gentoo-x86/dev-ruby/facter/facter-1.6.16.ebuild,v
retrieving revision 1.5
diff -u -B -r1.5 facter-1.6.16.ebuild
--- facter-1.6.16.ebuild        5 Jan 2013 17:34:43 -0000       1.5
+++ facter-1.6.16.ebuild        8 Feb 2013 14:19:39 -0000
@@ -17,12 +17,12 @@
 
 LICENSE="Apache-2.0"
 SLOT="0"
-IUSE=""
-KEYWORDS="amd64 ppc ~ppc64 sparc x86"
+IUSE="+dmidecode"
+KEYWORDS="amd64 ~hppa ppc ~ppc64 sparc x86"
 
 CDEPEND="
        >=sys-apps/net-tools-1.60_p20120127084908[old-output]
-       sys-apps/dmidecode
+       dmidecode? ( sys-apps/dmidecode )
        sys-apps/lsb-release
        sys-apps/pciutils"
 
Index: metadata.xml
===================================================================
RCS file: /var/cvsroot/gentoo-x86/dev-ruby/facter/metadata.xml,v
retrieving revision 1.6
diff -u -B -r1.6 metadata.xml
--- metadata.xml        3 Feb 2013 13:26:17 -0000       1.6
+++ metadata.xml        8 Feb 2013 14:19:39 -0000
@@ -6,4 +6,7 @@
 </maintainer>
 <herd>sysadmin</herd>
 <herd>ruby</herd>
+<use>
+<flag name='dmidecode'>Use sys-apps/dmidecode to determine system properties</flag>
+</use>
 </pkgmetadata>


RSVP.
Comment 5 Jeroen Roovers (RETIRED) gentoo-dev 2013-02-08 14:22:31 UTC
Looking through the profiles/ directory, I see an obsolete use.mask entry for HPPA:

# 2006/04/26 Saleem Abdulrasool <compnerd@gentoo.org>
# sys-apps/dmidecode: masking with vapier's blessings
dmi

Maybe it should be IUSE=dmi, then.
Comment 6 Jeroen Roovers (RETIRED) gentoo-dev 2013-02-08 14:25:38 UTC
Marked ~hppa with the noted changes.