Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 392893 - net-fs/samba: gcc-related code in pkg_setup
Summary: net-fs/samba: gcc-related code in pkg_setup
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's SAMBA Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-02 09:05 UTC by Fabio Erculiani (RETIRED)
Modified: 2012-01-31 07:54 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fabio Erculiani (RETIRED) gentoo-dev 2011-12-02 09:05:30 UTC
The following snippet should be moved away from pkg_setup (pkg_pretend + MERGE_TYPE or src_prepare or pkg_setup + MERGE_TYPE [don't know if this is allowed, but I guess so]):

if use winbind &&
	[[ $(tc-getCC)$ == *gcc* ]] &&
	[[ $(gcc-major-version)$(gcc-minor-version) -lt 43 ]]
then
	eerror "It is a known issue that ${P} will not build with "
	eerror "winbind use flag enabled when using gcc < 4.3 ."
	eerror "Please use at least the latest stable gcc version."
	die "Using sys-devel/gcc < 4.3 with winbind use flag."
fi

For the following reasons:
- on binpkgs systems there is no need to bug GCC (pkg_setup is shared between bin and src)
- on binpkgs systems gcc could have been removed (there are split ebuilds in sabayon overlay allowing this)


Reproducible: Always
Comment 1 Víctor Ostorga (RETIRED) gentoo-dev 2011-12-14 14:14:11 UTC
What is it your proposed fix?
Comment 2 Fabio Erculiani (RETIRED) gentoo-dev 2011-12-14 14:35:04 UTC
Move it to pkg_pretend.
Comment 3 Tomáš Chvátal (RETIRED) gentoo-dev 2012-01-31 07:54:12 UTC
I hit the issue on one of my servers with old gcc, i took the liberty of fixing this in cvs. Hope you won't mind.