Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 392599 - mail-client/mail-notification-5.4-r4 shouldn't use <span> tags
Summary: mail-client/mail-notification-5.4-r4 shouldn't use <span> tags
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Hans de Graaff
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-30 12:54 UTC by Ian Abbott
Modified: 2011-12-04 11:46 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Proposed fix uses '<b>' tag instead of '<span weight="bold"> (mail-notification-5.4-fix-markup.patch,1.53 KB, patch)
2011-11-30 14:47 UTC, Ian Abbott
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Abbott 2011-11-30 12:54:14 UTC
The notifications emitted by the mail-notification applet look really ugly in the Gnome 3.2 desktop due to the use of unsupported '<span>' tags.

Quoting https://bugs.launchpad.net/mail-notification/+bug/799852 :

The "Desktop Notification Specification" (http://www.galago-project.org/specs/notification/0.9/x161.html) allows only a very limited set of markup. mail-notification emits '<span weight="bold">' tags (which can be expressed by the supported <b> ones) which makes the generated messages difficultly to read in some notification daemon implementions.

Reproducible: Always




The launchpad bug page has a trivial patch to fix the issue which I'll try out and attach here if it works.
Comment 1 Ian Abbott 2011-11-30 13:09:57 UTC
The patch applied okay, but because it modified a .gob file it caused the build to fail with this error:

building server of D-Bus interface org.gnome.MailNotification
ERROR: One or more .gob source files were modified but gob2 was not found. Please install gob2 >= 2.0.16 and run configure again.


I'll install dev-util/gob temporarily and extend the patch with the changes to the regenerated files to avoid the extra build dependency on dev-util/gob:2.
Comment 2 Ian Abbott 2011-11-30 14:47:22 UTC
Created attachment 294323 [details, diff]
Proposed fix uses '<b>' tag instead of '<span weight="bold">

This is based on Enrico Scholz's patch in Launchpad:

https://bugs.launchpad.net/mail-notification/+bug/799852
https://bugs.launchpad.net/mail-notification/+bug/799852/+attachment/2179334/+files/popup-markup.patch

but this patch patches the .c file generated from the .gob file as well (and touches the .gob.stamp file) instead of running 'gob' to do it.

With this patch the notifications look fine instead of a garbled mess.
Comment 3 Hans de Graaff gentoo-dev Security 2011-12-04 11:46:36 UTC
Thanks for doing all the work here :-)

Fixed in mail-notification-5.4-r5.