Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 392099 - media-libs/freetype does unseemly things with autotools-utils.eclass (was for a while: move remove_libtool_files from autotools-utils.eclass into eutils.eclass)
Summary: media-libs/freetype does unseemly things with autotools-utils.eclass (was for...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal major (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 392063
  Show dependency tree
 
Reported: 2011-11-27 10:15 UTC by Michał Górny
Modified: 2012-03-10 15:56 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2011-11-27 10:15:11 UTC
Mixing use of autotools-utils.eclass with regular phase functions and/or random econf/emake calls is unsupported and it never was. And in a near future, it will cause fatal errors during the build process.

Please fix it by using correct autotools-utils phase functions as pointed out in the example on top of the eclass and/or its manpage. If you have any trouble, feel free to ping us and we'll help you fix it. Thanks.
Comment 1 Petr Zima 2011-12-01 16:27:18 UTC
I have an install failure due to this issue. The eqawarn function (called from remove_libtool_files) returns nonzero status (since I do not use QA logs), causing the whole src_install to fail. Maybe it is specific to paludis. Do you need more info?
Comment 2 Ryan Hill (RETIRED) gentoo-dev 2011-12-02 04:00:22 UTC
The only thing we use is remove_libtool_files().  I really don't feel like using autotools-utils here, so it'd be nice if it were split out into eutils or something so we don't have to start duplicating code.
Comment 3 Peter Volkov (RETIRED) gentoo-dev 2011-12-17 02:09:13 UTC
@base-system: Can we move remove_libtool_files from autotools-utils.eclass into eutils.eclass?
Comment 4 SpanKY gentoo-dev 2011-12-20 23:59:27 UTC
i'm not entirely convinced of its useful/correct-ness.  i don't think there should be a "remove all" option, and generally i think package maintainers should be understanding the libraries they install and what is appropriate for removal.

although you could say that even if people understand what's going on, they'd still want to use the func out of laziness ...
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2011-12-21 08:09:24 UTC
(In reply to comment #4)
> i'm not entirely convinced of its useful/correct-ness.  i don't think there
> should be a "remove all" option, and generally i think package maintainers
> should be understanding the libraries they install and what is appropriate for
> removal.

I agree; if we move it, there should be only one mode of operation.

> although you could say that even if people understand what's going on, they'd
> still want to use the func out of laziness ...

It's still better than people do now. Because now, people usually copy random pieces of code like 'use static-libs ||' and randomly install useless .la files anyway.
Comment 6 Ryan Hill (RETIRED) gentoo-dev 2012-01-08 05:13:18 UTC
(In reply to comment #4)
> although you could say that even if people understand what's going on, they'd
> still want to use the func out of laziness ...

Or to avoid code duplication and not have to update every one of their ebuilds when policies change.
Comment 7 Ryan Hill (RETIRED) gentoo-dev 2012-03-10 01:17:05 UTC
Well, I need to bump freetype and don't feel like inheriting an eclass that I have no control over that changes every week.  So I'm just ripping any static lib logic out of the ebuild.  Patches welcome.

Fixed in 2.4.9.  This version will be stable in a few days, and I'll drop the offending versions.
Comment 8 Nikos Chantziaras 2012-03-10 15:56:56 UTC
The change gives rise to bug 407663. How do we resolve the blocker?