Bugzilla Bug 39208

I emerged app-text/barcode-0.98 without errors, then attempted to emerge the
app-text/kbarcode-1.7.2 front-end and received the following compile error:

/X11R6/include   -DQT_THREAD_SUPPORT  -D_REENTRANT  -Wnon-virtual-dtor
-Wno-long-long -Wundef -Wall -pedantic -W -Wpointer-arith -Wwrite-strings -ansi
-D_XOPEN_SOURCE=500 -D_BSD_SOURCE -Wcast-align -Wconversion -Wchar-subscripts
-DNDEBUG -DNO_DEBUG -O2 -O2 -mcpu=i686 -pipe -Wformat-security
-Wmissing-format-attribute -fno-exceptions -fno-check-new -fno-common  -c -o
sqltables.o `test -f 'sqltables.cpp' || echo './'`sqltables.cpp
smalldialogs.cpp:68: error: default argument given for parameter 4 of `
   DSSmallDialogs::AddItemsDialog::AddItemsDialog(const QString&, const
   QString&, int, QWidget*, const char*)'
smalldialogs.h:47: error: after previous specification in `
   DSSmallDialogs::AddItemsDialog::AddItemsDialog(const QString&, const
   QString&, int, QWidget*, const char*)'
smalldialogs.cpp:68: error: default argument given for parameter 5 of `
   DSSmallDialogs::AddItemsDialog::AddItemsDialog(const QString&, const
   QString&, int, QWidget*, const char*)'
smalldialogs.h:47: error: after previous specification in `
   DSSmallDialogs::AddItemsDialog::AddItemsDialog(const QString&, const
   QString&, int, QWidget*, const char*)'
smalldialogs.cpp: In member function `const QString&
   DSSmallDialogs::AddItemsDialog::articleNo() const':
smalldialogs.cpp:143: warning: returning reference to temporary
smalldialogs.cpp: In member function `const QString&
   DSSmallDialogs::AddItemsDialog::groupName() const':
smalldialogs.cpp:148: warning: returning reference to temporary
make[2]: *** [smalldialogs.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory
`/var/tmp/portage/kbarcode-1.7.2/work/kbarcode-1.7.2/kbarcode'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory
`/var/tmp/portage/kbarcode-1.7.2/work/kbarcode-1.7.2'
make: *** [all] Error 2

!!! ERROR: app-text/kbarcode-1.7.2 failed.
!!! Function kde_src_compile, Line 127, Exitcode 2
!!! died running emake, kde_src_compile:make


Reproducible: Always
Steps to Reproduce:
1. emerge barcode
2. emerge kbarcode

Actual Results:  
barcode compiles without error
kbarcode fails when compiling

Expected Results:  
compiled successfully

I installed KBarcode right before 1.7.2 came out and it compiled fine (1.7.0),
then I just tried to update to 1.7.2 and am getting the same error :(

emerge info:
Portage 2.0.50_pre19 (default-x86-1.4, gcc-3.3.2, glibc-2.3.3_pre20040117-r0,
2.6.0-gentoo)
=================================================================
System uname: 2.6.0-gentoo i686 Intel(R) Pentium(R) 4 CPU 2.26GHz
Gentoo Base System version 1.4.3.12
ccache version 2.3 [enabled]
Autoconf: sys-devel/autoconf-2.59
Automake: sys-devel/automake-1.7.8
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CFLAGS="-march=pentium4 -O3 -pipe -fomit-frame-pointer -fforce-addr
-funroll-loops -frerun-loop-opt -frerun-cse-after-loop -falign-functions=4"
CHOST="i686-pc-linux-gnu"
COMPILER="gcc3"
CONFIG_PROTECT="/etc /opt/resin/conf /opt/tomcat/conf /usr/X11R6/lib/X11/xkb
/usr/kde/2/share/config /usr/kde/3.1/share/config /usr/kde/3.2/share/config
/usr/kde/3/share/config /usr/share/config /usr/share/texmf/dvipdfm/config/
/usr/share/texmf/dvips/config/ /usr/share/texmf/tex/generic/config/
/usr/share/texmf/tex/platex/config/ /usr/share/texmf/xdvi/ /var/bind
/var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/env.d"
CXXFLAGS="-march=pentium4 -O3 -pipe -fomit-frame-pointer -fforce-addr
-funroll-loops -frerun-loop-opt -frerun-cse-after-loop -falign-functions=4"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs ccache sandbox"
GENTOO_MIRRORS="http://128.213.5.34/gentoo/ http://gentoo.noved.org/
ftp://gentoo.mirrors.pair.com ftp://ftp.uesb.edu/pub/mirrors/linux/gentoo
http://www.ibiblio.org/pub/Linux/distributions/gentoo"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.gentoo.org/gentoo-portage"
USE="X aalib accessiblity acl acpi alsa apache2 apm arts avi berkdb bonobo cdr
crypt cups curl dga directfb doc dvb dvd encode esd evo faad fbcon firebird
flac flash foomaticdb freetds gd gdbm gif gnome gnomedb gpm gstreamer gtk gtk2
gtkhtml guile imagemagick imap imlib informix innodb jack java jikes joystick
jpeg kde ladcca lcms ldap libg++ libgda libwww lirc mad mcal mikmod mmx motif
mozcalendar mozilla mozp3p mozsvg mozxmlterm mpeg mysql nas ncurses netcdf nls
oggvorbis opengl oss pam pdflib perl plotutils png pnp postgres python qt
quicktime readline ruby samba sasl scanner sdl slang spell sqlite sse ssl svga
tcltk tcpd tetex tiff truetype unicode usb wmf wxwindows x86 xine xinerama xml
xml2 xmms xosd xv xvid zlib"

This Bug was discussed in the KBarcode-Forums already. It is a bug in KBarcode,
there is invalid code in smalldialogs.cpp.

I'll try to provide a patch.

I have now commited the changes to CVS, should be on the mirrors soon, please
try.