Bugzilla Bug 39177

gtkpod-0.72 doesn't build on my (admittedly old) gentoo-1.2 box. Here's a patch
to fix this.

gcc -DHAVE_CONFIG_H -I. -I. -I.. -DPACKAGE_DATA_DIR=\""/usr/share"\"
-DPACKAGE_LOCALE_DIR=\""/usr/share/locale"\"    -pthread -I/usr/include/gtk-2.0
-I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/pango-1.0
-I/usr/X11R6/include -I/usr/include/freetype2 -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include   -mcpu=i686 -O3 -pipe -Wall -c `test -f
'mp4file.c' || echo './'`mp4file.c
source='normalize.c' object='normalize.o' libtool=no \
depfile='.deps/normalize.Po' tmpdepfile='.deps/normalize.TPo' \
depmode=gcc /bin/sh ../depcomp \
gcc -DHAVE_CONFIG_H -I. -I. -I.. -DPACKAGE_DATA_DIR=\""/usr/share"\"
-DPACKAGE_LOCALE_DIR=\""/usr/share/locale"\"    -pthread -I/usr/include/gtk-2.0
-I/usr/lib/gtk-2.0/include -I/usr/include/atk-1.0 -I/usr/include/pango-1.0
-I/usr/X11R6/include -I/usr/include/freetype2 -I/usr/include/glib-2.0
-I/usr/lib/glib-2.0/include   -mcpu=i686 -O3 -pipe -Wall -c `test -f
'normalize.c' || echo './'`normalize.c
mp3file.c: In function `file_get_mp3_info':
mp3file.c:1373: parse error before `*'
mp3file.c:1374: parse error before `mp3info'
mp3file.c:1377: parse error before `->'
mp3file.c:1378: parse error before `mp3info'
mp3file.c:1379: warning: control reaches end of non-void function
mp3file.c: At top level:
mp3file.c:1393: warning: type defaults to `int' in declaration of `free_track'
mp3file.c:1393: warning: parameter names (without types) in function
declaration
mp3file.c:1393: conflicting types for `free_track'
song.h:114: previous declaration of `free_track'
mp3file.c:1393: warning: data definition has no type or storage class
mp3file.c:1394: warning: type defaults to `int' in declaration of `track'
mp3file.c:1394: warning: initialization makes integer from pointer without a
cast
mp3file.c:1394: warning: data definition has no type or storage class
mp3file.c:1395: parse error before `}'
make[2]: *** [mp3file.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[2]: Leaving directory `/var/tmp/portage/gtkpod-0.72/work/gtkpod-0.72/src'
make[1]: *** [all-recursive] Error 1
make[1]: Leaving directory `/var/tmp/portage/gtkpod-0.72/work/gtkpod-0.72'
make: *** [all] Error 2

!!! ERROR: app-pda/gtkpod-0.72 failed.
!!! Function src_compile, Line 37, Exitcode 2
!!! (no error message)

Reproducible: Always
Steps to Reproduce:
1.
2.
3.




Portage 2.0.50_pre19 (default-1.0, gcc-2.95.3, glibc-2.2.5-r9, 2.4.24)
==============================================================
===
System uname: 2.4.24 i686 Transmeta(tm) Crusoe(tm) Processor TM5800
Gentoo Base System version 1.4.3.12
distcc 2.12.1 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632)
[disabled]
Autoconf: sys-devel/autoconf-2.59
Automake: sys-devel/automake-1.7.8
ACCEPT_KEYWORDS="x86 ~x86"
AUTOCLEAN="yes"
CFLAGS="-mcpu=i686 -O3 -pipe"
CHOST="i686-pc-linux-gnu"
COMPILER=""
CONFIG_PROTECT="/etc /usr/X11R6/lib/X11/xkb /usr/kde/2/share/config
/usr/kde/3/share/config 
/usr/share/config /usr/share/texmf/dvipdfm/config/
/usr/share/texmf/dvips/config/ 
/usr/share/texmf/tex/generic/config/ /usr/share/texmf/tex/platex/config/
/usr/share/texmf/xdvi/ 
/var/qmail/control"
CONFIG_PROTECT_MASK="/etc/gconf /etc/env.d"
CXXFLAGS="-mcpu=i686 -O3 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="autoaddcvs ccache digest sandbox strict"
GENTOO_MIRRORS="http://gentoo.oregonstate.edu http://distro.ibiblio.
org/pub/Linux/distributions/gentoo"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.namerica.gentoo.org/gentoo-portage"
USE="X X509 aalib alsa apache2 apm avi berkdb bonobo cdr crypt cups curses dga
dvd emacs 
encode esd ethereal evo fbcon foomaticdb gdbm gif gnome-libs gpm gtk gtk2
gtkhtml guile imap 
imlib java jpeg lcms ldap libg++ libwww mmx motif mpeg mysql nas ncurses odbc
oggvorbis oss 
pam pcmcia pda pdflib perl pic plotutils png pnp python quicktime readline
samba sdl skey slang 
smooth snmp spell ssl stroke svga tcltk tcpd tetex tiff truetype trusted usb
vim-with-x x86 xml xml2 
xmms xv zlib"

Created an attachment (id=24300) [details]
patch to fix compilation with gcc-2.95

Created an attachment (id=24301) [details]
ebuild using above patch

ok, this is in... but if gtkpod adds more C99 stuff.. I dont know for how long
I'll keep patching to support older compilers... Btw, did you send this to the
gtkpod author?

OK, thanks. I wasn't sure whether to send this to the gtkpod author - I've seen
in the past that sometimes authors like to receive "official" patches from the
distribution. But I'll send this one ASAP.

I have submitted the patch to the gtkpod author and he has committed it to CVS.