Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 390901 - net-analyzer/wireshark: update fcaps() error message for recent kernel versions
Summary: net-analyzer/wireshark: update fcaps() error message for recent kernel versions
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Peter Volkov (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-18 09:05 UTC by Alexandre Rostovtsev (RETIRED)
Modified: 2011-12-12 06:45 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch with updated error message (wireshark-1.6.2.ebuild.patch,1.40 KB, patch)
2011-11-18 09:05 UTC, Alexandre Rostovtsev (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre Rostovtsev (RETIRED) gentoo-dev 2011-11-18 09:05:03 UTC
Created attachment 292969 [details, diff]
patch with updated error message

If setting file capabilities fails, the fcaps() function included in the wireshark ebuild prompts the user to enable SECURITY_FILE_CAPABILITIES in the kernel config. However, the SECURITY_FILE_CAPABILITIES config option was removed in 2.6.33_rc1 (it's now hardcoded to be enabled), and so for users running a more recent kernel versions, the error message is likely to result in confusion.

I have updated the fcaps() error message in gnome-base/gnome-keyring, and believe that the same modifications also ought to be made in the other copies of fcaps() in portage. A proposed patch for the wireshark ebuild is attached.
Comment 1 Alexandre Rostovtsev (RETIRED) gentoo-dev 2011-11-18 17:53:36 UTC
By the way, the reason for using uname -r instead of kernel_is from linux-info.eclass is that kernel_is checks for the build-time kernel version (i.e. the version of /usr/src/linux), while the error message needs to refer to the runtime kernel version at the time of pkg_postinst().
Comment 2 Peter Volkov (RETIRED) gentoo-dev 2011-12-12 06:45:17 UTC
Thank you Alexandre. I just updated warning and decided to avoid uname and other stuff. I think Gentoo users are smart enough to check kernel version and decide by themselves :)