Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 390287 - =media-sound/pulseaudio-1.1 has wrong path to machine-id, missing fallback code
Summary: =media-sound/pulseaudio-1.1 has wrong path to machine-id, missing fallback code
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Arun Raghavan (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-12 17:24 UTC by Samuli Suominen (RETIRED)
Modified: 2011-12-16 19:29 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Samuli Suominen (RETIRED) gentoo-dev 2011-11-12 17:24:58 UTC
configure.ac has

PA_MACHINE_ID="${localstatedir}/lib/dbus/machine-id"

but it should have

PA_MACHINE_ID="${sysconfdir}/machine-id"

since machine-id is in /etc instead of /var/lib/dbus since >=sys-apps/dbus-1.4.16-r2

in reality, upstream pulseaudio should have similar code to:

http://cgit.freedesktop.org/dbus/dbus/commit/dbus/dbus-sysdeps-unix.c?id=66e52541d5bdd4927a5c702963749760643313f4
Comment 1 Arun Raghavan (RETIRED) gentoo-dev 2011-11-14 08:19:51 UTC
Thanks for the report Samuli. I noticed that upstream doesn't actually mention putting machine-id in /etc/ in dbus (the commit you pointed to actually mentions that /etc/machine-id is set up by systemd and meant to be a fallback). Upstream Makefile.am even has this:

AM_CPPFLAGS = \
        -I$(top_builddir) \
        -I$(top_srcdir) \
        -DDBUS_COMPILATION \
        -DDBUS_MACHINE_UUID_FILE=\""$(localstatedir)/lib/dbus/machine-id"\" \
        -DDBUS_SYSTEM_CONFIG_FILE=\""$(configdir)/system.conf"\" \
        -DDBUS_SESSION_CONFIG_FILE=\""$(configdir)/session.conf"\" \
        $(NULL)

That said, I don't actually have /var/lib/dbus/machine-id (I do have /etc/machine-id not owned by any program). Any further clues as to how this is supposed to work?

I have a patch to PA to fallback to /etc/machine-id done. Will push once we clarify things.
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2011-11-14 16:29:33 UTC
I'm not sure how our systemd maintainers will handle this in systemd package itself, use the machine-id generated by dbus-uuidgen or overwrite it in /etc:

Bug 370451, Comment #0

But I don't think it should be relavent to committing the patch to pulseaudio or not, it should support the fallback in any case.

Please (re?)read comments in http://bugzilla.gnome.org/show_bug.cgi?id=663928 before pushing
Comment 3 Arun Raghavan (RETIRED) gentoo-dev 2011-11-14 16:58:31 UTC
(In reply to comment #2)
> I'm not sure how our systemd maintainers will handle this in systemd package
> itself, use the machine-id generated by dbus-uuidgen or overwrite it in /etc:
> 
> Bug 370451, Comment #0
> 
> But I don't think it should be relavent to committing the patch to pulseaudio
> or not, it should support the fallback in any case.

It is relevant because I have 3 conflicting data points:

1. You say that /etc/machine-id is the only currently relevant place to look (whether you're running dbus or systemd)

2. The dbus sources seem to show /var/lib/... as still the default
s.
3. I don't have a /var/lib/... on my local question

Which is why I'm wondering what I'm missing in all thi
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2011-11-14 17:18:35 UTC
all i'm asking is matching behavior from pulseaudio with dbus (and glib) to first look in /var/lib/dbus/machine-id, and then fallback to /etc/machine-id if not found
Comment 5 Arun Raghavan (RETIRED) gentoo-dev 2011-11-15 07:30:30 UTC
Pushed upstream. Is this a systemd-only issue, or a general one? That is, does it merit causing yet another recompile with a revbump?
Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2011-11-15 15:02:42 UTC
general one, and it's screwing kde startup over (causes it to stall) so revbump is necessary
Comment 7 Samuli Suominen (RETIRED) gentoo-dev 2011-11-28 18:32:26 UTC
any ETA on this?  there really isn't usable pulse in ~arch now...
Comment 8 Arun Raghavan (RETIRED) gentoo-dev 2011-11-29 04:05:32 UTC
Sorry, this dropped off my radar. Should fix this up today (just resolving what other fixes from master need to be cherry-picked).
Comment 9 Arun Raghavan (RETIRED) gentoo-dev 2011-12-13 04:35:07 UTC
Finally fixed with 1.1-r1. Apologies for the delay.
Comment 10 jon R-B 2011-12-16 17:22:04 UTC
this has broken skype for some strange reason.
might need to bump the 32bit emul package to resolve that
Comment 11 Samuli Suominen (RETIRED) gentoo-dev 2011-12-16 17:36:24 UTC
Yes, true -- the emul packages need to be rebuilt to get refreshed dbus and pulseaudio.
Comment 12 Samuli Suominen (RETIRED) gentoo-dev 2011-12-16 17:37:20 UTC
(In reply to comment #11)
> Yes, true -- the emul packages need to be rebuilt to get refreshed dbus and
> pulseaudio.

... but this is not the bug to handle that.  file a new bug so it can be assigned to the amd64 team for rebuilding them with latest dbus/pulseaudio.  you can mention this bug as a reference.
Comment 13 jon R-B 2011-12-16 19:29:40 UTC
will do