Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 388209 - Please review Prefix changes for sys-apps/less-444
Summary: Please review Prefix changes for sys-apps/less-444
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-23 11:38 UTC by Fabian Groffen
Modified: 2012-06-04 19:08 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
less-444-regcmp-libs.patch (less-444-regcmp-libs.patch,924 bytes, patch)
2011-10-23 11:38 UTC, Fabian Groffen
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Fabian Groffen gentoo-dev 2011-10-23 11:38:45 UTC
Created attachment 290621 [details, diff]
less-444-regcmp-libs.patch

We apply a patch to less to avoid its configure linking needlessly against libgen and libintl.  Instead of this patch which requires an autoreconf, we can also export two ac_cv_* variables to achieve the same effect, conditionally for Solaris:

    # Solaris includes regcmp in it's libc, but configure wrongly checks -lgen
    # and -lintl, which obviously both "provide" regcmp.
    if [[ ${CHOST} == *-solaris* ]] ; then
        export ac_cv_lib_gen_regcmp=no
        export ac_cv_lib_intl_regcmp=no
    fi

regcmp-libs patch is attached to this comment.


@@ -2,7 +2,7 @@
 # Distributed under the terms of the GNU General Public License v2
 # $Header: /var/cvsroot/gentoo-x86/sys-apps/less/less-444.ebuild,v 1.1 2011/06/09 18:37:30 vapier Exp $
 
-inherit eutils
+inherit eutils autotools
 
 DESCRIPTION="Excellent text file viewer"
 HOMEPAGE="http://www.greenwoodsoftware.com/less/"
@@ -21,6 +21,8 @@
        cd "${S}"
        cp "${DISTDIR}"/code2color "${S}"/
        epatch "${FILESDIR}"/code2color.patch
+       epatch "${FILESDIR}"/${P}-regcmp-libs.patch
+       eautoreconf
 }
 
 yesno() { use $1 && echo yes || echo no ; }


Please review and tell your preference for either the patch as sent upstream, or the workaround which doesn't need eautoreconf.
Comment 1 SpanKY gentoo-dev 2011-10-25 06:08:49 UTC
configure patch is fine.  upstream tends to be semi-responsive, so it should def be sent there as well.
Comment 2 Fabian Groffen gentoo-dev 2011-10-25 06:53:01 UTC
I already did.  Got no response yet, but will update the patch header as soon as I get response.
Comment 3 Fabian Groffen gentoo-dev 2012-06-04 19:08:19 UTC
patch is no longer necessary/upstreamed with 445