Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 387959 - USE="colord packagekit" unmasking, and x11-misc/colord and app-admin/packagekit-base keywording
Summary: USE="colord packagekit" unmasking, and x11-misc/colord and app-admin/packagek...
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Keywording and Stabilization (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords: KEYWORDREQ
Depends on: 390089
Blocks: gnome3.2 390345 gnome3.6 gnome-3.8
  Show dependency tree
 
Reported: 2011-10-21 05:07 UTC by Alexandre Rostovtsev (RETIRED)
Modified: 2014-09-07 14:06 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
files/colord-0.1.14-libusb.patch (colord-0.1.14-libusb.patch,1.20 KB, text/plain)
2011-11-18 12:39 UTC, Naohiro Aota
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre Rostovtsev (RETIRED) gentoo-dev 2011-10-21 05:07:33 UTC
Please ~re-keyword gtk+-3.2.1 for USE="colord packagekit".

For colord on arm, x86-fbsd, x86-freebsd, amd64-linux, x86-linux, x86-solaris:
>=x11-misc/colord-0.1.13 will be a required dependency for several core gnome-3.2 packages. Therefore, if you can't keyword x11-misc/colord, please say so; perhaps the gnome team will be able to patch some things to make it optional.

For colord on other arches:
feel free to package.use.mask it if it doesn't work.

For packagekit:
if app-admin/packagekit-base doesn't work, please use.mask (not package.use.mask) the packagekit flag. At least 6 packages with "packagekit? ( app-admin/packagekit-base )" in RDEPEND will be arriving in portage with gnome-3.2.
Comment 1 Jeroen Roovers (RETIRED) gentoo-dev 2011-10-25 15:11:26 UTC
Marked ~hppa.
Comment 2 Alexandre Rostovtsev (RETIRED) gentoo-dev 2011-10-28 05:20:21 UTC
Update:

On advice from other gnome team members, I have use.masked "colord" on alpha, arm, ia64, ppc, ppc64, and sparc and "packagekit" on alpha, ia64, ppc, ppc64, and sparc, restored all keywords to gtk+-3.2.1, and unmasked gtk+-3.2.1.

Also, colord in gnome-3.2 will now be optional (controlled by USE=colord, which will be in make.defaults for the gnome target).

alpha, arm, ia64, ppc, ppc64, and sparc: please test x11-misc/colord and app-admin/packagekit-base, and if they work, keyword them and remove the flags from use.mask.

Unstable and dev arches (mips, sh, x86-fbsd, x86-freebsd, x86-interix, amd64-linux, x86-linux, ppc-macos, x86-macos, sparc-solaris, sparc64-solaris, x64-solaris, x86-solaris): gtk+[colord,packagekit] has unsatisfied dependencies on your arches, but since repoman doesn't complain, I am leaving it up to you to deal with the situation in whatever manner is appropriate :)
Comment 3 Steve Herber 2011-11-02 02:06:17 UTC
colord has a new version to 0.1.14
Comment 4 Steve Herber 2011-11-02 05:44:32 UTC
(In reply to comment #3)
> colord has a new version to 0.1.14

Version 0.1.5
~~~~~~~~~~~~~
Released: 2011-11-01
Comment 5 Markus Meier gentoo-dev 2011-11-06 17:24:47 UTC
~arm keyword added to colord and use.mask removed.
Comment 6 Naohiro Aota gentoo-dev 2011-11-18 12:39:11 UTC
Created attachment 292987 [details]
files/colord-0.1.14-libusb.patch

I was able to build colord on Gentoo/FreeBSD-8.2 with this patch and
some fix to ebuild. Ebuild fix is to add USB_CFLAGS and USB_LIBS to
econf argument to workaround pkg-config libusb-1.0 check. (FreeBSD
system package >=sys-freebsd/freebsd-lib-8.0[usb] is compatible with
libusb, so we don't need it on FreeBSD)

and this attached patch replace "#include <libusb-1.0/libusb.h>" with
"#include <libusb.h>" since FreeBSD libusb.h is placed at
/usr/include/libusb.h. OTOH, on Linux, it should be compiled with
"-I/usr/include/libusb-1.0" (= `pkg-config --cflags libusb-1.0`), so
this change may work both on Linux and FreeBSD. If you are interested,
please test this patch on Linux.

Anyway, I'll send this patch to upstream.
Comment 7 Alexandre Rostovtsev (RETIRED) gentoo-dev 2011-11-25 18:24:57 UTC
(In reply to comment #6)

I have added freebsd dependencies, a fix for the <libusb.h> issue, and USB_CFLAGS/USB_LIBS to colord-0.1.14-r1. Please test and keyword it on freebsd if it works.

>*colord-0.1.14-r1 (25 Nov 2011)
> 
>  25 Nov 2011; Alexandre Rostovtsev <tetromino@gentoo.org>
>  -colord-0.1.12.ebuild, -colord-0.1.13.ebuild, +colord-0.1.14-r1.ebuild,
>  +files/colord-0.1.14-sql-injections.patch,
>  +files/colord-0.1.14-sql-injections-2.patch:
>  Add patches to fix SQL injections (bug #391879, thanks to Agostino Sarubbo for
>  reporting). Allow building against freebsd's libusb (bug #387959, thanks to
>  Naohiro Aota). Drop old versions.
Comment 8 Alexandre Rostovtsev (RETIRED) gentoo-dev 2011-11-27 07:22:41 UTC
Note: >=x11-misc/colord-0.1.15 has a new, optional dependency on dev-libs/libgusb (controlled by the gusb USE flag); see bug #392057

@bsd:

According to Naohiro Aota's testing, libgusb is unlikely to work on non-Linux architectures, so if/when you keyword colord, you will probably want to package.use.mask colord[gusb].
Comment 9 Fabian Groffen gentoo-dev 2011-11-30 18:31:50 UTC
Hmmm, this package is unlikely to be useful for prefix, is it?
Comment 10 Alexandre Rostovtsev (RETIRED) gentoo-dev 2011-12-02 00:20:04 UTC
(In reply to comment #9)
> Hmmm, this package is unlikely to be useful for prefix, is it?

Colord will be useful for prefix if prefix supports cups or sane, or using libusb to access local USB devices such as colorimeters.

Packagekit is likely to be about as useful for prefix as it is for ordinary gentoo setups (i.e. it holds great promise for the future, but at the moment is limited, very slow, and somewhat buggy).
Comment 11 Fabian Groffen gentoo-dev 2011-12-02 07:26:42 UTC
Prefix users often don't have root-powers.  Sounds as if this thing interfaces with the system in a way that needs root, or doesn't it?
Comment 12 Alexandre Rostovtsev (RETIRED) gentoo-dev 2011-12-02 18:24:34 UTC
(In reply to comment #11)
> Prefix users often don't have root-powers.  Sounds as if this thing interfaces
> with the system in a way that needs root, or doesn't it?

I believe that colord does not need root privileges. It does not run as root even on normal Gentoo setups. The only thing it strictly requires is the ability to be launched as a dbus system service.

Note that the current colord ebuild creates a new user and group to run as, passes "--with-daemon-user=colord" to configure, installs certain directories as owned by colord:colord, and uses at_console dbus policy. I am guessing that for prefix installations without root access, these things may have to be appropriately adjusted.
Comment 13 Naohiro Aota gentoo-dev 2011-12-06 13:57:07 UTC
(In reply to comment #7)
> I have added freebsd dependencies, a fix for the <libusb.h> issue, and
> USB_CFLAGS/USB_LIBS to colord-0.1.14-r1. Please test and keyword it on freebsd
> if it works.

Unfortunately, it failed to build on FreeBSD. I've modified the ebuild
to "export USB_CFLAGS" and "export USB_LIBS" and it built well.
Comment 14 Alexandre Rostovtsev (RETIRED) gentoo-dev 2011-12-06 17:52:02 UTC
(In reply to comment #13)
> Unfortunately, it failed to build on FreeBSD. I've modified the ebuild
> to "export USB_CFLAGS" and "export USB_LIBS" and it built well.

Thanks, should be fixed now.
Comment 15 Naohiro Aota gentoo-dev 2011-12-07 14:01:34 UTC
Marked ~x86-fbsd.
Comment 16 Brent Baude (RETIRED) gentoo-dev 2012-03-06 22:31:59 UTC
~ppc done
Comment 17 Brent Baude (RETIRED) gentoo-dev 2012-03-08 23:41:30 UTC
~ppc64 done
Comment 18 Matt Turner gentoo-dev 2012-05-09 15:21:47 UTC
Added ~mips.
Comment 19 Matt Turner gentoo-dev 2012-05-27 23:27:36 UTC
Added ~alpha
Comment 20 Michael Palimaka (kensington) gentoo-dev 2012-12-10 17:46:28 UTC
Repoman is complaining after some keywording done here:

(In reply to comment #16)
> ~ppc done
app-admin/packagekit-base/packagekit-base-0.7.4.ebuild: RDEPEND: ~ppc(default/linux/powerpc/ppc32/10.0) ['>=sys-apps/entropy-1.0_rc27']

(In reply to comment #17)
> ~ppc64 done
app-admin/packagekit-base/packagekit-base-0.6.22.ebuild: RDEPEND: ~ppc64(default/linux/powerpc/ppc64/10.0/64bit-userland) ['>=sys-apps/entropy-1.0_rc27']
Comment 21 Agostino Sarubbo gentoo-dev 2012-12-19 20:33:40 UTC
ppc/ppc64 done
Comment 22 Agostino Sarubbo gentoo-dev 2012-12-31 18:25:06 UTC
ia64 done
Comment 23 Fabio Erculiani (RETIRED) gentoo-dev 2013-03-14 18:12:15 UTC
Please don't touch entropy ebuilds without contacting me first!
Anything you touch in there will go away next time I merge the ebuilds from the "sabayon" overlay.
Please see my pkg policy: http://dev.gentoo.org/~lxnay/

Also, who tested entropy on ia64 and ppc?
Comment 24 Pacho Ramos gentoo-dev 2013-08-21 10:24:04 UTC
arch teams, ping!
Comment 25 Pacho Ramos gentoo-dev 2013-10-03 17:50:51 UTC
ping!
Comment 26 Pacho Ramos gentoo-dev 2014-09-07 14:06:44 UTC
I guess remaining will pass