Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 387949 - [patch] app-misc/mc-4.8.0: emerge fails with compile error
Summary: [patch] app-misc/mc-4.8.0: emerge fails with compile error
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Sergei Trofimovich (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-21 02:32 UTC by Nikos Chantziaras
Modified: 2011-10-21 11:12 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
mc-4.8.0-build-fix.patch (mc-4.8.0-build-fix.patch,484 bytes, patch)
2011-10-21 02:32 UTC, Nikos Chantziaras
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikos Chantziaras 2011-10-21 02:32:12 UTC
mc-4.8.0 fails to build with:

  main.c: In function 'main':
  main.c:384:44: error: expected expression before ';' token
  main.c:385:29: error: expected expression before ';' token

The return values of bindtextdomain() and textdomain() can't be casted to void. The attached patch is trivial; simply don't cast. (The cast is just there to avoid compiler warnings about unused function returns and is safe to remove.)

Reproducible: Always
Comment 1 Nikos Chantziaras 2011-10-21 02:32:52 UTC
Created attachment 290403 [details, diff]
mc-4.8.0-build-fix.patch
Comment 2 Duncan 2011-10-21 09:54:12 UTC
mc-4.8.0-build-fix.patch dropped in /etc/portage/patches/app-misc/mc-4.8.0

Works here. =:^)

(Note that I have the following in /etc/portage/bashrc, in case the package doesn't call epatch_user on its own.  It has worked for every package I've tried patching since I killed the old catmur bashrc version in favor of this, but I guess it wouldn't work on old EAPI=0 packages. =:^(  )

post_src_prepare () {
        epatch_user
}
Comment 3 Sergei Trofimovich (RETIRED) gentoo-dev 2011-10-21 11:12:25 UTC
I've picked similar one from upstream. Pushed as:

>  21 Oct 2011; Sergei Trofimovich <slyfox@gentoo.org> mc-4.8.0.ebuild,
>  +files/mc-4.8.0-fix-nls.patch:
>  Fixed build failure in USE=-nls case by Nikos Chantziaras (bug #387949)

Thanks for the patch, Nikos!