mc-4.8.0 fails to build with: main.c: In function 'main': main.c:384:44: error: expected expression before ';' token main.c:385:29: error: expected expression before ';' token The return values of bindtextdomain() and textdomain() can't be casted to void. The attached patch is trivial; simply don't cast. (The cast is just there to avoid compiler warnings about unused function returns and is safe to remove.) Reproducible: Always
Created attachment 290403 [details, diff] mc-4.8.0-build-fix.patch
mc-4.8.0-build-fix.patch dropped in /etc/portage/patches/app-misc/mc-4.8.0 Works here. =:^) (Note that I have the following in /etc/portage/bashrc, in case the package doesn't call epatch_user on its own. It has worked for every package I've tried patching since I killed the old catmur bashrc version in favor of this, but I guess it wouldn't work on old EAPI=0 packages. =:^( ) post_src_prepare () { epatch_user }
I've picked similar one from upstream. Pushed as: > 21 Oct 2011; Sergei Trofimovich <slyfox@gentoo.org> mc-4.8.0.ebuild, > +files/mc-4.8.0-fix-nls.patch: > Fixed build failure in USE=-nls case by Nikos Chantziaras (bug #387949) Thanks for the patch, Nikos!