Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 387641 - net-misc/curl-7.22.0 fails to build with >=gnutls-3
Summary: net-misc/curl-7.22.0 fails to build with >=gnutls-3
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Christoph Mende (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-19 07:42 UTC by Tim Harder
Modified: 2011-12-01 19:25 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fix build with >=gnutls-3 (curl-7.22.0-gnutls3.patch,753 bytes, patch)
2011-10-19 07:42 UTC, Tim Harder
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Harder gentoo-dev 2011-10-19 07:42:31 UTC
Created attachment 290225 [details, diff]
Fix build with >=gnutls-3

The default lowat level for =gnutls-2.12* is set to zero to avoid unnecessary system calls and the gnutls_transport_set_lowat function has been totally removed in >=gnutls-3.

Therefore, the function shouldn't be used except for versions that require it, <gnutls-2.12.0.

The attached patch fixes the issue.
Comment 1 Tim Harder gentoo-dev 2011-10-19 07:46:03 UTC
To be clear, in this case calling gnutls_transport_set_lowat for =gnutls-2.12* is useless since the default value is already set to 0.
Comment 2 Tim Harder gentoo-dev 2011-10-19 08:10:28 UTC
I just pushed the patch upstream as well.
Comment 3 Tim Harder gentoo-dev 2011-10-20 01:28:07 UTC
(In reply to comment #2)
> I just pushed the patch upstream as well.

This has now been pulled into upstream master.
Comment 4 Christoph Mende (RETIRED) gentoo-dev 2011-10-20 14:39:12 UTC
Thanks for your work. Given that gnutls-3 is still masked and curl releases are fairly often, I'll wait for a release that includes the patch.
Comment 5 SpanKY gentoo-dev 2011-12-01 18:29:58 UTC
looks like your change was rewritten upstream :).  see commit f5bb37018647f6088398ca127235ce776eec9bbe.

at any rate, does this need to be added to current ebuilds ?  looks like the 7.23.1 release includes the fix.
Comment 6 Tim Harder gentoo-dev 2011-12-01 19:25:03 UTC
(In reply to comment #5)
> looks like your change was rewritten upstream :).  see commit
> f5bb37018647f6088398ca127235ce776eec9bbe.

Hah, yeah. I missed that issue since I don't build anything on Windows.
 
> at any rate, does this need to be added to current ebuilds ?  looks like the
> 7.23.1 release includes the fix.

Nope, everything should be fixed in current releases.