Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 387353 - Please document gtk use flag in sys-block/gparted
Summary: Please document gtk use flag in sys-block/gparted
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Gilles Dartiguelongue (RETIRED)
URL:
Whiteboard:
Keywords: InVCS
: 393089 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-10-17 02:22 UTC by Samuel Bauer
Modified: 2011-12-05 22:04 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Samuel Bauer 2011-10-17 02:22:55 UTC 
The gtk use flag in gparted ebuild only adds a dependency for gksu.

This use flag is not really semantic:

1/ would be better to rename it gksu (understandable without any efforts)
2/ at least add an entry in metadata.xml describing the usage of this flag (understandable under condition to read the description of the flag)

For now the only way to understand the gtk use flag of gparted, is reading the ebuild.
Comment 1 Samuel Bauer 2011-10-18 12:02:18 UTC 
Even gtk flag to activate graphical su isn't meaningful, document the flag is better than nothing.

Thanks
Comment 2 Pacho Ramos gentoo-dev 2011-10-18 17:57:47 UTC 
        if use gtk; then
                sed -i "s:Exec=:Exec=gksu :" "${D}"/usr/share/applications/gparted.desktop
                echo "NotShowIn=KDE;" >> "${D}"/usr/share/applications/gparted.desktop
        else

I think this actions (like NotShowIn=KDE) would fit more on a "gnome" USE flag than a "gtk" one :-/
Comment 3 Gilles Dartiguelongue (RETIRED) gentoo-dev 2011-10-22 13:16:23 UTC 
+  22 Oct 2011; Gilles Dartiguelongue <eva@gentoo.org> metadata.xml:
+  Add flag description for gtk, bug #387353.
+
Thanks for reporting.
Comment 4 Samuel Bauer 2011-11-09 10:44:12 UTC 
USE="gtk" emerge gparted

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild  N     ] gnome-base/orbit-2.14.19-r1  USE="-debug -doc -test" 747 kB
[ebuild  N     ] gnome-base/gconf-2.32.4  USE="introspection ldap policykit -debug -doc" 1,296 kB
[ebuild  N     ] gnome-base/gnome-keyring-2.32.1-r1  USE="pam -debug -doc -test" 1,582 kB
[ebuild  N     ] gnome-base/libgnome-keyring-2.32.0  USE="-debug -doc -test" 403 kB
[ebuild  N     ] x11-libs/libgksu-2.0.12-r1  USE="nls -doc -static-libs" 467 kB
[ebuild  N     ] x11-libs/gksu-2.0.2  USE="-doc -gnome" 458 kB
[ebuild   R    ] sys-block/gparted-0.9.1  USE="dmraid fat gtk* mdadm ntfs -btrfs -hfs -jfs -kde -reiser4 -reiserfs -xfs" 0 kB

I difficulty find an explanation with

sys-block/gparted:gtk - Enable .desktop support for gtk+ based desktops.

There is clearly a kde flag, not a qt4 one
Why is it impossible to do the same distinction with gtk and gnome.
Comment 5 Gilles Dartiguelongue (RETIRED) gentoo-dev 2011-11-09 12:50:08 UTC 
Read this bug report, all revelant explanation are written within.
Comment 6 Gilles Dartiguelongue (RETIRED) gentoo-dev 2011-11-09 16:23:22 UTC 
Sorry, my last comment was refering to https://bugs.gentoo.org/show_bug.cgi?id=387779#c3 which you reported as well. This bug got closed for the same reason. I added a local USE flag documentation but the name and purpose is really the same.
Comment 7 Pacho Ramos gentoo-dev 2011-12-05 22:04:52 UTC 
*** Bug 393089 has been marked as a duplicate of this bug. ***