Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 386489 - media-libs/phonon-4.5.0 fails to compile after upgrade to >=pulseaudio-1.0
Summary: media-libs/phonon-4.5.0 fails to compile after upgrade to >=pulseaudio-1.0
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Library (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo KDE team
URL: http://lists.opensuse.org/archive/ope...
Whiteboard:
Keywords:
: 393457 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-10-09 04:33 UTC by hirakendu
Modified: 2011-12-09 13:21 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to make phonon-4.5.0 with >=pulseaudio-1.0 (phonon-pulseaudio.patch,367 bytes, text/plain)
2011-10-09 04:35 UTC, hirakendu
Details
ebuild that uses the phonon patch for pulseaudio (phonon-4.5.0-r101.ebuild,1.49 KB, text/plain)
2011-10-09 04:36 UTC, hirakendu
Details

Note You need to log in before you can comment on or make changes to this bug.
Description hirakendu 2011-10-09 04:33:59 UTC
Compilation fails with the error:

/var/tmp/portage/media-libs/phonon-4.5.0/work/phonon-4.5.0/phonon/pulsestream.cpp:84:65: error: ‘pow’ was not declared in this scope

After upgrade to >= pulseaudio-1.0 from <=pulse-audio-0.9*, /usr/include/pulse/sample.h has <math.h> include removed (that provides power function). So it needs to be added at either phonon/pulsestream.cpp or phonon/phonon/pulsestream_p.h.

Attached a modified ebuild and patch to resolve the bug.


Reproducible: Always
Comment 1 hirakendu 2011-10-09 04:35:43 UTC
Created attachment 289285 [details]
patch to make phonon-4.5.0 with >=pulseaudio-1.0
Comment 2 hirakendu 2011-10-09 04:36:24 UTC
Created attachment 289287 [details]
ebuild that uses the phonon patch for pulseaudio
Comment 3 Ulenrich 2011-10-09 20:24:01 UTC
@hirakendu, thank you, your patch works!
Comment 4 Arun Raghavan (RETIRED) gentoo-dev 2011-10-11 14:45:39 UTC
The fix is already upstream at:

https://projects.kde.org/projects/kdesupport/phonon/phonon/repository/revisions/436d5379abe83c53c652d8a251f7ab504a1523df

Could someone from KDE team like to apply this? I can add it to latest phonon if you're strapped for time.
Comment 5 Andreas K. Hüttel archtester gentoo-dev 2011-10-16 10:42:27 UTC
Fix added in phonon-4.5.0-r1, thanks to everyone involved and sorry this took so long.
Comment 6 Stefan Zwanenburg 2011-12-05 16:23:59 UTC
(In reply to comment #5)
> Fix added in phonon-4.5.0-r1, thanks to everyone involved and sorry this took
> so long.

Andreas, is there a reason why you removed phonon-4.5.0-[r1,r2] from the portage tree? I see in the ChangeLog that you did a "cleanup", which means that phonon gets downgraded to =4.5.0, which still has this bug.

Here are the lines from the ChangeLog I'm talking about:
>  30 Nov 2011; Andreas K. Huettel <dilfridge@gentoo.org>
>  -phonon-4.5.0-r1.ebuild, -phonon-4.5.0-r2.ebuild, -phonon-4.5.1.ebuild:
>  Cleanup

Perhaps it's an idea to reopen this bug until the ebuilds get back in the tree?
Comment 7 Andreas K. Hüttel archtester gentoo-dev 2011-12-05 21:06:38 UTC
(In reply to comment #6)
> (In reply to comment #5)
> > Fix added in phonon-4.5.0-r1, thanks to everyone involved and sorry this took
> > so long.
> 
> Andreas, is there a reason why you removed phonon-4.5.0-[r1,r2] from the
> portage tree? I see in the ChangeLog that you did a "cleanup", which means that
> phonon gets downgraded to =4.5.0, which still has this bug.
> 
> Here are the lines from the ChangeLog I'm talking about:
> >  30 Nov 2011; Andreas K. Huettel <dilfridge@gentoo.org>
> >  -phonon-4.5.0-r1.ebuild, -phonon-4.5.0-r2.ebuild, -phonon-4.5.1.ebuild:
> >  Cleanup
> 
> Perhaps it's an idea to reopen this bug until the ebuilds get back in the tree?

Maybe I'm missing something, but why dont you upgrade to 4.5.1-r1 ?
Comment 8 Stefan Zwanenburg 2011-12-07 08:03:22 UTC
> Maybe I'm missing something, but why dont you upgrade to 4.5.1-r1 ?

You're not really missing anything, but 4.5.1-r1 is keyword masked (at least on amd64), which means users get a broken package as one of the two only stable versions.
Comment 9 Andreas K. Hüttel archtester gentoo-dev 2011-12-07 09:47:01 UTC
(In reply to comment #8)
> > Maybe I'm missing something, but why dont you upgrade to 4.5.1-r1 ?
> 
> You're not really missing anything, but 4.5.1-r1 is keyword masked (at least on
> amd64), which means users get a broken package as one of the two only stable
> versions.

Yes, but both versions that I removed were keyword masked too. So? :)
Comment 10 Stefan Zwanenburg 2011-12-07 09:50:42 UTC
(In reply to comment #9)
> (In reply to comment #8)
> > > Maybe I'm missing something, but why dont you upgrade to 4.5.1-r1 ?
> > 
> > You're not really missing anything, but 4.5.1-r1 is keyword masked (at least on
> > amd64), which means users get a broken package as one of the two only stable
> > versions.
> 
> Yes, but both versions that I removed were keyword masked too. So? :)

That is indeed something I overlooked :)

But in the meantime, another wild bug has appeared that is a duplicate of this one: #393457.
Please disregard anything else I might have said that sounds like utter nonsense ;)
Comment 11 Kobboi 2011-12-09 13:12:42 UTC
Hitting this one also. Could you please get those patches in again?
Comment 12 Arun Raghavan (RETIRED) gentoo-dev 2011-12-09 13:21:21 UTC
*** Bug 393457 has been marked as a duplicate of this bug. ***