Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 384929 - www-apps/redmine-1.2.1: rails-2.3.11 is no longer in portage tree
Summary: www-apps/redmine-1.2.1: rails-2.3.11 is no longer in portage tree
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: MATSUU Takuto (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-29 12:18 UTC by sf
Modified: 2016-05-21 11:35 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch redmine to accept rails-2.3.14 (redmine-rails-2.3.14.patch,529 bytes, patch)
2011-09-29 12:18 UTC, sf
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description sf 2011-09-29 12:18:41 UTC
Created attachment 288223 [details, diff]
Patch redmine to accept rails-2.3.14

www-apps/redmine-1.2.1 depends on rails-2.3.11 and activerecord-2.3.11 which are no longer in the portage tree.

Please change the dependencies' versions to 2.3.14 which are supposed to work with a small patch (according to http://www.redmine.org/projects/redmine/wiki/RedmineInstall#Compatibility-notes).
Comment 1 Federico Cuello 2011-09-30 00:53:12 UTC
*redmine-1.2.1-r1 (29 Sep 2011)

The rev bump removed depency on rails completely!
Comment 2 sf 2011-09-30 09:29:09 UTC
NO! rails-2.3.11 was removed because of security issues (see bug #379511).
Comment 3 Federico Cuello 2011-09-30 14:52:38 UTC
(In reply to comment #2)
> NO! rails-2.3.11 was removed because of security issues (see bug #379511).

What I meant is that the current redmine revision has dependencies in rail commented out and it should depend in rails:2.3, or ~rails-2.3.14, that is the one available in the tree.

Now the ebuild looks like this:

ruby_add_rdepend "~dev-ruby/coderay-0.9.7
        >=dev-ruby/rubygems-1.3.7
        >=dev-ruby/ruby-net-ldap-0.0.4
        ~dev-ruby/i18n-0.4.2
        ~dev-ruby/rack-1.1.0
        dev-ruby/rake"
#ruby_add_rdepend ~dev-ruby/rails-2.3.11:2.3
#ruby_add_rdepend "~dev-ruby/activerecord-2.3.11:2.3[mysql?,postgres?,sqlite3?]"
ruby_add_rdepend fastcgi dev-ruby/ruby-fcgi
ruby_add_rdepend imagemagick dev-ruby/rmagick
ruby_add_rdepend openid dev-ruby/ruby-openid
ruby_add_rdepend passenger www-apache/passenger
Comment 4 sf 2011-09-30 18:39:01 UTC
Re comment #3:

Now redmine does not pull in any rails version in the portage tree at all (because you commented out the rdepends). And where does redmine get rails from?  It uses the bundled rails because the following line is commented out:

rm -fr vendor/rails || die

But the bundled rails version is 2.3.11, or is it not? And that is exactly the version with security issues.
Comment 5 Coacher 2011-10-14 18:28:39 UTC
(In reply to comment #3)
> (In reply to comment #2)
> > NO! rails-2.3.11 was removed because of security issues (see bug #379511).
> 
> What I meant is that the current redmine revision has dependencies in rail
> commented out and it should depend in rails:2.3, or ~rails-2.3.14, that is the
> one available in the tree.
> 
> Now the ebuild looks like this:
> 
> ruby_add_rdepend "~dev-ruby/coderay-0.9.7
>         >=dev-ruby/rubygems-1.3.7
>         >=dev-ruby/ruby-net-ldap-0.0.4
>         ~dev-ruby/i18n-0.4.2
>         ~dev-ruby/rack-1.1.0
>         dev-ruby/rake"
> #ruby_add_rdepend ~dev-ruby/rails-2.3.11:2.3
> #ruby_add_rdepend
> "~dev-ruby/activerecord-2.3.11:2.3[mysql?,postgres?,sqlite3?]"
> ruby_add_rdepend fastcgi dev-ruby/ruby-fcgi
> ruby_add_rdepend imagemagick dev-ruby/rmagick
> ruby_add_rdepend openid dev-ruby/ruby-openid
> ruby_add_rdepend passenger www-apache/passenger

You removed the dependency from rails and activerecord completely and also left the bundled rails that comes with redmine. What is the reason to do so? I have running redmine with rails-2.3.14 and activerecord-2.3.14 and it's ok. The only issue appeared is mentioned here: http://www.redmine.org/projects/redmine/wiki/RedmineInstall#Compatibility-notes

It says:
Rails 2.3.11 to 2.3.14 suffer from a major issue with sending mails to multiple recipients, see #8751 for details and solution.
Rails 2.3.14 is a minor security release known to work fine with Redmine 1.2.x series (except for previous point) and can be used as a replacement for 2.3.11 (read config/environment.rb first).

And the issue #8751 mentioned above is: http://www.redmine.org/issues/8751
It is fixed with this upstream commit: https://github.com/eac/tmail/commit/05940a3c9882147b090b061f7242a796515a2d1e
or patch attached in redmine's bugzilla: http://www.redmine.org/attachments/6502/11-tmail_multiple_recipients_patch.rb

The culprit is tmail package. The last release was a very long time ago, but there is needed fix in upstream (which seems to be staled too). I guess it is tmail which should be updated allowing redmine to work with new rails.
Comment 6 Coacher 2011-10-24 00:37:50 UTC
I am almost completele noob in writing ebuilds, so I was unable to figure out how to install tmail from git, but after manually pulling git and then running "gem build" I had tmail gem I needed. After changing RUBY_FAKEGEM_EXTRADOC to "README.rdoc CHANGES NOTES" (because it was changed upstream, see https://github.com/eac/tmail/blob/8304f1294d623e4f9d0727c1a5cd04b1733a38a7/README.rdoc) and fixing Manifest to work with newly compiled gem everything installed and running smoothly.

I hope somebody who is good at ebuild-fu will write a correct version with pulling from git and building in ebuild itself. However, I confirm tmail from git is working (for me).
Comment 7 MATSUU Takuto (RETIRED) gentoo-dev 2011-11-14 15:33:33 UTC
1.2.2 in cvs.