Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 384185 - media-plugins/audacious-plugins-3.0.3 fails compile
Summary: media-plugins/audacious-plugins-3.0.3 fails compile
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Tony Vroon (RETIRED)
URL:
Whiteboard:
Keywords:
: 384391 (view as bug list)
Depends on:
Blocks:
 
Reported: 2011-09-23 11:16 UTC by godmachine (Lance Poore)
Modified: 2011-09-25 11:27 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Full Build Log - audacious-plugins (media-plugins:audacious-plugins-3.0.3:20110923-110020.log,48.52 KB, text/plain)
2011-09-23 11:16 UTC, godmachine (Lance Poore)
Details
emerge --info output (emerge-info.txt,5.21 KB, text/plain)
2011-09-23 11:17 UTC, godmachine (Lance Poore)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description godmachine (Lance Poore) 2011-09-23 11:16:16 UTC
The new ebuild for audacious-plugins fails with this particular error:

Successfully compiled aosd_osd.c (plugin).
aosd_ui.c: In function ‘aosd_cb_configure_position_expose’:
aosd_ui.c:102:23: error: ‘GtkWidget’ has no member named ‘window’
aosd_ui.c:103:28: error: ‘GtkWidget’ has no member named ‘style’
Failed to compile aosd_ui.c (plugin)!
make[5]: *** [aosd_ui.plugin.o] Error 1
make[5]: *** Waiting for unfinished jobs..


Attached is the entire build log and emerge --info
Comment 1 godmachine (Lance Poore) 2011-09-23 11:16:47 UTC
Created attachment 287491 [details]
Full Build Log - audacious-plugins
Comment 2 godmachine (Lance Poore) 2011-09-23 11:17:37 UTC
Created attachment 287495 [details]
emerge --info  output
Comment 3 Steffen Hau 2011-09-23 12:07:07 UTC
This is caused by the aosd plugin beeing compiled against GTK3. If I manually replace GTK_CFLAGS with GTK218_CFLAGS and GTK_LIBS with GTK218_LIBS in src/aosd/Makefile then it compiles fine.
Comment 4 Steffen Hau 2011-09-23 12:10:11 UTC
Another workaround is to append "--disable-gtk3" to the configure options.
Comment 5 godmachine (Lance Poore) 2011-09-23 12:14:13 UTC
(In reply to comment #3)

Interesting, care to create a diff patch for that, I will use it as a patch in my /etc/portage/patches   until the ebuild is fixed.  Appreciate it!
Comment 6 Frank Heiden 2011-09-23 13:37:33 UTC
First time posting here.

I had the same problem then I noticed that audacious-3.0.3 has a gtk3 use flag

doing

USE="gtk3" emerge audacious

both audacious and audacious-plugins compile without problems here on ~amd64.
Comment 7 Joost Ruis 2011-09-23 14:28:39 UTC
I had the exact same issue.
Enable gtk3 on audacious worked for me.
Comment 8 Peter Huegler 2011-09-23 15:07:25 UTC
I have 2 machines - one has just gtk+-2.24.6 installed and the other has both (slotted) gtk+-3.0.12 and gtk+-2.24.6 installed.  Both are ~amd64.  audacious-plugins compiles fine on the machine with just gtk+2.24.6.  I didn't need to use the gtk3 use flag for audacious.  One the machine with the slotted gtk+ packages, I needed to enable the gtk3 use flag when compiling audacious to get audacious-plugins to compile.
Comment 9 godmachine (Lance Poore) 2011-09-23 15:23:01 UTC
(In reply to comment #6)
you shouldn't use USE=   prefixed to the emerge as a permanent solution,  but thanks for letting me know that audacious now requires the +gtk3 USE flag to be able to install the plugins,  this should be fixed with the audacious ebuild.
Comment 10 Tony Vroon (RETIRED) gentoo-dev 2011-09-23 15:31:56 UTC
I was forced into including a GTK+3 USE-flag. What I will do instead is commit a 3.0.3-r1 which depends on GTK+3 and forces --enable-gtk3 through the ebuild. Everybody okay with that?
Comment 11 godmachine (Lance Poore) 2011-09-23 19:57:06 UTC
(In reply to comment #10)
Yes the ebuild shouldn't fail due to a USE flag in another package not being set.  Just mark the gtk3  USE flag in audacious as a dependency for the audacious-plugins  or add a USE flag for audacious-plugins to enable/disable gtk+ or gtk3 parts of the plugins.
Comment 12 Joost Ruis 2011-09-23 20:52:18 UTC
(In reply to comment #10)
> I was forced into including a GTK+3 USE-flag. What I will do instead is commit
> a 3.0.3-r1 which depends on GTK+3 and forces --enable-gtk3 through the ebuild.
> Everybody okay with that?

Ofcourse.
Comment 13 Tony Vroon (RETIRED) gentoo-dev 2011-09-24 12:20:10 UTC
+*audacious-3.0.3-r1 (24 Sep 2011)
+
+  24 Sep 2011; Tony Vroon <chainsaw@gentoo.org> -audacious-3.0.3.ebuild,
+  +audacious-3.0.3-r1.ebuild, metadata.xml:
+  Trying to use GTK+2 results in plugin build failures, particularly aosd. Stop
+  offering the choice and handing the user the pieces. Closes bug #384185 by
+  Lance Poore.
Comment 14 Rafał Mużyło 2011-09-24 14:53:55 UTC
For those interested in an alternative approach:
adding 'gtk3? ( >=media-sound/audacious-3.0.3[gtk3=] )' to RDEPEND,
'$(use_enable gtk3)' to econf options and obviously 'gtk3' to IUSE in audacious-plugins-3.0.3.ebuild, while keeping second revision of audacious-3.0.3.ebuild would have made the plugins build against gtk2, even if gtk3 was installed (as long as audacious itself was built against gtk2, obviously).
Comment 15 Joe Kappus 2011-09-25 02:49:50 UTC
Don't want/need gtk3 yet.  Can we fix this so it doesn't depend on it for gtk2 users?  I'm trying to keep my systems minimal. 

Can we add a gtk2 USE flag to drop the gtk3 dep and build for just us gtk2 users?
Comment 16 Tony Vroon (RETIRED) gentoo-dev 2011-09-25 09:18:06 UTC
(In reply to comment #15)
> Don't want/need gtk3 yet.

Upstream did a *lot* of work to make GTK+3 work, GTK+2 is not supported for Audacious. If you do a local overlay you can do what you like though.
Comment 17 Rafał Mużyło 2011-09-25 11:27:22 UTC
*** Bug 384391 has been marked as a duplicate of this bug. ***