Bug 384165 – >=media-gfx/shotwell-0.11.1 does not compile with libraw 0.14.0

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Hans de Graaff 2011-09-23 06:26:08 UTC]

x86_64-pc-linux-gnu-gcc -c `pkg-config --cflags atk gdk-2.0 gdk-x11-2.0 gee-1.0 gexiv2 gio-unix-2.0 glib-2.0 gmodule-2.0 gstreamer-0.10 gstreamer-base-0.10 gstreamer-pbutils-0.10 gtk+-2.0 gudev-1.0 libexif libgphoto2 libsoup-2.4 libxml-2.0 sqlite3 unique-1.0 webkit-1.0 gconf-2.0  gthread-2.0` -I./vapi -D_PREFIX='"/usr"' -D_VERSION='"0.11.1"' -DGETTEXT_PACKAGE='"shotwell"' -D_LANG_SUPPORT_DIR='"/usr/share/locale"' -D_LIB='"lib64"' `./libraw-config --cflags` -Wall -O2 -pipe -march=native -fPIC -DG_UDEV_API_IS_SUBJECT_TO_CHANGE -o x86_64-pc-linux-gnu/photos/JfifSupport.o x86_64-pc-linux-gnu/photos/JfifSupport.c
x86_64-pc-linux-gnu/photos/GRaw.c: In function ‘graw_processor_add_masked_borders_to_bitmap’:
x86_64-pc-linux-gnu/photos/GRaw.c:683:2: warning: implicit declaration of function ‘libraw_add_masked_borders_to_bitmap’
x86_64-pc-linux-gnu/photos/GRaw.c: In function ‘graw_processor_rotate_fuji_raw’:
x86_64-pc-linux-gnu/photos/GRaw.c:917:2: warning: implicit declaration of function ‘libraw_rotate_fuji_raw’
x86_64-pc-linux-gnu/photos/GRaw.c: In function ‘graw_processor_configure_for_rgb_display’:
x86_64-pc-linux-gnu/photos/GRaw.c:1048:12: error: ‘libraw_output_params_t’ has no member named ‘filtering_mode’
x86_64-pc-linux-gnu/photos/GRaw.c:1048:30: error: ‘LIBRAW_FILTERING_AUTOMATIC’ undeclared (first use in this function)
x86_64-pc-linux-gnu/photos/GRaw.c:1048:30: note: each undeclared identifier is reported only once for each function it appears in
x86_64-pc-linux-gnu/photos/GRaw.c: In function ‘graw_throw_exception’:
x86_64-pc-linux-gnu/photos/GRaw.c:1359:8: error: ‘LIBRAW_CANNOT_ADDMASK’ undeclared (first use in this function)
make: *** [x86_64-pc-linux-gnu/photos/GRaw.o] Error 1

[Comment 1 Christoph Mende (RETIRED) 2011-09-23 18:18:14 UTC]

please try 0.11.2

[Comment 2 Travis Hansen 2011-09-23 21:54:51 UTC]

0.11.2 fails for me.

[Comment 3 Hans de Graaff 2011-09-24 06:29:11 UTC]

Fails in exactly the same way. Looks like it isn't fixed upstream yet.

[Comment 4 Yu Yuwei 2011-09-25 03:20:33 UTC]

(In reply to comment #3)
> Fails in exactly the same way. Looks like it isn't fixed upstream yet.

shotwell-0.11.2 fails with libraw-0.14.0 here.

[Comment 5 Ooblick 2011-09-25 16:58:29 UTC]

Upstream bug is http://redmine.yorba.org/issues/4170

[Comment 6 Mao PU 2011-09-28 07:42:53 UTC]

Created attachment 288051 [details, diff]
corrected dependency

Since this is an upstream issue and the target version for fixing it is set to shotwell-0.12, I think it is safe to specify correct dependencies for shotwell.

[Comment 7 nm (RETIRED) 2011-09-30 07:49:54 UTC]

let's hope upstream gets a proper fix out soon -- i just got bit by this bug. both 0.11.1 and 0.11.2 fail to build against the latest libraw.

[Comment 8 Maxim Kachur 2011-10-01 20:57:43 UTC]

same here. both 0.11.1 and 0.11.2

[Comment 9 Christoph Mende (RETIRED) 2011-10-01 21:16:08 UTC]

you can stop confirming it now, thank you

[Comment 10 Alexandre Rostovtsev (RETIRED) 2011-10-02 08:28:25 UTC]

Christoph, if there is no patch for this issue, please add a <libraw-0.14 dependency to the ebuild. Lots of people are hitting this problem.

[Comment 11 Samuli Suominen (RETIRED) 2011-10-02 08:30:17 UTC]

(In reply to comment #10)
> Christoph, if there is no patch for this issue, please add a <libraw-0.14
> dependency to the ebuild. Lots of people are hitting this problem.

And break the other applications, already built against the libraw-0.14 API/ABI?
Putting such downgrade is a bad idea. Best leave this fail until proper fix is available.

[Comment 12 Samuli Suominen (RETIRED) 2011-10-02 08:32:34 UTC]

(In reply to comment #10)
> Christoph, if there is no patch for this issue, please add a <libraw-0.14
> dependency to the ebuild. Lots of people are hitting this problem.

... or package.mask >=libraw-0.14 explaining why it's being masked, either way, that < is no solution at all

[Comment 13 Alexandre Rostovtsev (RETIRED) 2011-10-02 08:35:59 UTC]

(In reply to comment #11)
> And break the other applications, already built against the libraw-0.14
> API/ABI?
> Putting such downgrade is a bad idea. Best leave this fail until proper fix is
> available.

Are there any other popular packages that depend on libraw?

$ equery d libraw
 * These packages depend on libraw:
media-gfx/shotwell-0.11.2 (>=media-libs/libraw-0.9.0)

[Comment 14 Tim Harder 2011-10-02 09:25:06 UTC]

(In reply to comment #13)
> Are there any other popular packages that depend on libraw?

Both darktable and luminance-hdr, of which darktable builds fine with libraw-0.14.0 and I already patched luminance-hdr-2.1.0..

Patching shotwell probably wouldn't be too hard either, I just haven't gotten around to it.

[Comment 15 Tim Harder 2011-10-02 09:50:51 UTC]

Created attachment 288525 [details, diff]
Patch for libraw-0.14.0 support

Here's a quick patch to make shotwell-0.11.2 work with libraw-0.14.0. It can probably be improved, but I'm not really interested in spending more time on it.

[Comment 16 Tim Harder 2011-10-02 09:52:35 UTC]

Created attachment 288527 [details, diff]
Ebuild updates for libraw-0.14 support

Ebuild updates for shotwell-0.11.2 to go along with the patch for libraw-0.14.0 support.

[Comment 17 Alexandre Rostovtsev (RETIRED) 2011-10-02 10:08:41 UTC]

Created attachment 288529 [details, diff]
slighly more complete patch

A tiny bit more complete patch (same idea as Tim Harder's, but also drops the Libraw.Filterning enum from vapi, since none of the LIBRAW_FILTERING_* constants are in the public API in libraw-0.14).

Confirming that I visually get the same result with an unpatched shotwell-0.11.2 and libraw-0.13.8, and patch shotwell-0.11.2 with libraw-0.14.0, on some random raw files downloaded from http://www.rawsamples.ch/

[Comment 18 Mao PU 2011-10-04 11:44:30 UTC]

Of course it is better to have a fix than a workaround. I can confirm, that Alexandre Rostovtsevs patch works for shotwell-0.11.2 with libraw-0.14.0.

[Comment 19 Tim Harder 2011-10-04 18:20:31 UTC]

Fixed in CVS.