Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 383593 - media-video/ogmrip-0.13.6 fails to build with libpng-1.5
Summary: media-video/ogmrip-0.13.6 fails to build with libpng-1.5
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: libpng-1.5
  Show dependency tree
 
Reported: 2011-09-19 07:30 UTC by Alexandre Rostovtsev (RETIRED)
Modified: 2011-09-20 10:21 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
build log (ogmrip-0.13.6.build.log.gz,10.42 KB, application/x-gzip)
2011-09-19 07:30 UTC, Alexandre Rostovtsev (RETIRED) 		Details
ogmrip-0.13.6-zlib.patch (ogmrip-0.13.6-zlib.patch,740 bytes, patch)
2011-09-19 18:07 UTC, Olivier Rolland 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexandre Rostovtsev (RETIRED) gentoo-dev 2011-09-19 07:30:53 UTC 
Created attachment 286981 [details]
build log

media-vide/ogmrip fails to build with libpng-1.5 because in libpng-1.5, png.h no longer includes zlib.h, and ogmrip's source uses zlib macros (such as Z_BEST_COMPRESSION).

# USE="aac dbus dts gtk libnotify matroska mp3 mp4 nls ogm spell srt theora vorbis x264 xvid" emerge ogmrip
[...]
x86_64-pc-linux-gnu-gcc -DHAVE_CONFIG_H -I. -I.. -I/usr/include/libxml2   -I/usr/include/libpng15    -I/usr/local/include -I.. -Wall -D_FORTIFY_SOURCE=2  -march=native -O2 -pipe -g -I/usr/local/include -I.. -Wall -D_FORTIFY_SOURCE=2 -DG_DISABLE_SINGLE_INCLUDES -DGTK_DISABLE_SINGLE_INCLUDES -c spudec.c
subp2pgm.c: In function ‘write_png’:
subp2pgm.c:164:39: error: ‘Z_BEST_COMPRESSION’ undeclared (first use in this function)
subp2pgm.c:164:39: note: each undeclared identifier is reported only once for each function it appears in
subp2pgm.c:168:42: error: ‘Z_DEFAULT_STRATEGY’ undeclared (first use in this function)
make[2]: *** [subp2pgm.o] Error 1
Comment 1 Olivier Rolland 2011-09-19 18:07:30 UTC 
Created attachment 287033 [details, diff]
ogmrip-0.13.6-zlib.patch

This patch fixes this issue. Thanks for the report.
Comment 2 Markos Chandras (RETIRED) gentoo-dev 2011-09-20 10:21:13 UTC 
Fixed. Thanks for reporting