Same error as in bug #383351 when compiling src/main/dounzip.c Reproducible: Always
Created attachment 286835 [details, diff] patch to fix compilation with zlib-1.2.5.1-r1
Attached patch fixes it for me.
I confirm the bug and the patch. Needed to mess with paths for it to work with local portage overlay, though.
I can confirm the regression with zlib-1.2.5.1-r1. R and vlc both fail to compile with it installed. However, downgrading to zlib-1.2.5.1 works fine on my ~amd64 laptop. Which is what I did to rebuild them when libpng was upgraded today and I had to recompile everything built against the old version.
patch works for me ~x86
Comment on attachment 286835 [details, diff] patch to fix compilation with zlib-1.2.5.1-r1 this misses the whole point of the zlib change: you aren't supposed to be using these macros. instead, add the simple one liner: #define OF(x) x
That's in the ebuild for zlib-1.2.5-r1: # clean up namespace a little #383179 My patch uses that cleaned up namespace. If the comment in the ebuild does not describe the whole point of the change, what's the purpose of it? Your simple on-liner generates a new warning, when compiled with zlib < 1.2.5-r1 So I'd suggest: #ifndef OF #define OF(x) x #endif
(In reply to comment #7) works too
The patch works, but just updating the dep (as in the vlc bug) does not. Why don't we have a "proper" patch or updated R ebuild again? I'm confused...
Fixed with the patch suggested in comment #7 and an updated depend like the one in bug #383351 (the unzip dep was dropped in favor of minizip). Seems to work as advertised (more or less) on machines with both the old and new zlib.
