Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 381611 - stabilize net-firewall/xtables-addons-1.37
Summary: stabilize net-firewall/xtables-addons-1.37
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Keywording and Stabilization (show other bugs)
Hardware: All Linux
: Highest enhancement (vote)
Assignee: Peter Volkov (RETIRED)
URL:
Whiteboard:
Keywords: STABLEREQ
Depends on:
Blocks:
 
Reported: 2011-09-02 19:19 UTC by Peter Volkov (RETIRED)
Modified: 2011-09-15 10:00 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Volkov (RETIRED) gentoo-dev 2011-09-02 19:19:00 UTC 
Arch teams, please, stabilize net-firewall/xtables-addons-1.37. Thank you in advance.
Comment 1 Agostino Sarubbo gentoo-dev 2011-09-03 09:55:28 UTC 
  inherit.autotools             1
   net-firewall/xtables-addons/xtables-addons-1.37.ebuild: no eauto* function called

Should  be fixed before tests?
Comment 2 Mike Limansky 2011-09-03 18:41:12 UTC 
BTW, the current stable (1.31) cannot be built with the current stable kernel (2.6.39).

  CC [M]  /var/tmp/portage/net-firewall/xtables-addons-1.31/work/xtables-addons-1.31/extensions/xt_geoip.o
/var/tmp/portage/net-firewall/xtables-addons-1.31/work/xtables-addons-1.31/extensions/xt_TEE.c: In function 'tee_tg_route4':
/var/tmp/portage/net-firewall/xtables-addons-1.31/work/xtables-addons-1.31/extensions/xt_TEE.c:46: error: 'struct flowi' has no member named 'nl_u'
/var/tmp/portage/net-firewall/xtables-addons-1.31/work/xtables-addons-1.31/extensions/xt_TEE.c:47: error: 'struct flowi' has no member named 'nl_u'
/var/tmp/portage/net-firewall/xtables-addons-1.31/work/xtables-addons-1.31/extensions/xt_TEE.c:48: error: 'struct flowi' has no member named 'nl_u'
/var/tmp/portage/net-firewall/xtables-addons-1.31/work/xtables-addons-1.31/extensions/xt_TEE.c:50: warning: passing argument 2 of 'ip_route_output_key' from incompatible pointer type
include/net/route.h:131: note: expected 'struct flowi4 *' but argument is of type 'struct rtable **'
/var/tmp/portage/net-firewall/xtables-addons-1.31/work/xtables-addons-1.31/extensions/xt_TEE.c:50: error: too many arguments to function 'ip_route_output_key'
make[2]: *** [/var/tmp/portage/net-firewall/xtables-addons-1.31/work/xtables-addons-1.31/extensions/xt_TEE.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [_module_/var/tmp/portage/net-firewall/xtables-addons-1.31/work/xtables-addons-1.31/extensions] Error 2
make[1]: Leaving directory `/usr/src/linux-2.6.39.3'
make: *** [modules] Error 2
Comment 3 Elijah "Armageddon" El Lazkani (amd64 AT) 2011-09-04 05:18:19 UTC 
amd64: pass
Comment 4 Tony Vroon (RETIRED) gentoo-dev 2011-09-05 10:33:08 UTC 
+  05 Sep 2011; Tony Vroon <chainsaw@gentoo.org> xtables-addons-1.37.ebuild:
+  Marked stable on AMD64 based on arch testing by Agostino "ago" Sarubbo &
+  Elijah "Armageddon" El Lazkani in bug #381611. Removed incorrect inherit of
+  autotools, this eclass is not used.

X86 please proceed, the QA concern in comment #1 has been addressed.
Comment 5 Peter Volkov (RETIRED) gentoo-dev 2011-09-14 09:31:54 UTC 
Why this depend? xtables-addons is a separate package although it provides ipset too. :) Also such QA concerns should not block stabilization: just fix it and stabilize ;)
Comment 6 Andreas Schürch gentoo-dev 2011-09-15 10:00:22 UTC 
(In reply to comment #5)
> Why this depend? xtables-addons is a separate package although it provides
> ipset too. :) Also such QA concerns should not block stabilization: just fix it
> and stabilize ;)

For the depend on bug 381613, see my comment 12 there...
x86 stable, closing.