Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 381409 - FreeRDP rewrite (1.0) needs an ebulid
Summary: FreeRDP rewrite (1.0) needs an ebulid
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Mike Gilbert
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-01 09:01 UTC by Ferry
Modified: 2011-10-01 16:47 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
freerdp-9999.1.ebuild.patch (freerdp-9999.1.ebuild.patch,3.47 KB, patch)
2011-10-01 16:01 UTC, Peter Volkov (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ferry 2011-09-01 09:01:22 UTC
freerdp-9999 ebuild is supposed to build the latest git version. This no longer works, it seems the git url has changed from git://github.com/FreeRDP/FreeRDP.git to git://github.com/FreeRDP/FreeRDP-1.0.git (version number added).

Just changing the git url in the ebuild doesn't make it build though (it does do the git clone :)). I have little knowledge about build systems, and it's been a while since I built it, but it seems they have switched to cmake, from what I can make of it with my limited knowledge in this area.

On the other hand, probably good news, since it thus seems they're preparing for the 1.0 release, which should bring a lot of features many people have been waiting for :D.

Reproducible: Always
Comment 1 Mike Gilbert gentoo-dev 2011-09-04 16:44:20 UTC
I have changed the git uri to point at the "old" development repo. I also replaced the ebuild with an autotools-utils based implementation, and added a couple use flags.

I also have a mostly-working ebuild for FreeRDP-1.0 in my overlay, but it currently fails when it tries to install the manpage. Once I get that fixed, I will add it to the tree.

I'm leaving this open until that happens.
Comment 2 Peter Volkov (RETIRED) gentoo-dev 2011-10-01 16:01:37 UTC
Created attachment 288451 [details, diff]
freerdp-9999.1.ebuild.patch

Hi, looks like you've already commited git version so this bug can be closed. that said there was "# TODO: Add debug options" in ebuild. Patch in attachment adds all debugging options and updates descriptions to better reflect what they do. Also it adds sse2 USE flag. Please apply or give me Ok.
Comment 3 Mike Gilbert gentoo-dev 2011-10-01 16:21:51 UTC
(In reply to comment #2)
> Created attachment 288451 [details, diff]
> freerdp-9999.1.ebuild.patch
> 
> Hi, looks like you've already commited git version so this bug can be closed.
> that said there was "# TODO: Add debug options" in ebuild. Patch in attachment
> adds all debugging options and updates descriptions to better reflect what they
> do. Also it adds sse2 USE flag. Please apply or give me Ok.

Thanks for the patch! I'm ok with everything except the SSE2 flag; all that does is append -msse2 to CFLAGS.

Please commit.
Comment 4 Mike Gilbert gentoo-dev 2011-10-01 16:31:05 UTC
(In reply to comment #3)
> Thanks for the patch! I'm ok with everything except the SSE2 flag; all that
> does is append -msse2 to CFLAGS.

Ok, a quick re-review of the code shows that the SSE2 flags does do more than that, so ok to keep that.
Comment 5 Peter Volkov (RETIRED) gentoo-dev 2011-10-01 16:47:15 UTC
Thanks. Commited and fixed :)