Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 378849 - gnome-extra/nm-applet dependency fixes and proper bluetooth disabling support
Summary: gnome-extra/nm-applet dependency fixes and proper bluetooth disabling support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Robert Piasek (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 369901
  Show dependency tree
 
Reported: 2011-08-12 00:13 UTC by Mart Raudsepp
Modified: 2011-08-14 09:04 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
nm-applet dep fixes (nm-applet-fix-deps.patch,1.23 KB, patch)
2011-08-12 00:13 UTC, Mart Raudsepp
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mart Raudsepp gentoo-dev 2011-08-12 00:13:40 UTC
Created attachment 282967 [details, diff]
nm-applet dep fixes

nm-applet has a whole bunch of outdated dependencies, and wrong dependencies that really belong in net-misc/networkmanager and are already there (e.g libnl, which was removed but reappeared from some overlay merge or other mystical ways).

So the attached patch tries to fix them all.

intltool-0.40 is required by now instead of 0.35 per configure.ac.
bluetooth is made configurable by a simple $(use_with bluetooth), an option that was added upstream somewhere between 0.8 and 0.8.4 - however I haven't personally tested tweaking the USE flag with it.
libnl dep belongs to NM according to ancient commit by steev, and it still does - no ELF file in nm-applet links against libnl.
Same story with wireless-tools and wpa_supplicant - wireless.h (or wireless-helper.h from NM) is not included anywhere in nm-applet and wpa_supplicant D-Bus stuff isn't talked to as far as I can see (and there should be no reason to).
0.8.4 also got rid of libglade dependency by finally converting to GtkBuilder, so this redundant dep is removed as well.

I also believe that wireless-tools is only a build time dependency of net-misc/networkmanager, and not runtime. As in, only wireless.h is used at build time to get all the ioctl and related struct definitions from and libiw is not linked against, nor the iwconfig/iwlist and so on tools used. But meh, couldn't bother yet to finish thorough checking of that.

I think all the parts besides the bluetooth use_with and perhaps the wpa_supplicant/wireless-tools changes can be safely done to the current revision that is meant to be stabilized for bug 369901. But unsure of those, especially the bluetooth thing if suitable for stable candidate. I'm leaning towards "yes, fine, after some more testing and gnome-bluetooth linking checking with the different USE=bluetooth settings", as it should fix a bug of bluetooth support being enabled without USE flag requesting it, making gnome-bluetooth dep unknown to package manager.
Comment 1 Nirbheek Chauhan (RETIRED) gentoo-dev 2011-08-14 09:04:03 UTC
I did some other fixes to the ebuild (use GNOME_ORG_MODULE + EAPI bump, did the same for NetworkManager too).

0.8.4 should be fixed now, thanks for reporting!