377827 – dev-haskell/happy-1.18.6 doesn't build with USE=-doc

Bug 377827 - dev-haskell/happy-1.18.6 doesn't build with USE=-doc

Summary: dev-haskell/happy-1.18.6 doesn't build with USE=-doc

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	Normal normal
Assignee:	Gentoo's Haskell Language team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2011-08-04 23:13 UTC by Yvan Royon
Modified:	2011-08-05 10:56 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
fix for the 2 faulty lines (happy-1.18.6-docfail.patch,518 bytes, patch) 2011-08-04 23:15 UTC, Yvan Royon	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Yvan Royon 2011-08-04 23:13:41 UTC

The dev-haskell/happy-1.18.6 ebuild has logic that looks like:

  use doc && cd doc && econf || die "econf failed in /doc"

This is wrong: with USE="-doc", the '|| die' will be executed and the installation will abort. Instead, it should look like:

  if use doc; then
      cd doc && econf || die "econf failed in /doc"
  fi

If hackport generated that code, then hackport should be fixed.

Reproducible: Always

Comment 1 Yvan Royon 2011-08-04 23:15:13 UTC

Created attachment 282125 [details, diff]
fix for the 2 faulty lines

Comment 2 Wormo (RETIRED) gentoo-dev

2011-08-05 06:22:19 UTC

Thanks for reporting your fix, assigning to haskell team

Comment 3 Sergei Trofimovich (RETIRED) gentoo-dev

2011-08-05 10:56:00 UTC

(In reply to comment #0)
> If hackport generated that code, then hackport should be fixed.

It was me who added faulty part.

Pushed fix as:

>  05 Aug 2011; Sergei Trofimovich <slyfox@gentoo.org> happy-1.18.6.ebuild:
>  Fix build failure for USE=-doc case. Discovered and fixed by Yvan Royon, bug
>  #377827.

Thanks for the report and fix, Yvan!