>>> Working in BUILD_DIR: "/var/tmp/portage/kde-base/rocs-4.7.0/work/rocs-4.7.0_build" Test project /var/tmp/portage/kde-base/rocs-4.7.0/work/rocs-4.7.0_build Start 1: TestGraphs 1/4 Test #1: TestGraphs .......................***Exception: Other 1.15 sec Start 2: TestDynamicProperties 2/4 Test #2: TestDynamicProperties ............***Exception: Other 0.06 sec Start 3: TestIncludeManager 3/4 Test #3: TestIncludeManager ...............***Failed 0.02 sec Start 4: TestDataStructure 4/4 Test #4: TestDataStructure ................***Exception: Other 0.06 sec 0% tests passed, 4 tests failed out of 4 Total Test time (real) = 1.76 sec The following tests FAILED: 1 - TestGraphs (OTHER_FAULT) 2 - TestDynamicProperties (OTHER_FAULT) 3 - TestIncludeManager (Failed) 4 - TestDataStructure (OTHER_FAULT) Errors while running CTest
Created attachment 284065 [details] full test log Test log looks quite messy, i.e. tests are likely unmaintained. I particularly like this part: Loc: [/var/tmp/portage/kde-base/rocs-4.7.0/work/rocs-4.7.0/src/Tests/testGraph.cpp(341)] FAIL! : GraphTests::testQtScript() ######### Need to reimplemt this test case! ######## Restricted.
Same in 4.7.3
gentoo64 rocs # ebuild rocs-4.7.3.ebuild clean test Test project /mnt/gen2/tmpdir/portage/kde-base/rocs-4.7.3/work/rocs-4.7.3_build Start 1: TestGraphs 1/4 Test #1: TestGraphs .......................***Failed 0.19 sec Start 2: TestDynamicProperties 2/4 Test #2: TestDynamicProperties ............***Exception: Other 0.08 sec Start 3: TestIncludeManager 3/4 Test #3: TestIncludeManager ...............***Failed 0.02 sec Start 4: TestDataStructure 4/4 Test #4: TestDataStructure ................***Exception: Other 0.06 sec " ********* Start testing of GraphTests ********* Config: Using QTest library 4.7.4, Qt 4.7.4 QFile::remove: Empty or null file name klauncher(24847) kdemain: No DBUS session-bus found. Check if you have started the DBUS server. kdeinit4: Communication error with launcher. Exiting! " well what can I say? " PASS : GraphTests::initTestCase() PASS : GraphTests::createSimpleGraph() QDEBUG : GraphTests::manipulateSimpleGraph() QVariant(QString, "i") FAIL! : GraphTests::manipulateSimpleGraph() '_graphDocument->dataStructures().at(0)->data("b")->in_pointers().size() $ Loc: [/mnt/gen2/tmpdir/portage/kde-base/rocs-4.7.3/work/rocs-4.7.3/src/Tests/testGraph.cpp(151)] " Without establishing a dbus session first thing, I for one am not prepared to predict what could have been a result. " 2/4 Testing: TestDynamicProperties 2/4 Test: TestDynamicProperties " " klauncher(24858) kdemain: No DBUS session-bus found. Check if you have started the DBUS server. kdeinit4: Communication error with launcher. Exiting! " eeeh, " PASS : TestDynamicProperties::addNodeDynamicProperty() FAIL! : TestDynamicProperties::addEdgeDynamicProperty() 'e != 0' returned FALSE. (Pointer not created!) Loc: [/mnt/gen2/tmpdir/portage/kde-base/rocs-4.7.3/work/rocs-4.7.3/src/Tests/TestDynamicProperties.cpp(60)] " and so forth. Only test 3 does NOT attempt to plug into or invoke a dbus session. Changing to /mnt/gen2/tmpdir/portage/kde-base/rocs-4.7.3/work/rocs-4.7.3_build and running ctest or make test yields the same disaster. Perhaps consider contacting upstream and suggest don't bother. I suspect but would not be able to prove that some entries in the data files are wrong, but 1st things first. One fault at a time.
Tests still fail in 4.8.1 >>> Working in BUILD_DIR: "/var/tmp/portage/kde-base/rocs-4.8.1/work/rocs-4.8.1_build" Test project /var/tmp/portage/kde-base/rocs-4.8.1/work/rocs-4.8.1_build Start 1: TestGraphs 1/4 Test #1: TestGraphs .......................***Exception: Other 1.51 sec Start 2: TestDynamicProperties 2/4 Test #2: TestDynamicProperties ............***Exception: Other 1.68 sec Start 3: TestIncludeManager 3/4 Test #3: TestIncludeManager ...............***Failed 0.40 sec Start 4: TestDataStructure 4/4 Test #4: TestDataStructure ................***Exception: Other 1.18 sec 0% tests passed, 4 tests failed out of 4 Total Test time (real) = 4.89 sec The following tests FAILED: 1 - TestGraphs (OTHER_FAULT) 2 - TestDynamicProperties (OTHER_FAULT) 3 - TestIncludeManager (Failed) 4 - TestDataStructure (OTHER_FAULT) Errors while running CTest
Created attachment 306919 [details, diff] rocs-testfix.patch I've been poking at this further, and, well, I think the guy writing the tests wasn't paying attention or something. The tests are usable, but large sections of the code seem to have been copy-pasted without editing to fit, resulting in most of the errors. I've managed to patch the code to make tests 1 and 3 work fine, but the "Exception: Other" errors (which are segfaults) I'm still working on because they seem to be caused by a fundamental mis-handling of certain pointer types, and I'm working my way through the codebase to understand it. Oh, and Andreas: I fixed your favorite error by making that a QSKIP rather than a QFAIL. I've attached my work so far, though I was being a tad obsessive-compulsive in fixing a bunch of trailing spaces that don't really affect the code.
With a combination of upstream and ebuild changes, all but one tests now pass in -9999 (the one failure dbus-related). Test project /var/tmp/portage/kde-base/rocs-9999/work/rocs-9999_build Start 1: TestGraphStructure 1/6 Test #1: TestGraphStructure ............... Passed 0.18 sec Start 2: TestDataStructure 2/6 Test #2: TestDataStructure ................ Passed 0.17 sec Start 3: TestDynamicProperties 3/6 Test #3: TestDynamicProperties ............***Exception: Other 0.17 sec Start 4: TestIncludeManager 4/6 Test #4: TestIncludeManager ............... Passed 0.03 sec Start 5: TestLoadSave 5/6 Test #5: TestLoadSave ..................... Passed 0.17 sec Start 6: TestPlugins 6/6 Test #6: TestPlugins ...................... Passed 0.16 sec
For the record, upstream has 'just works' tests planned for 4.10.
Tests are working normally and I've therefore unrestricted them in -9999.
Re-enabled tests will be moved to tree with 4.9.0 Test project /var/tmp/portage/kde-base/rocs-4.8.97/work/rocs-4.8.97_build Start 1: TestLinkedListStructure 1/8 Test #1: TestLinkedListStructure .......... Passed 0.42 sec Start 2: TestGraphStructure 2/8 Test #2: TestGraphStructure ............... Passed 0.20 sec Start 3: TestDataStructure 3/8 Test #3: TestDataStructure ................ Passed 0.18 sec Start 4: TestDynamicProperties 4/8 Test #4: TestDynamicProperties ............ Passed 0.17 sec Start 5: TestIncludeManager 5/8 Test #5: TestIncludeManager ............... Passed 0.05 sec Start 6: TestLoadSave 6/8 Test #6: TestLoadSave ..................... Passed 0.15 sec Start 7: TestPlugins 7/8 Test #7: TestPlugins ...................... Passed 0.14 sec Start 8: TestScriptEngine 8/8 Test #8: TestScriptEngine ................. Passed 0.20 sec 100% tests passed, 0 tests failed out of 8 Total Test time (real) = 1.53 sec
