Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 372437 - net-misc/dhcpcd: Please include a systemd unit file
Summary: net-misc/dhcpcd: Please include a systemd unit file
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: William Hubbs
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-21 07:43 UTC by Michał Górny
Modified: 2011-06-21 20:16 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Proposed unit file (dhcpcd.service,137 bytes, text/plain)
2011-06-21 07:43 UTC, Michał Górny
Details
Patch to add the systemd unit file install (0001-Add-systemd-unit-file-to-net-misc-dhcpcd.patch,8.96 KB, patch)
2011-06-21 16:24 UTC, Michał Górny
Details | Diff
Fixed patch (0001-Add-systemd-unit-file-to-net-misc-dhcpcd.patch,3.30 KB, patch)
2011-06-21 16:26 UTC, Michał Górny
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2011-06-21 07:43:38 UTC
Created attachment 277649 [details]
Proposed unit file

We'd appreciate having a systemd unit file installed along with dhcpcd. It would be something like:

	inherit systemd

	src_install() {
		#...
		systemd_dounit "${FILESDIR}"/dhcpcd.service || die
	}
Comment 1 William Hubbs gentoo-dev 2011-06-21 11:47:29 UTC
I can encorporate it this way, but you might prefer to file a request
upstream for systemd support [1] and reference it here so that we can
track whether or not upstream adds this.

Let me know if you want to do this and if you still want me to revbump
the ebuild and encorporate the change you suggest.

Also, can you please attach the ebuild patch to this bug instead of
putting it inline in the comments?

[1] http://roy.marples.name/projects/dhcpcd/wiki
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2011-06-21 12:00:15 UTC
I pinged Roy for that but I don't think it's worth a release. I'll let you know when and how he responds.
Comment 3 William Hubbs gentoo-dev 2011-06-21 13:11:50 UTC
Can you please put a link to the upstream bug in this bug?

Thanks,

William
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2011-06-21 16:24:09 UTC
Created attachment 277683 [details, diff]
Patch to add the systemd unit file install

I asked Roy on IRC and he's not interested in keeping that file upstream. Thus, attaching the patch to ebuild.
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2011-06-21 16:26:29 UTC
Created attachment 277685 [details, diff]
Fixed patch

Oops, it didn't catch the move.
Comment 6 William Hubbs gentoo-dev 2011-06-21 20:16:57 UTC
I could not use your patch directly, but the changes are in 5.2.12-r1.