Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 372189 - dev-ruby/kramdown-0.13.3 missing (check on) doc USE flag
Summary: dev-ruby/kramdown-0.13.3 missing (check on) doc USE flag
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Ruby Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-18 15:29 UTC by Kai Dietrich
Modified: 2011-06-19 08:01 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kai Dietrich 2011-06-18 15:29:14 UTC 
the check on the doc use flag is not implemented correctly:

original ebuild code:

IUSE=""
ruby_add_bdepend "doc? ( dev-ruby/rdoc )"
all_ruby_compile() {
    rdoc-2 -o htmldoc/rdoc --main README --title kramdown lib README || die "Unable to generate documentation"
}

better ebuild code:

IUSE="doc"
ruby_add_bdepend "doc? ( dev-ruby/rdoc )"
all_ruby_compile() {
    if use doc; then
        rdoc-2 -o htmldoc/rdoc --main README --title kramdown lib README || die "Unable to generate documentation"
    fi
}


Reproducible: Always

Steps to Reproduce:
1.USE="-doc" emerge -av dev-ruby/kramdown
Actual Results:  
emerge may fail because rdoc is not installed and docs are attempted to be build

Expected Results:  
docs should not be build
Comment 1 Hans de Graaff gentoo-dev Security 2011-06-19 08:01:46 UTC 
This is now fixed in dev-ruby/kramdown-0.13.3. Thanks for the report and proposed fix.