Created attachment 276931 [details, diff] Patch to util-linux-2.19.1-r1 The patches for loop-aes support in util-linux are finally released. Can we please get this support re-added? I've attached a patch. I assumed a revbump when I wrote it. Should take care of everything. Thanks!
I assume this will mean crypto@ gets added to metadata.xml with note that USE=loop-aes is maintained by crypto@, not base-system@ Right?
(In reply to comment #1) > I assume this will mean crypto@ gets added to metadata.xml with note that > USE=loop-aes is maintained by crypto@, not base-system@ > > Right? That is fine yes. I'd also appreciate a "heads up" bug when/if USE="loop-aes" gets dropped again. It shouldn't break anyone's boxes in the future, but I still want the bug there so I can remember to hound upstream for the patch.
if you're stepping up to maintain the loop-aes code, and all bugs go to you, then feel free to commit. you must also add an appropriate metadata entry though (see openssh's metadat.xml for an example ala USE=ldap).
(In reply to comment #3) > if you're stepping up to maintain the loop-aes code, and all bugs go to you, > then feel free to commit. you must also add an appropriate metadata entry > though (see openssh's metadat.xml for an example ala USE=ldap). When you say "maintain" do you mean in the traditional upstream sense? or are you just referring to the "from the Gentoo point of view" sense? I'm guessing the latter, but I'd prefer confirm it. If it's the latter, sure. I'll deal with the loop-aes patch within Gentoo / util-linux.
it depends. when i version bump util-linux, i'm not going to do anything related to loop-aes, and all bugs related to loop-aes are going to be assigned to you. they certainly wont be visible to base-system@g.o for the exact reason i punted in the first place -- i dont want to listen to useless people whine and not actually contribute anything. i dont recall ever seeing any loop-aes related bugs with util-linux other than version bumps ...
(In reply to comment #5) > it depends. when i version bump util-linux, i'm not going to do anything > related to loop-aes, and all bugs related to loop-aes are going to be assigned > to you. they certainly wont be visible to base-system@g.o for the exact reason > i punted in the first place -- i dont want to listen to useless people whine > and not actually contribute anything. > > i dont recall ever seeing any loop-aes related bugs with util-linux other than > version bumps ... Ok. That's fine with me. If you could please give me a heads up when you bump it would be appreciated. Loop-aes users won't break anymore when loop-aes support is removed from util-linux, so as long as I know it's been bumped, I can go ahead and make sure the patch makes it in before we try to stable it. If it's a big version change, just go ahead and punt loop-aes from util-linux, and I'll take care of readding it and testing it. If it's a minor one, maybe just make sure it compiles with USE="loop-aes" still. If it doesn't, punt loop-aes and assign me a bug. That workflow work for you?
i can send you an e-mail around the time i bump. i'm not going to build test it in any way though.
(In reply to comment #7) > i can send you an e-mail around the time i bump. i'm not going to build test > it in any way though. Ok. Then when you do bump, punt the loop-aes flag entirely. Otherwise we risk breaking something. As long as it isn't present, loop-aes users won't get upgraded (just in case people are running ~arch). (Comments would be ideal, just so I don't have to readd all the code every time). I'll get this committed tonight. Thanks.
Mike, Do you want this revbumped? Or do you want it done in util-linux-2.19.1.ebuild
(In reply to comment #9) > Mike, > Do you want this revbumped? Or do you want it done in util-linux-2.19.1.ebuild I'm not the person you asked but no revbump is required. The PM will handle it just fine w/ --newuse.
Done in CVS. Thanks all. 17 Jun 2011; Dane Smith <c1pher@gentoo.org> util-linux-2.19.1.ebuild, metadata.xml: Re-add support for loop-aes wrt bug 371437.
