Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 370267 - dev-python/msgpack-0.1.12 (new package)
Summary: dev-python/msgpack-0.1.12 (new package)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Default Assignee for New Packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-06-06 12:27 UTC by Johan Bergström
Modified: 2011-12-28 03:26 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
msgpack-0.1.9.ebuild (msgpack-0.1.9.ebuild,759 bytes, text/plain)
2011-06-06 12:27 UTC, Johan Bergström
Details
msgpack-0.1.9.ebuild (msgpack-0.1.9.ebuild,760 bytes, text/plain)
2011-06-06 14:11 UTC, Johan Bergström
Details
msgpack-0.1.10.ebuild (msgpack-0.1.10.ebuild,715 bytes, text/plain)
2011-08-23 14:09 UTC, Johan Bergström
Details
msgpack-0.1.10.ebuild (msgpack-0.1.10.ebuild,677 bytes, text/plain)
2011-08-29 19:48 UTC, Johan Bergström
Details
msgpack-0.1.12.ebuild (msgpack-0.1.12.ebuild,916 bytes, text/plain)
2011-12-27 21:00 UTC, Johan Bergström
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Johan Bergström 2011-06-06 12:27:43 UTC
Created attachment 275991 [details]
msgpack-0.1.9.ebuild

(CC:ing python@ since they might be interested in this, sorry if I'm way off here)

Attaching ebuild of the msgpack (de)serializer for python. Following the current name conventions (dev-libs/msgpack dev-ruby/msgpack). I got it to build for python 2.5,2.6,2.7 and 3.1 - but one test segfaults on all versions: test_obj.test_bad_hook

I'll take a look at what's been changed upstream, perhaps there is a solution in HEAD.

Also, I'm not very happy about "cd test; foo" in src_test() - but I don't know any other way of avoiding that PYTHONPATH issue.
Comment 1 Johan Bergström 2011-06-06 14:11:59 UTC
Created attachment 276015 [details]
msgpack-0.1.9.ebuild

With some help from Arfrever, I was able to remove the "cd test".

Additionally, Arfrever also noted that disabling the segfault test and running the suite on 3.1, 3.2 will show a rather bleak test result: FAILED (errors=14, failures=3)
Comment 2 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev 2011-06-06 14:14:34 UTC
DISTUTILS_SRC_TEST="nosetests" already adds "test? ( dev-python/nose )" to DEPEND.

src_test() {
  python_execute_nosetests -P '$(ls -d build-${PYTHON_ABI}/lib.*)' -- -w test
}
Comment 3 Johan Bergström 2011-08-23 14:09:24 UTC
Created attachment 284361 [details]
msgpack-0.1.10.ebuild

New ebuild for msgpack 0.1.10. Note: python3 has issues running the test suite. I'm currently looking into it (talking to upstream)
Comment 4 Dirkjan Ochtman (RETIRED) gentoo-dev 2011-08-29 09:21:55 UTC
Will you be proxying it?
Comment 5 Johan Bergström 2011-08-29 09:26:41 UTC
Yes, I will proxy it - but I prefer keeping it out until the test suite is fixed on python 3.
Comment 6 Maxim Koltsov (RETIRED) gentoo-dev 2011-08-29 09:27:54 UTC
If you mention proxy maintaining, CC apropriate herd :)
Johan, i can take it as python@ and proxy-maint@ when you think it's ready.
Comment 7 Johan Bergström 2011-08-29 09:54:21 UTC
After washing this through 2to3 and fiddling around with nosetests3 I have to
draw the conclusion that the test suite isn't ready to run on python 3. We
should therefore disable it.

Let's wait a couple of days and see what upstream says about it. Track progress
here: http://jira.msgpack.org/browse/MSGPACK-33
Comment 8 Johan Bergström 2011-08-29 19:48:10 UTC
Created attachment 285031 [details]
msgpack-0.1.10.ebuild

Updated ebuild with minor fixes, all contributed by Arfrever (thanks for your valuable feedback!).
Comment 9 Johan Bergström 2011-08-29 19:48:57 UTC
(In reply to comment #8)
> Created attachment 285031 [details]
> msgpack-0.1.10.ebuild
> 
> Updated ebuild with minor fixes, all contributed by Arfrever (thanks for your
> valuable feedback!).

Oh, forgot to mention - we now skip tests on 3.*
Comment 10 Johan Bergström 2011-09-03 17:40:10 UTC
There's actually a "test3" in their git repo, which now is added to MANIFEST.in. These tests pass perfectly (nosetests3 -w test3) on py 3.1, 3.2 - so when 0.1.11 is out I'll update the ebuild and we'll hopefully have a perfectly fine ebuild
Comment 11 Maxim Koltsov (RETIRED) gentoo-dev 2011-09-03 18:26:36 UTC
(In reply to comment #10)
> There's actually a "test3" in their git repo, which now is added to
> MANIFEST.in. These tests pass perfectly (nosetests3 -w test3) on py 3.1, 3.2 -
> so when 0.1.11 is out I'll update the ebuild and we'll hopefully have a
> perfectly fine ebuild
Ok, that's fine. Ping us when you are ready to maintain it in tree.
Comment 12 Dirkjan Ochtman (RETIRED) gentoo-dev 2011-12-01 11:00:30 UTC
Any news here?
Comment 13 Johan Bergström 2011-12-01 11:57:08 UTC
Sorry for my late response. Fellt out of my radar :( No 0.1.11 with python3 tests yet, lets get on with the show (read: release 0.1.10 with python 3 tests disabled)?
Comment 14 Dirkjan Ochtman (RETIRED) gentoo-dev 2011-12-01 13:57:04 UTC
Seems fine to me.
Comment 15 Johan Bergström 2011-12-27 21:00:58 UTC
Created attachment 297115 [details]
msgpack-0.1.12.ebuild

OMG msgpack 0.1.12 here. Includes python 3 fixes and removes setuptools dep. Got some help from Arfrever to solve pythonpath issues regarding nosetests. (note to nose users: nose defaults to -w . which will mess with your PYTHONPATH)
Comment 16 Patrick Lauer gentoo-dev 2011-12-28 03:14:15 UTC
 * Testing of dev-python/msgpack-0.1.12 with CPython 3.2...
PYTHONPATH=build/lib.linux-x86_64-3.2 nosetests --verbosity=1 -P -w test
/usr/bin/nosetests: '/usr/bin/nosetests-3.2' does not exist
 * ERROR: dev-python/msgpack-0.1.12 failed (test phase):


Now that's a funny one, but most likely my fault :)
Comment 17 Patrick Lauer gentoo-dev 2011-12-28 03:26:10 UTC
+  28 Dec 2011; Patrick Lauer <patrick@gentoo.org> +metadata.xml,
+  +msgpack-0.1.12.ebuild:
+  Initial import for #370267, ebuild by Johan Bergstr�m

(I wonder if my console mangled that?)