Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 36842 - [PATCH] sys-apps/groff-1.18.1-r3: pic2graph is buggy
Summary: [PATCH] sys-apps/groff-1.18.1-r3: pic2graph is buggy
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo's Team for Core System packages
URL: http://www.catb.org/~esr/hacker-emble...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-12-30 13:28 UTC by Malte S. Stretz
Modified: 2004-10-03 00:14 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patch against pic2graph (fix missing command) (pic2graph.patch1,274 bytes, patch)
2003-12-30 13:31 UTC, Malte S. Stretz
Details | Diff
patch against pic2graph (make it more FHS conforme) (pic2graph.patch2,579 bytes, patch)
2003-12-30 13:32 UTC, Malte S. Stretz
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Malte S. Stretz 2003-12-30 13:28:32 UTC
Seems like the pic2graph util shipped with that version of groff is buggy. It's a shell script, in line 48 is missing a command. I'll attach a patch to fix this (might need to be sent upstream to ESR if that file is still buggy in a more current version).

Another thing is that the util uses /usr/tmp instead of /var/tmp. That's a correct symlink on most systems (including Gentoo) but that doesn't make it FHS conform :) I'll attach another patch for this.

Reproducible: Always
Steps to Reproduce:
1. wget http://www.catb.org/~esr/hacker-emblem/glider.pic
2. pic2graph < glider.pic

Actual Results:  
/tmp/pic2graph: line 48: syntax error near unexpected token `)' 
/tmp/pic2graph: line 48: `    -format)' 
 

Expected Results:  
Dunno, but no error.
Comment 1 Malte S. Stretz 2003-12-30 13:31:28 UTC
Created attachment 22873 [details, diff]
patch against pic2graph (fix missing command)
Comment 2 Malte S. Stretz 2003-12-30 13:32:01 UTC
Created attachment 22874 [details, diff]
patch against pic2graph (make it more FHS conforme)
Comment 3 SpanKY gentoo-dev 2004-10-03 00:14:24 UTC
i updated the sed statement to fix the shift/-U issue and e-mailed upstream about it

groff-1.19.1-r1 resolves the tmpdir issue

sorry for the delay ;)