I wish Gentoo would provide the B.A.T.M.A.N. advanced control and management tool required to control the batman-adv module available in linux 2.6.38 and 2.6.39. I already found a package, but it is not part of Gentoo[1]. It is already part of Debian[2] and Ubuntu[3]. [1] http://gitorious.org/s3d-gentoo/s3d-gentoo/trees/master/net-misc/batctl [2] http://packages.qa.debian.org/b/batctl.html [3] https://launchpad.net/ubuntu/+source/batctl Reproducible: Always
+*batman-adv-2011.1.0 (20 May 2011) + + 20 May 2011; Michael Weber <xmw@gentoo.org> +batman-adv-2011.1.0.ebuild, + +metadata.xml: + Initial import, thanks to Emil Langrock for the report (bug 368213) and s3d + for the initial ebuild. +
+*batctl-2011.1.0 (20 May 2011) + + 20 May 2011; Michael Weber <xmw@gentoo.org> +batctl-2011.1.0.ebuild, + +metadata.xml: + Initial import, thanks to Emil Langrock for the report (bug 368213) and s3d + for the initial ebuild. +
+*batman-vis-0.3.2 (20 May 2011) + + 20 May 2011; Michael Weber <xmw@gentoo.org> +batman-vis-0.3.2.ebuild, + +files/batman-vis-conf.d, +files/batman-vis-init.d, +metadata.xml: + Initial import, thanks to Emil Langrock for the report (bug 368213) and s3d + for the initial ebuild. +
Why do you provide batman-adv-2011.1.0? It is now part of the kernel and that is also the reason why it was removed from Debian and from s3d-gentoo repository
Looked through you ebuilds and it makes sense. Thanks
And noticed that you use sometimes http://downloads.open-mesh.org/batman/releases/ and sometimes http://downloads.open-mesh.org/batman/stable/sources/ as download path. Wouldn't it be better to use everywhere the same?
And I doubt that it was a good idea to use those sed expression. Now you removed the -std=gnu99 which is necessary to compile batctl cleanly. It is also easier to set V=1 instead of overriding Q_CC and Q_LD
I would recommend to change it to something like that: sed -e "/^CFLAGS/s: -O[^[:space:]]* : :" \ -e "/^CFLAGS/s: -g[^[:space:]]* : :" \ -e "/^NUM_CPUS/d" \ -e "/\$(MAKE)/s: -j \$(NUM_CPUS) : :" \ -e "/BINARY_NAME=/s:vis:${PN}:" \ -i Makefile || die And you can also just call make batctl instead of make all to remove the automatic parallel build. batman-vis would be similar. I attach my version of the ebuilds
Created attachment 274185 [details] batman-vis-0.3.2.ebuild Fixed batman-vis ebuild
Created attachment 274187 [details] batctl-2011.1.0.ebuild Fixed batctl ebuild
(In reply to comment #4) > Why do you provide batman-adv-2011.1.0? It is now part of the kernel Tru for 2.6.38 and .39. But false for 2.6.21-37 (which are documented to work). (In reply to comment #6) > And noticed that you use sometimes > http://downloads.open-mesh.org/batman/releases/ and sometimes > http://downloads.open-mesh.org/batman/stable/sources/ as download path. > Wouldn't it be better to use everywhere the same? I just picked up the urls as there're referenced at http://www.open-mesh.org/wiki/open-mesh/Download (In reply to comment #7) > And I doubt that it was a good idea to use those sed expression. Now you > removed the -std=gnu99 which is necessary to compile batctl cleanly. It is also > easier to set V=1 instead of overriding Q_CC and Q_LD good point on V=1 and -std=gnu99, but the -g* -O* are property of /etc/make.conf. Esp. (In reply to comment #8) > And you can also just call make batctl instead of make all to remove the > automatic parallel build. I don't want to remove parallel build per se, but it's up to the /etc/make.conf:MAKEOPTS to decide this. Not some crappy CPU detection. Thanks for the feedback.
+ 22 May 2011; Michael Weber <xmw@gentoo.org> batctl-2011.1.0.ebuild: + Improved sed expression and sr_compile, thanks to Emil Langrock (bug 368213) I've decided to stick to the all target for future releases, which might lack the ${PN} target. + 22 May 2011; Michael Weber <xmw@gentoo.org> batman-vis-0.3.2.ebuild: + Improved sed expression, src_compile and updated SRC_URI, thanks to Emil + Langrock (bug 368213)
Do I read it correctly? You warn either when the batman-adv module is compiled using the kernel or when the module is _not_ installed using net-misc/batctl. Sounds wrong to me.
