Bug 367241 – app-shells/bash-4.2_p10 - /bin/sh symlink is not rewritten atomically

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Tristan Heaven (RETIRED) 2011-05-14 13:33:04 UTC]

Created attachment 273195 [details, diff]
bash-4.2_p10.ebuild.patch

As can be seen with strace, ln -sf removes /bin/sh before rewriting it:

symlink("bash", "/bin/sh")              = -1 EEXIST (File exists)
unlink("/bin/sh")                       = 0
symlink("bash", "/bin/sh")              = 0

Here's a patch which should fix that by moving the new symlink from a temp file.

[Comment 1 SpanKY 2011-05-16 05:45:26 UTC]

looks fine, feel free to commit to all the vers in the tree

[Comment 2 Tristan Heaven (RETIRED) 2011-05-16 10:43:31 UTC]

Fixed.

'touch -h "${ROOT}"/bin/sh' would be better but I'm not sure it would work everywhere yet.