Bug 366857 – xfce-base/libxfce4util-4.8.1: needs --disable-visibility on Darwin

• Status: RESOLVED FIXED
• Product: Gentoo/Alt

[Description Leho Kraav (:macmaN @lkraav) 2011-05-11 09:42:53 UTC]

http://comments.gmane.org/gmane.comp.desktop.xfce.devel.version4/17123

[Comment 1 Leho Kraav (:macmaN @lkraav) 2011-05-11 09:53:25 UTC]

same goes for xfce-base/xfconf-4.8.0

[Comment 2 Leho Kraav (:macmaN @lkraav) 2011-05-11 09:55:36 UTC]

same goes for xfce-base/libxfce4ui-4.8.0

[Comment 3 Leho Kraav (:macmaN @lkraav) 2011-05-11 13:25:58 UTC]

and xfce-base/exo-0.6.0

[Comment 4 Jeremy Olexa (darkside) (RETIRED) 2011-05-11 13:48:02 UTC]

Seems like a valid addition for xfconf.eclass, xfce team?

[Comment 5 Samuli Suominen (RETIRED) 2011-05-11 14:38:12 UTC]

(In reply to comment #4)
> Seems like a valid addition for xfconf.eclass, xfce team?

Not all xfconf.eclass consumers have this flag, take libxfcegui4 for example.  Futhermore it should only be set for Darwin, we don't want this for others.

So I'm afraid you are stuck with some CHOST based check and do it per ebuild basis

[Comment 6 Samuli Suominen (RETIRED) 2011-05-11 14:42:22 UTC]

[[ ${CHOST} == *-darwin* ]] && XFCONF+=( --disable-visibility )

[Comment 7 Jeremy Olexa (darkside) (RETIRED) 2011-05-11 14:45:53 UTC]

(In reply to comment #5)
> (In reply to comment #4)
> > Seems like a valid addition for xfconf.eclass, xfce team?
> 
> Not all xfconf.eclass consumers have this flag, take libxfcegui4 for example. 
> Futhermore it should only be set for Darwin, we don't want this for others.

Naturally, I meant only for darwin.

> So I'm afraid you are stuck with some CHOST based check and do it per ebuild
> basis

I didn't check all packages, I sort of assumed it was a common flag.

(In reply to comment #6)
> [[ ${CHOST} == *-darwin* ]] && XFCONF+=( --disable-visibility )

Thanks, the prefix team will add as needed.

[Comment 8 Fabian Groffen 2011-05-20 17:53:37 UTC]

added to all four packages, thanks