366735 – gnome-extra/gnome-power-manager-2.32: Keyboard backlight patch

Bug 366735 - gnome-extra/gnome-power-manager-2.32: Keyboard backlight patch

Summary: gnome-extra/gnome-power-manager-2.32: Keyboard backlight patch

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	[OLD] GNOME (show other bugs)
Hardware:	All Linux

Importance:	Normal enhancement (vote)
Assignee:	Gentoo Linux Gnome Desktop Team

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2011-05-10 10:04 UTC by Andy Botting
Modified:	2011-06-27 19:05 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Patch to gnome-power-manager 2.32 (gnome-power-manager-2.32.0-kb-backlight.patch,96.99 KB, patch) 2011-05-10 10:05 UTC, Andy Botting	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Andy Botting 2011-05-10 10:04:56 UTC

This patch allows gnome-power-manager 2.32 to control the keyboard backlight on laptops including the Macbook Pro, removing the need to use pommed in Gnome.

The patch was backported from gpm trunk to 2.32 for Ubuntu (see http://mac.linux.be/content/keyboard-backlight-support-patched-gnome-power-manager) and I just hacked it to remove the Ubuntu-specific OSD bits.

It's been lightly tested, but seems to work as intended.

Reproducible: Always

Comment 1 Andy Botting 2011-05-10 10:05:57 UTC

Created attachment 272717 [details, diff]
Patch to gnome-power-manager 2.32

Comment 2 Thomas Zwaagstra 2011-06-15 02:51:35 UTC

Patch works flawlessly, thanks Andy.

Comment 3 Pacho Ramos gentoo-dev

2011-06-27 19:05:23 UTC

+*gnome-power-manager-2.32.0-r2 (27 Jun 2011)
+
+  27 Jun 2011; Pacho Ramos <pacho@gentoo.org>
+  +gnome-power-manager-2.32.0-r2.ebuild,
+  +files/gnome-power-manager-2.32.0-close-fd.patch,
+  +files/gnome-power-manager-2.32.0-convert-percentage.patch,
+  +files/gnome-power-manager-2.32.0-no-xfce.patch,
+  +files/gnome-power-manager-2.32.0-xbacklight-crash.patch:
+  Revision bump including multiple fixes and enhancements: upstream patch for
+  fixing brightness changing, don't close non opened fd preventing crashes,
+  don't use in XFCE, don't crash on systems which don't have XBACKLIGHT. This
+  also includes a backported patch by Andy Botting adding support to control
+  keyboard backlight (bug #366735).
+