Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 366107 - media-gfx/splashutils-1.5.4.3-r3: init.d service OpenRC issues, wrong mount options
Summary: media-gfx/splashutils-1.5.4.3-r3: init.d service OpenRC issues, wrong mount o...
Status: RESOLVED TEST-REQUEST
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-05 16:03 UTC by Faustus
Modified: 2013-01-20 10:44 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Faustus 2011-05-05 16:03:13 UTC
/sbin/splash-functions.sh and libfbsplash.c mount ${spl_cachedir} with mode=644, which doesn't make sense for a directory. Also suggest adding noexec,nosuid,nodev to this and similar mounts, to be compatible with the mount options used by OpenRC.

/etc/init.d/fbcondecor: uses ${RC_TTY_NUMBER}, whereas OpenRC defines ${rc_tty_number}. Suggest using ttyn=${rc_tty_number:-${RC_TTY_NUMBER:-12}}, similar to other OpenRC init.d scripts.

Also, request propagating these and other (#339767) splashutils updates to the portage tree.
Comment 1 Faustus 2011-05-05 16:40:00 UTC
Also, the ebuild should create the /lib/splash/sys directory (in addition to others).
Comment 2 Faustus 2011-05-05 17:49:06 UTC
I am also having a problem with programmatically switching to the silent frame, and as far as I noticed, the problem only appeared with OpenRC.

That is, switching between verbose and silent with F2 during boot or when running "splash_manager -c demo" works just fine. Moreover, just switching between VCs with Alt-Left/Right (during boot) gets to the verbose/silent frames fine. Running "splash svc_input_begin svcname" / "splash_verbose" during init.d/svcname gets to the verbose frame just fine (and I can then see the silent VC with Alt-*). But, trying to restore the silent frame programmatically ("splash svc_input_end svcname" / "splash_silent") doesn't work at all, and I am completely at loss for the reason. I guess that just executing chvt with the correct argument might work, but that doesn't sound right.
Comment 3 Faustus 2011-05-05 21:01:47 UTC
"chvt ${SPLASH_TTY}" (in addition to splash_silent) indeed works.

By the way, if booting without splash enabled on kernel cmdline, but still running the fbcondecor init.d service, libfbsplash.c mounts /lib/splash/cache, and it stays that way (unlike when splash is enabled on cmdline).
Comment 4 William Hubbs gentoo-dev 2011-05-10 20:48:33 UTC
This cannot block the openrc stabilization since it is already done on amd64/x86.
Comment 5 Michal Januszewski (RETIRED) gentoo-dev 2011-06-12 16:09:05 UTC
(In reply to comment #0)
> /sbin/splash-functions.sh and libfbsplash.c mount ${spl_cachedir} with
> mode=644, which doesn't make sense for a directory. Also suggest adding
> noexec,nosuid,nodev to this and similar mounts, to be compatible with the mount
> options used by OpenRC.

Done (in git).
 
> /etc/init.d/fbcondecor: uses ${RC_TTY_NUMBER}, whereas OpenRC defines
> ${rc_tty_number}. Suggest using ttyn=${rc_tty_number:-${RC_TTY_NUMBER:-12}},
> similar to other OpenRC init.d scripts.

Fixed in git, will be included in a new release.  -12 doesn't really make sense in the fbcondecor script, so I dropped that.

> Also, request propagating these and other (#339767) splashutils updates to the
> portage tree.

The updates in the bug you mentioned should already be included in the main portage tree in the form of patches.
Comment 6 Faustus 2011-06-12 16:24:35 UTC
(In reply to comment #5)
> > Also, request propagating these and other (#339767) splashutils updates to the portage tree.
> 
> The updates in the bug you mentioned should already be included in the main
> portage tree in the form of patches.

Ah, I see it now - splashutils-1.5.4.3-splash-functions.patch.

It's a wrong fix, because my initial comment (#1) in that bug had a typo (fixed in #2). And "mode" variable is not fixed either (it just runs splash_util, although maybe it works with splash_util.static - I tested with dynamic executable).

This works:

    local ctty=$(${spl_bindir}/fgconsole)
    local mode=$(${spl_util} -c getmode)
Comment 7 Michal Januszewski (RETIRED) gentoo-dev 2011-06-12 16:47:02 UTC
(In reply to comment #6)
> (In reply to comment #5)
> > > Also, request propagating these and other (#339767) splashutils updates to the portage tree.
> > 
> > The updates in the bug you mentioned should already be included in the main
> > portage tree in the form of patches.
> 
> Ah, I see it now - splashutils-1.5.4.3-splash-functions.patch.
> 
> It's a wrong fix, because my initial comment (#1) in that bug had a typo (fixed
> in #2). And "mode" variable is not fixed either (it just runs splash_util,
> although maybe it works with splash_util.static - I tested with dynamic
> executable).
> 
> This works:
> 
>     local ctty=$(${spl_bindir}/fgconsole)
>     local mode=$(${spl_util} -c getmode)

Ah, sorry about not spotting the typos earlier :/  This is now fixed in git.
Comment 8 Michal Januszewski (RETIRED) gentoo-dev 2011-06-12 16:47:16 UTC
(In reply to comment #6)
> (In reply to comment #5)
> > > Also, request propagating these and other (#339767) splashutils updates to the portage tree.
> > 
> > The updates in the bug you mentioned should already be included in the main
> > portage tree in the form of patches.
> 
> Ah, I see it now - splashutils-1.5.4.3-splash-functions.patch.
> 
> It's a wrong fix, because my initial comment (#1) in that bug had a typo (fixed
> in #2). And "mode" variable is not fixed either (it just runs splash_util,
> although maybe it works with splash_util.static - I tested with dynamic
> executable).
> 
> This works:
> 
>     local ctty=$(${spl_bindir}/fgconsole)
>     local mode=$(${spl_util} -c getmode)

Ah, sorry about not spotting the typos earlier :/  This is now fixed in git.
Comment 9 Michal Januszewski (RETIRED) gentoo-dev 2011-06-12 22:44:38 UTC
I've just pushed the official release of 1.5.4.4, which include the typo fixes in splash-functions.sh, fixes in the initscript and sys directory creation in the ebuild.

I couldn't reproduce the problems splash_svc_end and the hanging /lib/splash/cache mount.  Thanks for reporting all these problems.
Comment 10 Faustus 2011-06-14 08:11:28 UTC
(In reply to comment #9)
> I've just pushed the official release of 1.5.4.4, which include the typo fixes
> in splash-functions.sh, fixes in the initscript and sys directory creation in
> the ebuild.

Thanks! I checked, it works great.

One comment: you wrote that you will drop :-12, but currently it's still in /etc/init.d/fbcondecor, and in wrong form:
  ${rc_tty_number:-${RC_TTY_NUMBER}:-12}
should be
  ${rc_tty_number:-${RC_TTY_NUMBER:-12}}
if defaulting to 12 if neither var is set.

> I couldn't reproduce the problems splash_svc_end

This problem seems to be gone in 1.5.4.4.

> and the hanging /lib/splash/cache mount

This problem still persists in my tests (when using real VGA console, and not loading uvesafb), but I guess it's not worth to invest too much time into investigating it, since starting fbcondecor service on non-fb console is an edge case.
Comment 11 Michal Januszewski (RETIRED) gentoo-dev 2011-06-14 21:39:55 UTC
(In reply to comment #10)
> One comment: you wrote that you will drop :-12, but currently it's still in
> /etc/init.d/fbcondecor, and in wrong form:
>   ${rc_tty_number:-${RC_TTY_NUMBER}:-12}
> should be
>   ${rc_tty_number:-${RC_TTY_NUMBER:-12}}
> if defaulting to 12 if neither var is set.

Sorry, stupid typo :/  Just added a patch to fix this.
 
> > and the hanging /lib/splash/cache mount
> 
> This problem still persists in my tests (when using real VGA console, and not
> loading uvesafb), but I guess it's not worth to invest too much time into
> investigating it, since starting fbcondecor service on non-fb console is an
> edge case.

OK, I will then ignore it for now.  Please let me know if this somehow becomes more of a problem.
Comment 12 Faustus 2011-08-17 22:41:32 UTC
> and the hanging /lib/splash/cache mount

Just discovered that this problem (hanging mount when booting in text mode yet starting fbcondecor service) is gone when "splash=off" is added to the kernel's cmdline. This appears to be somewhat contrary to the documentation, which says that "splash=off" is the default behavior.
Comment 13 Pacho Ramos gentoo-dev 2013-01-20 10:17:49 UTC
What is the current status of this with 1.5.4.4-r2?
Comment 14 Faustus 2013-01-20 10:44:44 UTC
(In reply to comment #13)
> What is the current status of this with 1.5.4.4-r2?

I don't know, sorry. I stopped using splashutils.