Bugzilla Bug 36601

what can i say, it adds user in build time, thus creating user only in build
host. version used: cvs-1.11.11

and if somebody gonna fix this, maybe look also bug 36416



Reproducible: Always
Steps to Reproduce:
1.get binary package
2.install it


Actual Results:  
in my system /var/cvsroot being owned by dhcp user....


Portage 2.0.49-r15 (default-x86-1.4, gcc-3.2.3, glibc-2.3.2-r3, 2.4.22-ck3)
=================================================================
System uname: 2.4.22-ck3 i686
Gentoo Base System version 1.4.3.10
distcc[26115] (dcc_mkdir) ERROR: mkdir /home/glen/.distcc/state failed: 
Permission denied [enabled]
ACCEPT_KEYWORDS="x86"
AUTOCLEAN="yes"
CFLAGS="-O3 -mcpu=pentium2 -march=pentium2 -funroll-loops -pipe 
-fomit-frame-pointer"
CHOST="i686-pc-linux-gnu"
COMPILER="gcc3"
CONFIG_PROTECT="/etc /usr/kde/2/share/config /usr/kde/3/share/config 
/usr/X11R6/lib/X11/xkb /usr/kde/3.1/share/config /usr/share/config 
/var/qmail/control /var/qmail/alias"
CONFIG_PROTECT_MASK="/etc/gconf /etc/env.d"
CXXFLAGS="-O3 -mcpu=pentium2 -march=pentium2 -funroll-loops -pipe 
-fomit-frame-pointer"
DISTDIR="/usr/portage/distfiles"
FEATURES="sandbox ccache autoaddcvs distcc buildpkg userpriv"
GENTOO_MIRRORS="ftp://ftp.linux.ee/pub/gentoo/distfiles
http://ftp.uni-erlangen.
de/pub/mirrors/gentoo http://gentoo.linux.no/ ftp://gentoo.linux.no/pub/gentoo/ 
http://ftp.easynet.nl/mirror/gentoo/"
MAKEOPTS="-j14"
PKGDIR="/usr/portage/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://rsync.europe.gentoo.org/gentoo-portage"
USE="x86 oss avi cups encode gif gtk2 jpeg libg++ mad mpeg ncurses png
quicktime 
truetype xv zlib slang arts X sdl gpm pam libwww ssl imlib oggvorbis gtk opengl 
acpi artswrappersuid fbcon maildir md5sum memlimit mmx mozilla samba -apm
-crypt 
-foomaticdb kde -tcltk -python -gnome -mikmod -motif -nls -spell -svga -gdbm 
-tcpd -doc aalib lirc -esd -berkdb -perl -java javascript svga -xml2 -pdflib
-qt 
-readline tiff perl directfb dga ggi -xmms"

enewuser/enewgroup should not be used inside of src_install() ...

it should be used inside of pkg_setup() or pkg_preinst() or pkg_postinst() or pkg_config()

i'll update the manpages to reflect this

Since the cvs user/group is not required for building/installing cvs but only
for running the pserver I think pkg_postinst() would be the correct place to
add the user/group.

If there are no objections I am going to change that in the cvs ebuild later
today.
Anyway, our two "core" problems still exist
(http://bugs.gentoo.org/show_bug.cgi?id=36215#c3)

ok, after thinking about it I suppose it would be better to move it to
pkg_config() and use a little pkg_postinst() to tell the user that this will
generate the cvs user/group for use with a cvspserver.
We probably could also move the xinet.d file to pkg_config() so that people who
just use cvs client-side aren't bothered with anything pserver related and
those who want to run a pserver just need to use the ebuild ... config to get
the xinet.d file and the cvs user/group.

just as a heads up, I will be committing cvs-1.11.12 within the next days which
fixes that bug [moved it to pkg_setup()].

I also hope there's a solution for bug 36416 in the meantime.

should be fixed with cvs-1.11.13, please give it a go :)