Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 365575 - net-misc/sslh-1.7a - won't emerge without tcpd USE flag
Summary: net-misc/sslh-1.7a - won't emerge without tcpd USE flag
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: SpanKY
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-05-01 15:45 UTC by El Goretto
Modified: 2011-05-02 00:29 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description El Goretto 2011-05-01 15:45:51 UTC
Problem is not sslh itself, but rather the ebuild (well, Makefile is not totaly  "evident" either).

What I get with the regular ebuild without having tcp-wrappers installed:

>>> Emerging (1 of 1) net-misc/sslh-1.7a
 * sslh-1.7a.tar.gz RMD160 SHA1 SHA256 size ;-) ...                                                     [ ok ]
 * Package:    net-misc/sslh-1.7a
 * Repository: gentoo
 * USE:        elibc_glibc kernel_linux userland_GNU x86
 * FEATURES:   ccache sandbox userpriv usersandbox
>>> Unpacking source...
>>> Unpacking sslh-1.7a.tar.gz to /var/tmp/portage/net-misc/sslh-1.7a/work
>>> Source unpacked in /var/tmp/portage/net-misc/sslh-1.7a/work
>>> Preparing source in /var/tmp/portage/net-misc/sslh-1.7a/work/sslh-1.7a ...
>>> Source prepared.
>>> Configuring source in /var/tmp/portage/net-misc/sslh-1.7a/work/sslh-1.7a ...
>>> Source configured.
>>> Compiling source in /var/tmp/portage/net-misc/sslh-1.7a/work/sslh-1.7a ...
make -j5 CC=i686-pc-linux-gnu-gcc USELIBWRAP=0
i686-pc-linux-gnu-gcc -O2 -march=native -fomit-frame-pointer -pipe -Wall  -DLIBWRAP -D'VERSION="v1.7a"' -o sslh sslh.c -Wl,-O1 -Wl,--as-needed -lwrap
pod2man --section=8 --release="v1.7a" --center=" " sslh.pod | gzip -9 - > sslh.8.gz
sslh.c:41:18: erreur: tcpd.h : Aucun fichier ou dossier de ce type
sslh.c: In function ‘check_access_rights’:
sslh.c:251: attention : implicit declaration of function ‘hosts_ctl’
sslh.c:251: erreur: ‘STRING_UNKNOWN’ undeclared (first use in this function)
sslh.c:251: erreur: (Each undeclared identifier is reported only once
sslh.c:251: erreur: for each function it appears in.)
sslh.c: In function ‘setup_syslog’:
sslh.c:334: attention : ignoring return value of ‘asprintf’, declared with attribute warn_unused_result
make: *** [sslh] Erreur 1
make: *** Attente des tâches non terminées....
emake failed

So the faulty part in the ebuild may be:
src_compile() {
    emake \
        CC="$(tc-getCC)" \
        USELIBWRAP=$(use tcpd && echo 1 || echo 0) \
        || die
}

In fact, the Makefile of sslh is not very consistent, as it expect USELIBWRAP to be null if no libwrap feature:
ifneq ($(strip $(USELIBWRAP)),)
        LIBS:=$(LIBS) -lwrap
        CFLAGS:=$(CFLAGS) -DLIBWRAP
endif

So, a suggestion maybe: 
src_compile() {
    emake \
        CC="$(tc-getCC)" \
        USELIBWRAP=$(use tcpd && echo 1) \
        || die
}

I tested the modified ebuild with and without tcpd, it compiles fines.
Comment 1 Rafał Mużyło 2011-05-01 15:58:56 UTC
No maintainers in metadata, but not marked as maintainer-needed, so assigning to the person, who put it in the tree.
Comment 3 Rafał Mużyło 2011-05-02 00:29:41 UTC
(In reply to comment #2)

Not to nitpick, but could you either add yourself to metadata or mark it as maintainer-needed ?