Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 365233 - net-fs/samba-3.5.8-r1 fails to build on uclibc systems with USE=client
Summary: net-fs/samba-3.5.8-r1 fails to build on uclibc systems with USE=client
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Server (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's SAMBA Team
URL: https://bugzilla.samba.org/show_bug.c...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-28 17:41 UTC by Tom Lloyd
Modified: 2011-05-04 16:36 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Correct patch (mount.cifs.c.patch,1.08 KB, patch)
2011-04-28 21:31 UTC, Tom Lloyd
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Lloyd 2011-04-28 17:41:14 UTC
The build fails because client/mount.cifs.c declares the fstab.h header, which isn't provided by uclibc.

Further details and patch are here: https://bugzilla.samba.org/show_bug.cgi?id=7539

Apparently the patch has been applied to a 4.x release, but since those are masked in Gentoo it seems like a good idea to add this to our ebuilds for the time being.

emerge --info, build log, etc. on request, but I don't see the point as the upstream developers have already confirmed and fixed the bug and it just needs retro-fitting to 3.x releases.
Comment 1 Tom Lloyd 2011-04-28 21:31:18 UTC
Created attachment 271503 [details, diff]
Correct patch

I tried the patches from Samba's Bugzilla, and neither of them seemed to work.  So I patched the offending file manually, and it compiled OK.

This is the patch I used: it works against a fully unpacked net-fs/samba-3.5.8-r1 source tree.
Comment 2 Víctor Ostorga (RETIRED) gentoo-dev 2011-05-04 16:36:38 UTC
Commited, thanks for the patch 

+  04 May 2011; Víctor Ostorga <vostorga@gentoo.org> samba-3.5.8-r1.ebuild,
+  +files/3.5/samba-3.5.8-uclib-build.patch:
+  Fix build on uclibc systems, bug 365233 patch thanks to Tom Lloyd
+  <napalmllama@gmail.com>
+