365123 – app-portage/layman-1.4.2-r1 errors on --sync

Bug 365123 - app-portage/layman-1.4.2-r1 errors on --sync

Summary: app-portage/layman-1.4.2-r1 errors on --sync

Status:	RESOLVED FIXED

Alias:	None

Product:	Portage Development
Classification:	Unclassified
Component:	Third-Party Tools (show other bugs)
Hardware:	All Linux

Importance:	Normal normal with 1 vote (vote)
Assignee:	Christian Ruppert (idl0r)

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2011-04-27 19:20 UTC by Albert W. Hopkins
Modified:	2011-04-28 11:12 UTC (History)
CC List:	6 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
emerge --info (info.txt,2.59 KB, text/plain) 2011-04-27 19:20 UTC, Albert W. Hopkins	Details
corrected patch (layman-1.4.2-python-compatbility-fix.patch,7.68 KB, patch) 2011-04-28 02:48 UTC, Brian Dolbec (RETIRED)	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Albert W. Hopkins 2011-04-27 19:20:37 UTC

Created attachment 271363 [details]
emerge --info

# layman --sync ALL
* 
* Errors:
* ------
* 
* Failed to sync overlay "gnome".
* Error was: can only concatenate list (not "str") to list
* 
* Failed to sync overlay "marduk".
* Error was: run_command() takes exactly 2 arguments (5 given)

This doesn't happen when downgrading to 1.4.1.

Comment 1 tman 2011-04-27 19:54:38 UTC

i can confirm this bug too.

Comment 2 Erik Zeek 2011-04-27 21:51:45 UTC

This error didn't occur with 1.4.2 either.

Comment 3 Erik Zeek 2011-04-27 21:52:50 UTC

*** This bug has been confirmed by popular vote. ***

Comment 4 Albert W. Hopkins 2011-04-27 22:01:22 UTC

Seems I forgot to run etc-update.

After running etc-update, all fixed now.

Leaving open for the time being.

Comment 5 Albert W. Hopkins 2011-04-27 22:04:21 UTC

Argh, I take that back.  I was confused about which version of layman I had installed.

The problem persists.  Leaving open.

Comment 6 Erik Zeek 2011-04-28 00:04:15 UTC

Commenting out the python compatibility patch gets layman working again.

Comment 7 Nick Novikov 2011-04-28 01:39:14 UTC

I confirm.

BTW, layman's error messages should give more details about failure - names of module and function, line number etc.

Comment 8 Brian Dolbec (RETIRED) gentoo-dev

2011-04-28 02:30:34 UTC

Sorry everyone,  It was a communication error on our part.  It turned out the compatibility patch pushed to the tree only contained my last commit.  But it needed both of the last 2 commits for it to be complete and work correctly.  Honest I tested it first before committing!

I'm preparing a corrected patch and will post it here/get the tree updated asap.


And I agree that the error messages suck.  I only recently took over development/maintenance of layman.  I did not do any development for the current codebase up to and including 1.4.2.  Only the python2.5 compatibility fixes/breakage (oops) :(.

For the current live ebuild I have been working on an extensive cleanout/re-write of the api.  The error reporting is already much better.  It is also faster and more flexible in it's potential use...

Comment 9 Brian Dolbec (RETIRED) gentoo-dev

2011-04-28 02:48:08 UTC

Created attachment 271407 [details, diff]
corrected patch

Comment 10 Jeremy Olexa (darkside) (RETIRED) archtester

2011-04-28 03:20:34 UTC

+*layman-1.4.2-r2 (28 Apr 2011)
+
+  28 Apr 2011; Jeremy Olexa <darkside@gentoo.org> -layman-1.4.2-r1.ebuild,
+  +layman-1.4.2-r2.ebuild, files/layman-1.4.2-python-compatbility-fix.patch:
+  Revision bump to fix broken sync function, bug 365123. New patch by Brian
+  Dolbec

Close the bug when you see fit :)

Comment 11 tman 2011-04-28 04:16:10 UTC

patch seems to work fine now.
 this report can be close as resolved. thanks to @ll

Comment 12 Christian Ruppert (idl0r) gentoo-dev

2011-04-28 11:12:24 UTC

Thanks guys!