Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 364753 - dev-libs/nspr-4.8.7: 'nspr-4.8-config.patch' causes 'nspr-config --libs' to contain -R option
Summary: dev-libs/nspr-4.8.7: 'nspr-4.8-config.patch' causes 'nspr-config --libs' to c...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: AMD64 OS X
: Normal normal (vote)
Assignee: Gentoo Prefix
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 354523
  Show dependency tree
 
Reported: 2011-04-25 06:51 UTC by James G. Kim
Modified: 2011-09-24 15:08 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description James G. Kim 2011-04-25 06:51:03 UTC
The last portion of the patch makes 'nspr-config --libs' to have -R option, which causes emerging portages like dev-lang/spidermonkey to fail with 'ld: unknown option: -R'.

--- mozilla/nsprpub/config/nspr-config.in.orig  2005-05-11 00:53:41.000000000 +0000
+++ mozilla/nsprpub/config/nspr-config.in       2006-01-15 06:37:58.000000000 +0000
@@ -122,7 +122,7 @@
 fi

 if test "$echo_libs" = "yes"; then
-      libdirs=-L$libdir
+      libdirs="-Wl,-R$libdir -L$libdir"
       if test -n "$lib_plds"; then
        libdirs="$libdirs -lplds${major_version}"
       fi
Comment 1 Fabian Groffen gentoo-dev 2011-04-25 07:28:56 UTC
hmmm, that sounds like the problem of bug #354523
Comment 2 James G. Kim 2011-04-25 07:32:07 UTC
(In reply to comment #1)
> hmmm, that sounds like the problem of bug #354523

Yes, it's the cause behind the bug #354523.
Comment 3 Fabian Groffen gentoo-dev 2011-04-25 07:34:11 UTC
this version comes from an overlay, doesn't it?

the problem is that the patch unconditionally adds -R in nspr-config, whereas it guards it for Linux in the makefiles

Odd, since for Linux one would typically use -rpath=, which works on Solaris too with GNU ld, but -R is there for Solaris, for which it isn't used due to the conditional.
Comment 4 James G. Kim 2011-04-25 07:36:42 UTC
(In reply to comment #3)
> this version comes from an overlay, doesn't it?

No, it comes from the main 'Gentoo Prefix' repo.

> the problem is that the patch unconditionally adds -R in nspr-config, whereas
> it guards it for Linux in the makefiles
> 
> Odd, since for Linux one would typically use -rpath=, which works on Solaris
> too with GNU ld, but -R is there for Solaris, for which it isn't used due to
> the conditional.
Comment 5 Fabian Groffen gentoo-dev 2011-04-25 08:07:39 UTC
what I don't understand is why they don't just call pkg-config, like they do for commands like libdir.  It seems to return the correct value to me.  (`pkg-config --libs nspr` that is)
Comment 6 Fabian Groffen gentoo-dev 2011-09-24 15:08:30 UTC
ok, fixed in 4.8.9 now