Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 363149 - sys-auth/pam_mount fix crypt use flag
Summary: sys-auth/pam_mount fix crypt use flag
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Hanno Böck
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-04-11 19:36 UTC by Sander Sweers
Modified: 2011-05-22 16:13 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
pam_mount 2.8 ebuild patch (pam_mount-2.8-crypt-use.patch,1.01 KB, patch)
2011-04-11 19:36 UTC, Sander Sweers
Details | Diff
configure fix (pam_mount-2.8-configure-crypt-fix.patch,1.44 KB, patch)
2011-04-11 19:38 UTC, Sander Sweers
Details | Diff
Ebuild patch pam_mount-2.10 (pam_mount-2.10.ebuild.patch,1.53 KB, patch)
2011-04-17 16:48 UTC, Sander Sweers
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sander Sweers 2011-04-11 19:36:28 UTC
Created attachment 269513 [details, diff]
pam_mount 2.8 ebuild patch

currently sys-auth/pam_mount has a crypt use flag but it does absolutely nothing AFAICS. The attached ebuild patch will {dis,en}able cryptsetup support.

While doing this I noticed the configure script was broken as it always enabled cryptsetup regardless of what we pass it via --with/without-cryptsetup. This was fixed already upstream [1]. This patch I will also attach to this bug report.

[1] http://pam-mount.git.sourceforge.net/git/gitweb.cgi?p=pam-mount/pam-mount;a=commitdiff;h=0373cf86f65c5d338b53f0b2cb060252c398a73e;hp=29d23c4f429e87d1449309e2e247cd2e47d72120

Portage 2.1.9.45 (default/linux/amd64/10.0/desktop, gcc-4.5.2, glibc-2.13-r2, 2.6.38-gentoo-r1 x86_64)
=================================================================
System uname: Linux-2.6.38-gentoo-r1-x86_64-AMD_Phenom-tm-_II_X4_945_Processor-with-gentoo-2.0.2
Timestamp of tree: Sun, 10 Apr 2011 18:15:01 +0000
ccache version 3.1.4 [disabled]
app-shells/bash:     4.2_p8
dev-java/java-config: 2.1.11-r3
dev-lang/python:     2.6.6-r2, 2.7.1-r1, 3.1.3-r1
dev-util/ccache:     3.1.4
dev-util/cmake:      2.8.4
sys-apps/baselayout: 2.0.2
sys-apps/openrc:     0.8.0
sys-apps/sandbox:    2.5
sys-devel/autoconf:  2.13, 2.68
sys-devel/automake:  1.9.6-r3, 1.10.3, 1.11.1-r1
sys-devel/binutils:  2.21
sys-devel/gcc:       4.5.2
sys-devel/gcc-config: 1.4.1
sys-devel/libtool:   2.4-r1
sys-devel/make:      3.82
virtual/os-headers:  2.6.38 (sys-kernel/linux-headers)
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* -@EULA AdobeFlash-10.1 dlj-1.1 googleearth"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O1 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config /usr/share/gnupg/qualified.txt"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-march=native -O1 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="assume-digests binpkg-logs candy distlocks fixlafiles fixpackages news parallel-fetch protect-owned sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch"
FFLAGS=""
GENTOO_MIRRORS="ftp://ftp.snt.utwente.nl/pub/os/linux/gentoo"
LANG="nl_NL@euro"
LC_ALL="nl_NL@euro"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="en en_GB nl"
MAKEOPTS="-j8"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/portmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage/multimedia /usr/local/portage/mine"
SYNC="rsync://rsync.nl.gentoo.org/gentoo-portage"
USE="3dnow 3dnowext X a52 aac acl acpi alsa amd64 archive avahi bash-completion berkdb bluetooth bluray branding bzip2 cairo cdda cdio cdr cli consolekit cracklib crypt cue cups cxx dbus device-mapper dirac dri dts dvd dvdr emboss encode exif faac fam ffmpeg firefox flac fortran fuse gallium gconf gdbm gdu gif gnome gpm gstreamer gtk gtk+ iconv ipv6 ipython java jbig jpeg kde lame lcms ldap libmms libnotify lzma lzo mad mikmod mmx mmxext mng modules mp3 mp4 mpeg mplayer mudflap multilib musepack nautilus ncurses networkmanager nls nptl nptlonly ogg opengl openmp pam pango pch pcre pdf perl phonon png policykit ppds pppd python qt3 qt3support qt4 quicktime readline rle samba schroedinger sdl semantic-desktop session sndfile speex spell sse sse2 sse3 ssl ssse3 startup-notification svg sysfs systemd sysv taglib tcpd theora threads tiff tracker truetype tslib udev unicode usb vaapi vdpau vorbis vpx wav wavpack wmf x264 xcb xcomposite xml xorg xspf xulrunner xv xvid zeroconf zip zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CAMERAS="ptp2" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en en_GB nl" PHP_TARGETS="php5-3" RUBY_TARGETS="ruby18" USERLAND="GNU" VIDEO_CARDS="radeon fbdev vesa" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" 
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Sander Sweers 2011-04-11 19:38:37 UTC
Created attachment 269515 [details, diff]
configure fix

This fixes the unconditionally enabling of crypt{o,setup}.
Comment 2 Sander Sweers 2011-04-17 16:48:58 UTC
Created attachment 270297 [details, diff]
Ebuild patch pam_mount-2.10

* Add more dependencies and/or min version per install.txt and configure.ac
* Add selinux and ssl use flags and required econf variables
* move to EAPI 4 (I hope I got all of it)

The new version 2.10 fixes all the build system issues so the patch is not needed anymore. So please also consider this as a version bump :-).

I have been running this with no issues.
Comment 3 Matt Turner gentoo-dev 2011-05-14 20:28:44 UTC
(Sorry it took so long)

Thanks for the patch! I just committed it and also split out common dependencies into a COMMON_DEPEND.

Marking as FIXED. Let me know if you spot anything wrong.
Comment 4 Sander Sweers 2011-05-17 21:21:52 UTC
Well, the minimum required version are either not updated or too high.

libhx should be >=3.6 but new ebuild >=3.10.1
libxml2 should be >=2.6 but ebuild has none
openssl should be >= 0.9.8 but ebuild has none

I pulled all these number from the *tarball's* confugure.ac, checked against configure. Yes TRUNK has a requirement of libhx 3.10.1 but not version 2.10.

Also lsof is not used anymore since version 0.45 (2008!) and ofl is used instead... hence my patch removed this from from RDEPEND.
Comment 5 Matt Turner gentoo-dev 2011-05-21 22:33:52 UTC
(In reply to comment #4)
> Well, the minimum required version are either not updated or too high.

Thanks a lot for the comments.

I've added version dependencies for libxml2 and openssl and removed the RDEPEND on lsof, but I've left the libhx dependency at 3.10.1. Since these versions of libhx and pam_mount aren't stabilized on any architecture, and libhx isn't depended on by anything else in the tree other than pam_mount, I don't think it's a problem to require the latest libhx.
Comment 6 Sander Sweers 2011-05-22 13:09:09 UTC
(In reply to comment #5)
> I don't think it's a problem to require the latest libhx.

What is the point of (R)DEPEND then? Why not have all packages require the latest version available. The whole point of DEPEND is to have the minimum version to make the package build/run.

Anyway, I am done arguing about this.
Comment 7 Matt Turner gentoo-dev 2011-05-22 16:13:51 UTC
(In reply to comment #6)
> (In reply to comment #5)
> > I don't think it's a problem to require the latest libhx.
> 
> What is the point of (R)DEPEND then? Why not have all packages require the
> latest version available. The whole point of DEPEND is to have the minimum
> version to make the package build/run.
> 
> Anyway, I am done arguing about this.

Does this cause some kind of problem?

Usually libhx and pam_mount releases are made about the same time, and libhx is only in the tree as a dependency to pam_mount. It doesn't seem like a problem to consider these as more-or-less a single package.

But since it seems to upset you, I'll change the required libhx version.