Created attachment 268241 [details] Adds optional java support to ebuild This is a patch to add optional support for java to gettext. What is does is it installs the jar files and the javadocs using java-pkg functions. This results in a directory api and lib being added under /usr/share/gettext/ as well as the file package.env. This is a possible solution to get optional java support to gettext. Another way could be to create a package gettext-java and PDEPEND on it according to gettexts java useflag. Also the javadocs seem not to be regenerated on build and so the build system might need to be fixed as well. This could result in yet another solution. I can try to get other ways to work. What do you see as the proper path.
Please don't CC random maintainers when you cannot assign bugs.
(In reply to comment #1) > Please don't CC random maintainers when you cannot assign bugs. I was asked to add java@gentoo.org. Re-adding it. I added base-sytem@gentoo.org as it's the herd of the package, sorry for that. Won't happen again.
i dont care about java. if the java team is OK with the patch, they may commit it to the gettext package.
Patch looks fine except for just one line.... java-pgk-opt-2_src_prepare pgk??? Will attempt to get to this tonight.
(In reply to comment #4) > Patch looks fine except for just one line.... > > java-pgk-opt-2_src_prepare > > pgk??? > > Will attempt to get to this tonight. Oh, nicely spotted. Thanks, for looking into it.
/var/tmp/portage/sys-devel/gettext-0.18.1.1-r2/temp/environment: line 4449: java-pkg-opt_pkg_preinst: command not found I also suggest to call java-pkg-opt-2_src_prepare() and java-pkg-opt-2_pkg_preinst() only with USE="java".
`use java` wouldnt fix the typos in the func names ...
(In reply to comment #6) > /var/tmp/portage/sys-devel/gettext-0.18.1.1-r2/temp/environment: line 4449: > java-pkg-opt_pkg_preinst: command not found > Fixed. > > I also suggest to call java-pkg-opt-2_src_prepare() and > java-pkg-opt-2_pkg_preinst() only with USE="java". > The eclass takes care of checking the use flag.
