Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 361129 - =dev-db/tokyocabinet-1.4.47 stabilization
Summary: =dev-db/tokyocabinet-1.4.47 stabilization
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Normal minor (vote)
Assignee: Patrick Lauer
URL:
Whiteboard:
Keywords: STABLEREQ
Depends on:
Blocks:
 
Reported: 2011-03-29 14:17 UTC by Agostino Sarubbo
Modified: 2011-09-25 17:36 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2011-03-29 14:17:27 UTC
$summary

example:


x86_64-pc-linux-gnu-gcc -march=native -O2 -g0 -std=c99 -Wall -fPIC -fsigned-char -O2 -o tcfmgr tcfmgr.o -Wl,-O1 -Wl,--as-needed -Wl,--hash-style=gnu -L. -L/usr/lib64 -L/tmp/portage/dev-db/tokyocabinet-1.4.46/homedir/lib -L/usr/local/lib  -ltokyocabinet -lbz2 -lz -lrt -lpthread -lm -lc 


the last -O2 overwrites my -O?
Comment 1 Patrick Lauer gentoo-dev 2011-04-01 16:05:46 UTC
Yes, that's not so nice.

From configure.in:

if test "$enable_devel" = "yes"
then
  MYCFLAGS="-std=c99 -Wall -fPIC -pedantic -fsigned-char -g -O2 -pipe"

so that should be patched, and in 1.4.47 that has been rewritten again. I think I'll just try to fix up .47 and file a stablerequest, that should make everyone happy :)
Comment 2 Patrick Lauer gentoo-dev 2011-04-01 17:11:49 UTC
Sanitized in .47, that should be a lot nicer now.

Arch teams: Please stabilize 1.4.47
Comment 3 Agostino Sarubbo gentoo-dev 2011-04-01 18:50:41 UTC
-fomit-frame-pointer is added arbitrarily but it works
Comment 4 Patrick Lauer gentoo-dev 2011-04-01 22:26:25 UTC
(In reply to comment #3)
> -fomit-frame-pointer is added arbitrarily but it works

Aw crummy, I removed that too. So it should make you happy now ...
Comment 5 Christoph Mende (RETIRED) gentoo-dev 2011-04-02 07:10:15 UTC
amd64 done, thanks Agostino
Comment 6 Jeroen Roovers (RETIRED) gentoo-dev 2011-04-04 23:07:21 UTC
Stable for HPPA.
Comment 7 Andreas Schürch gentoo-dev 2011-04-05 12:13:16 UTC
Looks good here on x86.
Comment 8 Thomas Kahle (RETIRED) gentoo-dev 2011-04-25 14:32:19 UTC
x86 stable. Thanks Andreas
Comment 9 Agostino Sarubbo gentoo-dev 2011-07-02 08:25:09 UTC
ping!

other arch does not want stabilize?
Comment 10 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev 2011-07-15 14:25:55 UTC
It appends -minline-all-stringops to CFLAGS. That's x86/amd64 specific therefore build fails for other arches, please fix it
Comment 11 Patrick Lauer gentoo-dev 2011-08-13 08:11:43 UTC
+  13 Aug 2011; Patrick Lauer <patrick@gentoo.org> tokyocabinet-1.4.47.ebuild:
+  Fixing CFLAGS for #361129

That should make it work on non-x86. Maybe making it respect system CFLAGS is a better fix, I'm open for good ideas.
Comment 12 Kacper Kowalik (Xarthisius) (RETIRED) gentoo-dev 2011-08-15 07:58:50 UTC
ppc/ppc64 stable
Comment 13 Raúl Porcel (RETIRED) gentoo-dev 2011-09-25 17:36:00 UTC
alpha stable, closing