Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 360703 - media-sound/clementine-0.7_rc1 adds Werror to CXXFLAGS
Summary: media-sound/clementine-0.7_rc1 adds Werror to CXXFLAGS
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Unspecified (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-03-27 06:11 UTC by Zeev Tarantov
Modified: 2011-03-28 11:50 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to not add Werror to CXXFLAGS (clementine-0.7_rc1-werror.patch,403 bytes, patch)
2011-03-27 06:12 UTC, Zeev Tarantov
Details | Diff
patch to ebuild to apply previous patch (clementine-0.7_rc1.ebuild,3.28 KB, patch)
2011-03-27 06:13 UTC, Zeev Tarantov
Details | Diff
patch to not add Werror to CXXFLAGS - fixed (clementine-0.7_rc1-werror.patch,448 bytes, patch)
2011-03-27 06:19 UTC, Zeev Tarantov
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zeev Tarantov 2011-03-27 06:11:51 UTC
Someone left a line that adds -Werror to CXXFLAGS in the CMakefile. Obviously, it errors out when you have different warnings or a different version of GCC. On today's GCC 4.6.0 (no longer pre-release!) with default options and just -O2, it doesn't build. Attached patch fixes this.

Reproducible: Always




Portage 2.2.0_alpha28 (default/linux/amd64/10.0/desktop, gcc-4.6.0-pre9999, glibc-2.13-r2, 2.6.38.1 x86_64)
=================================================================
System uname: Linux-2.6.38.1-x86_64-Intel-R-_Core-TM-2_Duo_CPU_E6550_@_2.33GHz-with-gentoo-2.0.2
Timestamp of tree: Sun, 27 Mar 2011 00:45:01 +0000
app-shells/bash:     4.2_p8
dev-java/java-config: 2.1.11-r3
dev-lang/python:     2.7.1-r1, 3.1.3-r1
dev-util/cmake:      2.8.4
sys-apps/baselayout: 2.0.2
sys-apps/openrc:     0.8.0
sys-apps/sandbox:    2.5
sys-devel/autoconf:  2.13, 2.68
sys-devel/automake:  1.10.3, 1.11.1
sys-devel/binutils:  2.21.51.0.7
sys-devel/gcc:       4.5.2, 4.6.0_pre9999::toolchain
sys-devel/gcc-config: 1.5-r1
sys-devel/libtool:   2.4-r1
sys-devel/make:      3.82
virtual/os-headers:  2.6.38 (sys-kernel/linux-headers)
Repositories: gentoo mozilla voyageur lcd-filtering gcc-porting toolchain local_overlay
Installed sets: 
ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="* SKYPE-EULA"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-g -O2 -fexcess-precision=fast -Wno-unused-result"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/config"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/env.d/java/ /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo"
CXXFLAGS="-g -O2 -fexcess-precision=fast -Wno-unused-result"
DISTDIR="/usr/portage/distfiles"
FEATURES="assume-digests binpkg-logs distlocks fixlafiles fixpackages installsources news parallel-fetch preserve-libs protect-owned sandbox sfperms splitdebug strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync"
FFLAGS=""
GENTOO_MIRRORS="http://mirror.isoc.org.il/pub/gentoo/ "
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LINGUAS="en en_US"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/home/system/var_tmp_portage"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/var/lib/layman/mozilla /var/lib/layman/voyageur /var/lib/layman/lcd-filtering /var/lib/layman/gcc-porting /var/lib/layman/toolchain /usr/local/portage"
SYNC="rsync://rsync.namerica.gentoo.org/gentoo-portage"
USE="X a52 aac acl acpi alsa amd64 bash-completion bidi bluetooth branding bzip2 cairo cdr cli cracklib crypt cxx dbus dri dts dvd dvdr emboss encode exif fam firefox flac gdu gif gpm gtk iconv ipv6 jpeg lcdfilter lcms libnotify lzma mad mikmod mmx mng modules mp3 mp4 mpeg mudflap multilib ncurses nptl nptlonly ogg opengl openmp pango pch pcre pdf perl png policykit ppds pppd python qt3support qt4 readline sdl session spell sqlite3 sse sse2 ssl startup-notification svg sysfs tcpd tiff truetype udev unicode usb vorbis x264 xcb xcomposite xml xorg xulrunner xv xvid zlib" ALSA_CARDS="hda-intel" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mmap_emul mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CAMERAS="stv0680" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf superstar2 timing tsip tripmate tnt ubx" INPUT_DEVICES="evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en en_US" PHP_TARGETS="php5-3" QEMU_SOFTMMU_TARGETS="arm i386 ppc ppc64 sparc x86_64" QEMU_USER_TARGETS="i386 x86_64" RUBY_TARGETS="ruby18" SANE_BACKENDS="niash stv680" USERLAND="GNU" VIDEO_CARDS="nv nvidia nouveau" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account" 
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Zeev Tarantov 2011-03-27 06:12:53 UTC
Created attachment 267345 [details, diff]
patch to not add Werror to CXXFLAGS
Comment 2 Zeev Tarantov 2011-03-27 06:13:19 UTC
Created attachment 267347 [details, diff]
patch to ebuild to apply previous patch
Comment 3 Zeev Tarantov 2011-03-27 06:19:57 UTC
Created attachment 267349 [details, diff]
patch to not add Werror to CXXFLAGS - fixed
Comment 4 Samuli Suominen (RETIRED) gentoo-dev 2011-03-28 00:19:47 UTC
+*clementine-0.7 (28 Mar 2011)
+
+  28 Mar 2011; Samuli Suominen <ssuominen@gentoo.org> +clementine-0.7.ebuild:
+  Version bump wrt #360845 by Agostino Sarubbo. Remove -Werror from
+  src/CMakeLists.txt wrt #360703 by Zeev Tarantov.


The patch loosk good, you should submit it to the upstream ticketing system at googlecode. It can't be what they want...

Meanwhile I've done this with oneliner sed in the ebuild
Comment 5 Zeev Tarantov 2011-03-28 11:50:11 UTC
According to upsteam: "Source builds are for developers. Developers want the build to break when there are compiler warnings." (http://code.google.com/p/clementine-player/issues/detail?id=1637)

So all Gentoo users are developers of Clementine and want the build to break when there are warnings. If not, Gentoo has to patch out -Werror by itself - it will not be removed.

Also, GIO is apparently unstable and disabled by default and it being compiled is proof that I am not a regular user (that, of course, and me using the just released GCC 4.6.0).