Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 36068 - cjk ttf patches for xfree(xft), fontconfig and freetype.
Summary: cjk ttf patches for xfree(xft), fontconfig and freetype.
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: CJK Team
URL: http://www.kde.gr.jp/~akito/patch/dow...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-12-18 08:37 UTC by Akinori Hattori
Modified: 2006-04-07 05:43 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
xfree-4.3.0-r3.ebuild.diff (xfree-4.3.0-r3.ebuild.diff,635 bytes, patch)
2003-12-18 08:39 UTC, Akinori Hattori
Details | Diff
xft-2.1.1-MakeBold-20030927.patch (xft-2.1.1-MakeBold-20030927.patch,16.43 KB, patch)
2003-12-18 08:39 UTC, Akinori Hattori
Details | Diff
fontconfig-2.2.1.ebuild.diff (fontconfig-2.2.1.ebuild.diff,371 bytes, patch)
2003-12-18 08:40 UTC, Akinori Hattori
Details | Diff
fontconfig-2.2.1-Bold-conf.patch (fontconfig-2.2.1-Bold-conf.patch,657 bytes, patch)
2003-12-18 08:43 UTC, Akinori Hattori
Details | Diff
freetype-2.1.5.ebuild.diff (freetype-2.1.5.ebuild.diff,545 bytes, patch)
2003-12-18 08:44 UTC, Akinori Hattori
Details | Diff
freetype-2.1.5-autohint-cjkfonts-20031105.patch (freetype-2.1.5-autohint-cjkfonts-20031105.patch,64.29 KB, patch)
2003-12-18 08:45 UTC, Akinori Hattori
Details | Diff
xft-2.1.1-MakeBold-20030927.patch (xft-2.1.1-MakeBold-20030927.patch,16.51 KB, patch)
2003-12-23 07:39 UTC, Akinori Hattori
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Akinori Hattori gentoo-dev 2003-12-18 08:37:16 UTC
Hello!

These are patches for xfree(xft), fontconfig and freetype.
If you apply these patches, you can look bold font with cjk truetype fonts.
and you can get good autohint.

I thought that I should use cjk use flag at first. but this patch is not so big
and xfree need many compile time, so apply the patch always.
If you don't like this way, I will rewrite to use cjk use flag as soon as possible.

These patches from http://www.kde.gr.jp/~akito/patch/download.html.

Please apply these patches.

Thank you.

Reproducible: Always
Steps to Reproduce:
Comment 1 Akinori Hattori gentoo-dev 2003-12-18 08:39:02 UTC
Created attachment 22403 [details, diff]
xfree-4.3.0-r3.ebuild.diff

diff for the revision 1.91
Comment 2 Akinori Hattori gentoo-dev 2003-12-18 08:39:31 UTC
Created attachment 22404 [details, diff]
xft-2.1.1-MakeBold-20030927.patch
Comment 3 Akinori Hattori gentoo-dev 2003-12-18 08:40:40 UTC
Created attachment 22405 [details, diff]
fontconfig-2.2.1.ebuild.diff
Comment 4 Akinori Hattori gentoo-dev 2003-12-18 08:43:02 UTC
Created attachment 22407 [details, diff]
fontconfig-2.2.1-Bold-conf.patch

id=22405

diff for the revision 1.12.
Comment 5 Akinori Hattori gentoo-dev 2003-12-18 08:44:30 UTC
Created attachment 22408 [details, diff]
freetype-2.1.5.ebuild.diff

diff for the revision 1.3
Comment 6 Akinori Hattori gentoo-dev 2003-12-18 08:45:22 UTC
Created attachment 22409 [details, diff]
freetype-2.1.5-autohint-cjkfonts-20031105.patch

this is an autohint patch for freetype 2.1.5.
Comment 7 Donnie Berkholz (RETIRED) gentoo-dev 2003-12-18 09:15:40 UTC
Have these already been added upstream to CVS/newer releases than we have? If not, they probably should be.
Comment 8 Akinori Hattori gentoo-dev 2003-12-20 02:02:30 UTC
not yet added.
Comment 9 Donnie Berkholz (RETIRED) gentoo-dev 2003-12-20 06:09:15 UTC
Could you please remake xft-2.1.1-MakeBold-20030927.patch so it applies from ${WORKDIR}? In other words, it needs to be from outside xc, so that it can be applied in bulk patching instead of the custom ebuild hack used in this case.

Suggested procedure for this is: cd ${WORKDIR}; mkdir -p xc.orig/lib; cp -r xc/lib/Xft xc.orig/lib/; make changes; diff -urN xc.orig/lib/Xft xc/lib/Xft.

Thanks for your contribution. Would you like us to submit them upstream, assuming there are no problems with them, or would you prefer to do so?
Comment 10 Akinori Hattori gentoo-dev 2003-12-23 07:39:29 UTC
Created attachment 22581 [details, diff]
xft-2.1.1-MakeBold-20030927.patch

like this?

and I'm not author of these patches, but yes please.
Comment 11 Donnie Berkholz (RETIRED) gentoo-dev 2003-12-23 12:30:08 UTC
Yes, perfect.

Foser, we talked briefly about this. Could you put your input on these patches here please?

Also some input from CJK people on how well this works, how useful it is, etc. would be helpful.
Comment 12 Ken Deeter 2003-12-24 15:26:44 UTC
Hi, just responding to the request for comment.

For Japanese users, the Make bold patch is indispensable, as most japanese fonts come with embedded bitmaps for the smaller sizes, and a bold version fo these characters is not provided. Even windows uses a double striking technique to achieve bold characters for these sizes. Right now, anything that tries to use bold fonts will just use a non-bold version, making it indistinguishable from normal type.

I actually posted a message on the fontconfig mailing list a while ago about these patches (or earlier versions of them) but I didn't get any response from Kieth Packard. Maybe you guys can have better luck.
Comment 13 Donnie Berkholz (RETIRED) gentoo-dev 2003-12-24 15:49:14 UTC
The xlibs@pdx.freedesktop.org list would probably be the proper one for Xft. Not sure about the others.
Comment 14 Mamoru KOMACHI (RETIRED) gentoo-dev 2003-12-26 12:05:08 UTC
Ken said almost all what I wanted to say :) It looks quite nice
especially when you use desktop environments such as KDE and GNOME.
It may cause some problem for non-cjk users but it'll be okay
if we use cjk USE flag to decide whether we apply the patches or not.
I'm tempted to include the patch, what do you think, foser?

Just FYO, I sent an email to the patches' author about contacting
upstream but I haven't got a reply yet. (I didn't contact to
fontconfig people)
Comment 15 Donnie Berkholz (RETIRED) gentoo-dev 2004-01-26 21:27:07 UTC
foser:
still waiting to hear from you on this?
Comment 16 foser (RETIRED) gentoo-dev 2004-01-27 03:50:58 UTC
The cjk fonts patch i'll try to add ASAP (with cjk in USE).

The bold fonts stuff i'm not too happy about as you know.
Comment 17 Donnie Berkholz (RETIRED) gentoo-dev 2004-01-27 06:22:18 UTC
Thanks foser, just trying to make decisions on what's going in xfree-4.3.0-r4.
Comment 18 foser (RETIRED) gentoo-dev 2004-02-15 14:17:29 UTC
I just added the cjk autohint patch to freetype-2.1.5-r1, that should close part of this issue.

The boldness stuff i'm still not hot about.
Comment 19 Yu Wang 2004-02-27 21:34:53 UTC
I don't find the patches fontconfig-2.2.1-Bold-conf.patch and xft-2.1.1-MakeBold-20030927.patch in the corresponding ebuild directories. PLEASE add them to the portage tree. I don't want to apply them manually and everything got reset after emerge sync.

Thanks a lot!
Comment 20 Donnie Berkholz (RETIRED) gentoo-dev 2004-02-27 21:51:31 UTC
Then use them in your overlay. It's foser's call on those, and he's obviously not very keen on them.
Comment 21 foser (RETIRED) gentoo-dev 2006-04-07 05:43:08 UTC
optional embolden has been added to recent fontconfig/xft versions.